KAFKA-9992: EmbeddedKafkaCluster.deleteTopicAndWait not working with kafka_2.13#8673
Merged
vvcephei merged 2 commits intoapache:trunkfrom May 19, 2020
Merged
Conversation
Contributor
Author
|
@vvcephei without the scala to java converter it would be compatible. |
vvcephei
approved these changes
May 15, 2020
Contributor
vvcephei
left a comment
vvcephei
left a comment
There was a problem hiding this comment.
Hey, thanks for this, @akatona84 !
Just one minor comment, otherwise it lgtm (pending tests)
Contributor
|
Test this please |
Contributor
|
(That last comment was to trigger the tests) |
chia7712
reviewed
May 16, 2020
…kafka_2.13 Eliminating JavaConverters in EmbeddedKafkaCluster Change-Id: I71d3daee20b4717a3eda602e3e310b431b23c55c
akatona84
force-pushed
the
scala-converter-remove
branch
from
52087d0 to
7d16b46
Compare
Contributor
Author
|
retest this please |
Contributor
|
test this please |
1 similar comment
Contributor
|
test this please |
vvcephei
approved these changes
May 19, 2020
Contributor
vvcephei
left a comment
vvcephei
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the contribution, @akatona84 !
I'll just wait for the tests to pass.
chia7712
approved these changes
May 19, 2020
Contributor
|
The tests that failed are known to be flaky and seem unrelated to this change: |
vvcephei
pushed a commit
that referenced
this pull request
May 19, 2020
Fixes EmbeddedKafkaCluster.deleteTopicAndWait for use with kafka_2.13 Reviewers: Boyang Chen <boyang@confluent.io>, Chia-Ping Tsai <chia7712@gmail.com>, John Roesler <vvcephei@apache.org>
vvcephei
pushed a commit
that referenced
this pull request
May 19, 2020
Fixes EmbeddedKafkaCluster.deleteTopicAndWait for use with kafka_2.13 Reviewers: Boyang Chen <boyang@confluent.io>, Chia-Ping Tsai <chia7712@gmail.com>, John Roesler <vvcephei@apache.org>
Kvicii
pushed a commit
to Kvicii/kafka
that referenced
this pull request
May 21, 2020
* 'trunk' of github.com:apache/kafka: MINOR: Increase gradle daemon’s heap size to 2g (apache#8700) KAFKA-9603: Do not turn on bulk loading for segmented stores on stand-by tasks (apache#8661) KAFKA-9859 / kafka-streams-application-reset tool doesn't take into account topics generated by KTable foreign key join operation (apache#8671) MINOR: Fix redundant typos in comments and javadocs (apache#8693) KAFKA-10010: Should make state store registration idempotent (apache#8681) KAFKA-10011: Remove task id from lockedTaskDirectories during handleLostAll (apache#8682) KAFKA-9992: Eliminate JavaConverters in EmbeddedKafkaCluster (apache#8673) KAFKA-6145: Add unit tests to verify fix of bug KAFKA-9173 (apache#8689) MINOR: Update stream documentation (apache#8622) MINOR: Small fixes in the documentation (apache#8623)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminating JavaConverters in EmbeddedKafkaCluster
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)