MINOR: Fix redundant typos in comments and javadocs#8693
Merged
kkonstantine merged 2 commits intoapache:trunkfrom May 20, 2020
Merged
MINOR: Fix redundant typos in comments and javadocs#8693kkonstantine merged 2 commits intoapache:trunkfrom
kkonstantine merged 2 commits intoapache:trunkfrom
Conversation
Contributor
rondagostino
left a comment
rondagostino
left a comment
There was a problem hiding this comment.
Thanks for the PR. This is a common mistake, and a quick search revealed multiple occurrences. Can you fix all of them?
$ git grep "the the" .
clients/src/main/java/org/apache/kafka/clients/admin/OffsetSpec.java: * Used to retrieve the the earliest offset whose timestamp is greater than
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: * running the the partitioner's onNewBatch method before trying to append again
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java: "size must also be increased so that the they can fetch record batches this large. " +
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorIncrementalTest.java: // Using onJoinComplete to register the protocol selection decided by the the broker
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorIncrementalTest.java: // Using onJoinComplete to register the protocol selection decided by the the broker
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorIncrementalTest.java: // A rebalance after the delay expires re-assigns the lost tasks the the returning member
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java: // and hence we are uncertain the the current local state only contains committed data;
Contributor
Author
|
Sure. I'll update soon |
Contributor
Author
|
Fixed similar typos in those files. Thanks. |
Contributor
rondagostino
left a comment
rondagostino
left a comment
There was a problem hiding this comment.
LGTM, thanks again for the PR.
kkonstantine
approved these changes
May 20, 2020
Contributor
kkonstantine
left a comment
kkonstantine
left a comment
There was a problem hiding this comment.
LGTM
Typos present only in javadoc, so merging as is.
Thanks @ocadaruma and @rondagostino
kkonstantine
changed the title
Kvicii
pushed a commit
to Kvicii/kafka
that referenced
this pull request
May 21, 2020
* 'trunk' of github.com:apache/kafka: MINOR: Increase gradle daemon’s heap size to 2g (apache#8700) KAFKA-9603: Do not turn on bulk loading for segmented stores on stand-by tasks (apache#8661) KAFKA-9859 / kafka-streams-application-reset tool doesn't take into account topics generated by KTable foreign key join operation (apache#8671) MINOR: Fix redundant typos in comments and javadocs (apache#8693) KAFKA-10010: Should make state store registration idempotent (apache#8681) KAFKA-10011: Remove task id from lockedTaskDirectories during handleLostAll (apache#8682) KAFKA-9992: Eliminate JavaConverters in EmbeddedKafkaCluster (apache#8673) KAFKA-6145: Add unit tests to verify fix of bug KAFKA-9173 (apache#8689) MINOR: Update stream documentation (apache#8622) MINOR: Small fixes in the documentation (apache#8623)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committer Checklist (excluded from commit message)