bbox detections visual check

[leshy]

just renders detections test in fg

foxglove-bridge
foxglove-studio
pytest dimos/perception/detection/detectors/test_bbox_detectors.py

[greptile-apps]

Greptile Summary

Added visual debugging capability for bbox detectors by publishing test images and detection annotations to LCM topics for visualization in Foxglove Studio. The Resource base class now includes a dispose() method that enables integration with RxPY's CompositeDisposable for cleaner resource management.

• Added dispose() method to Resource class that wraps stop() for compatibility with reactivex disposable pattern
• Modified test fixtures to publish images and annotations to LCM topics (/color_image, /annotations_{detector_name})
• Introduced CompositeDisposable for managing multiple LCM transport lifecycles in tests
• Debug print statement on line 51 should be removed

Confidence Score: 4/5

• This PR is safe to merge with minor style improvements recommended
• The changes are well-contained and add useful debugging capabilities. The dispose() method is a simple wrapper that maintains backward compatibility. Minor style issues (debug print, inconsistent cleanup pattern) don't affect functionality.
• No files require special attention - both changes are straightforward and low-risk

Important Files Changed

Filename	Overview
dimos/core/resource.py	Added dispose() method to enable Resource objects to work with CompositeDisposable from reactivex
dimos/perception/detection/detectors/test_bbox_detectors.py	Enhanced test to publish detections and images to LCM for visual verification in Foxglove; includes debug print statement and minor cleanup opportunity

Sequence Diagram

sequenceDiagram
    participant Test as pytest test
    participant Detector as bbox/person/yoloe detector
    participant Fixtures as Test Fixtures
    participant LCM as LCM Topics
    participant Foxglove as Foxglove Studio
    
    Test->>Fixtures: Request test_image fixture
    Fixtures->>Test: Return Image
    
    Test->>Fixtures: Request topic_image fixture
    Fixtures->>LCM: Create LCMTransport("/color_image")
    
    Test->>Fixtures: Request get_topic_annotations fixture
    Note over Fixtures: Creates CompositeDisposable for cleanup
    
    Test->>Fixtures: Request detections fixture
    Fixtures->>LCM: Publish test_image to /color_image
    Fixtures->>Detector: process_image(test_image)
    Detector->>Fixtures: Return ImageDetections2D
    Fixtures->>Fixtures: Convert to_foxglove_annotations()
    Fixtures->>Fixtures: Create topic_annotations(detector_name)
    Fixtures->>LCM: Publish annotations to /annotations_{detector}
    Fixtures->>Test: Return detections
    
    LCM->>Foxglove: Stream image and annotations
    
    Test->>Test: Run test assertions
    
    Note over Fixtures: On teardown
    Fixtures->>Fixtures: CompositeDisposable.dispose()
    Fixtures->>LCM: Stop all annotation transports
    Fixtures->>LCM: Stop topic_image transport

Loading

[greptile-apps]

_{2 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}