Skip to content

commented out Mem Transport test case#1077

Merged
leshy merged 1 commit intodevfrom
removed_mem_test
Jan 21, 2026
Merged

commented out Mem Transport test case#1077
leshy merged 1 commit intodevfrom
removed_mem_test

Conversation

@leshy
Copy link
Contributor

@leshy leshy commented Jan 21, 2026

since it's so fast it ruins the graph

@leshy leshy requested a review from a team January 21, 2026 05:27
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 21, 2026

Greptile Summary

Commented out the Memory transport benchmark test case to prevent it from skewing graph visualizations due to its extremely fast performance compared to other transport implementations.

  • Memory transport uses direct in-process function calls with no serialization overhead, making it orders of magnitude faster than network-based transports (LCM, UDP, Redis, ROS) and shared memory transports
  • The extreme performance difference makes it difficult to visualize and compare the performance characteristics of real-world transports on benchmark graphs
  • The Memory transport implementation and message generator remain in the codebase for potential future use

Confidence Score: 5/5

  • Safe to merge - simple comment-out change that improves benchmark visualization without affecting functionality
  • The change only comments out a single test case registration without modifying any logic or removing the underlying implementation. The Memory transport code remains available for future use, and all other transport benchmarks continue to function normally. This is a non-breaking change that addresses a legitimate UX issue with benchmark graph readability.
  • No files require special attention

Important Files Changed

Filename Overview
dimos/protocol/pubsub/benchmark/testdata.py Commented out Memory transport test case to avoid skewing benchmark results due to its extremely fast performance

Sequence Diagram

sequenceDiagram
    participant Test as test_benchmark.py
    participant TestData as testdata.py
    participant Memory as Memory Transport
    participant Other as Other Transports
    
    Note over TestData: Before Change
    TestData->>TestData: testcases.append(Memory)
    Test->>TestData: Import testcases
    TestData-->>Test: [LCM, UDP, Memory, SHM...]
    Test->>Memory: Run benchmark
    Memory-->>Test: Extremely fast results
    Note over Test: Memory skews graph scale
    
    Note over TestData: After Change
    TestData->>TestData: # testcases.append(Memory)
    Test->>TestData: Import testcases
    TestData-->>Test: [LCM, UDP, SHM, Redis, ROS...]
    Test->>Other: Run benchmarks
    Other-->>Test: Comparable results
    Note over Test: Better graph visualization
Loading

@leshy leshy merged commit b5a54d4 into dev Jan 21, 2026
15 checks passed
spomichter added a commit that referenced this pull request Jan 23, 2026
… Unitree Go2 Navigation & Exploration Beta

Pre-Release v0.0.8: Unitree Go2 Navigation & Exploration Beta, Transport Updates, Documentation updates, Rerun fixes, Person follow, Readme updates

## What's Changed
* Small docs clarification about stream getters by @leshy in #1043
* Fix split view on wide monitors by @jeff-hykin in #1048
* Docs: Install & Develop  by @jeff-hykin in #1022
* Add uv to nix and fix resulting problems by @jeff-hykin in #1021
* v0.0.8 by @paul-nechifor in #1050
* Style changes in docs by @paul-nechifor in #1051
* Revert "Add uv to nix and fix resulting problems" by @leshy in #1053
* Transport benchmarks + Raw ros transport by @leshy in #1038
* feat: default to rerun-web and auto-open browser on startup (browser … by @Nabla7 in #1019
* bbox detections visual check by @leshy in #1017
* fix: only auto-open browser for rerun-web viewer backend by @Nabla7 in #1066
* move slow tests to integration by @paul-nechifor in #1063
* Streamline transport start/stop methods by @Kaweees in #1062
* Person follow skill with EdgeTAM by @paul-nechifor in #1042
* fix: increase costmap floor z_offset to avoid z-fighting by @Nabla7 in #1073
* Fixed issue #1074 by @alexlin2 in #1075
* ROS transports initial by @leshy in #1057
* Fix System Config Values for LCM on MacOS and Refactor by @jeff-hykin in #1065
* SHM Transport basic fixes by @leshy in #1041
* commented out Mem Transport test case by @leshy in #1077
* Docs/advanced streams update 2 by @leshy in #1078
* Fix more tests by @paul-nechifor in #1071
* feat: navigation docker updates from bona_local_dev by @baishibona in #1081
* Fix missing dependencies by @Kaweees in #1085
* Release readme fixes by @spomichter in #1076

## New Contributors
* @baishibona made their first contribution in #1081

**Full Changelog**: v0.0.7...v0.0.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants