Skip to content

fix: only auto-open browser for rerun-web viewer backend#1066

Merged
leshy merged 1 commit intodevfrom
fix/browser-auto-open-rerun-web-only
Jan 20, 2026
Merged

fix: only auto-open browser for rerun-web viewer backend#1066
leshy merged 1 commit intodevfrom
fix/browser-auto-open-rerun-web-only

Conversation

@Nabla7
Copy link
Contributor

@Nabla7 Nabla7 commented Jan 20, 2026

as the title suggests.

@Nabla7 Nabla7 requested a review from a team January 20, 2026 05:54
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 20, 2026

Greptile Overview

Greptile Summary

Restricts automatic browser opening to only the rerun-web viewer backend. Previously, the browser would auto-open for all viewer backends (rerun-web, rerun-native, foxglove), which was inappropriate since rerun-native opens a separate native window and foxglove uses Foxglove Studio.

Key changes:

  • Added conditional check: if self._global_config.viewer_backend == "rerun-web"
  • Moved URL construction and logging inside the conditional block
  • Updated comment to clarify the behavior for each viewer backend

This aligns with the documented viewer backend behavior where only rerun-web provides a full browser-based dashboard at the localhost URL.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change is a simple, well-scoped conditional that adds proper backend-specific behavior without modifying any existing logic for the rerun-web case. The fix addresses a user experience issue where browsers would inappropriately open for non-web viewer backends.
  • No files require special attention

Sequence Diagram

sequenceDiagram
    participant User
    participant WebsocketVisModule
    participant GlobalConfig
    participant Browser
    participant UvicornServer

    User->>WebsocketVisModule: start()
    WebsocketVisModule->>WebsocketVisModule: _create_server()
    WebsocketVisModule->>WebsocketVisModule: _start_broadcast_loop()
    WebsocketVisModule->>UvicornServer: Start uvicorn server thread
    
    WebsocketVisModule->>GlobalConfig: Check viewer_backend
    
    alt viewer_backend == "rerun-web"
        GlobalConfig-->>WebsocketVisModule: "rerun-web"
        WebsocketVisModule->>WebsocketVisModule: Construct URL
        WebsocketVisModule->>WebsocketVisModule: Log Command Center URL
        WebsocketVisModule->>Browser: webbrowser.open_new_tab(url)
        Browser-->>User: Opens dashboard in browser
    else viewer_backend == "rerun-native" or "foxglove"
        GlobalConfig-->>WebsocketVisModule: "rerun-native" or "foxglove"
        Note over WebsocketVisModule,Browser: Browser NOT opened<br/>User accesses manually if needed
    end
    
    WebsocketVisModule->>WebsocketVisModule: Subscribe to data streams
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@leshy leshy merged commit 5b3df27 into dev Jan 20, 2026
13 checks passed
spomichter added a commit that referenced this pull request Jan 23, 2026
… Unitree Go2 Navigation & Exploration Beta

Pre-Release v0.0.8: Unitree Go2 Navigation & Exploration Beta, Transport Updates, Documentation updates, Rerun fixes, Person follow, Readme updates

## What's Changed
* Small docs clarification about stream getters by @leshy in #1043
* Fix split view on wide monitors by @jeff-hykin in #1048
* Docs: Install & Develop  by @jeff-hykin in #1022
* Add uv to nix and fix resulting problems by @jeff-hykin in #1021
* v0.0.8 by @paul-nechifor in #1050
* Style changes in docs by @paul-nechifor in #1051
* Revert "Add uv to nix and fix resulting problems" by @leshy in #1053
* Transport benchmarks + Raw ros transport by @leshy in #1038
* feat: default to rerun-web and auto-open browser on startup (browser … by @Nabla7 in #1019
* bbox detections visual check by @leshy in #1017
* fix: only auto-open browser for rerun-web viewer backend by @Nabla7 in #1066
* move slow tests to integration by @paul-nechifor in #1063
* Streamline transport start/stop methods by @Kaweees in #1062
* Person follow skill with EdgeTAM by @paul-nechifor in #1042
* fix: increase costmap floor z_offset to avoid z-fighting by @Nabla7 in #1073
* Fixed issue #1074 by @alexlin2 in #1075
* ROS transports initial by @leshy in #1057
* Fix System Config Values for LCM on MacOS and Refactor by @jeff-hykin in #1065
* SHM Transport basic fixes by @leshy in #1041
* commented out Mem Transport test case by @leshy in #1077
* Docs/advanced streams update 2 by @leshy in #1078
* Fix more tests by @paul-nechifor in #1071
* feat: navigation docker updates from bona_local_dev by @baishibona in #1081
* Fix missing dependencies by @Kaweees in #1085
* Release readme fixes by @spomichter in #1076

## New Contributors
* @baishibona made their first contribution in #1081

**Full Changelog**: v0.0.7...v0.0.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants