Publish updates from master #15283
Publish updates from master #15283
Conversation
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Currently it's easy for users to skip the per-distro installation steps, since direct download links for our packages are presented first. This can lead to unnecessary frustration, since DD will not install if pre-requisite steps are not followed. So instead of presenting package download links in the most prominent spot, point users to per-distro installation instructions. Signed-off-by: Piotr Stankiewicz <piotr.stankiewicz@docker.com>
…tions DD4L: Replace download links with per-distro install instruction links
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
build: add drivers guides
* Document permission requirements for Docker Desktop for Windows * Apply suggestions from code review Co-authored-by: Allie Sadler <102604716+aevesdocker@users.noreply.github.com> * Update permission-requirements.md Fix keyword, typo and wording Co-authored-by: Allie Sadler <102604716+aevesdocker@users.noreply.github.com>
jekyll: enable sitemap and local search for dev environment
Add SCIM API docs
* Update vm-vdi.md * Update index.md
* Update windows-install.md * Remove another unsupported hypervisor (#15280)
aevesdocker
requested review from
craig-osterhout,
crazy-max,
dockertopia,
jerae-duffin and
usha-mandya
as code owners
dockertopia
left a comment
dockertopia
left a comment
There was a problem hiding this comment.
For some reason this PR is picking up both approved and PRs requiring review.
We should look into this before publishing. Thanks.
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
dockertopia
left a comment
dockertopia
left a comment
There was a problem hiding this comment.
So these are missing the green check icon (for approval) but looking into the PR they are approved and merged. In light of that removing the request for changes. LGTM
Green check icon does not mean there has been an approval or not but GitHub checks passed for this commit (aka GitHub Actions). As #15250 has been merged as merge commit, GitHub Actions will only run against the last commit ( As long as it has been already merged to master, it means each changes has been approved first through a PR which is protected for
|
|
Thanks for the clarification @crazy-max.
There was the doubt if the check alongside the commit hash was for having passed the checks or approvals because as it is the exact same icon (screen grab above). |
|
@dockertopia Yes agree that the UI is misleading 😞 |
No description provided.