Bring vs17.0 up-to-date with main#6367
Merged
benvillalobos merged 6 commits intodotnet:vs17.0from Apr 22, 2021
Merged
Conversation
* Make GenerateResource look up resgen.exe in 10.0 SDK GenerateResource tests were failing when only VS 2019 and 10.0 Windows SDK is installed. I suspect the task itself would also fail if run with ExecuteAsTool. The problem is that we started look up with .NET 4.6.1 and lower. Start lookup with .NET 4.8 instead and fallback down the chain. This should still find all earlier SDKs too. Introduce latest versions of Visual Studio too. * Rollback some changes to VersionLatest. * Set the SdkToolsPath to framework 4.8 This actually fixes the unit-tests on a machine with only SDK 10.0 installed.
Co-authored-by: Forgind <Forgind@users.noreply.github.com>
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
rainersigwald
approved these changes
Apr 22, 2021
Forgind
added
the
merge-when-branch-open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds newer commits
@rainersigwald