Updating CoreFX dependencies to rc3-23925-01#7
Closed
dotnet-bot wants to merge 26 commits intoeerhardt:DependencyVersionsfrom
Closed
Updating CoreFX dependencies to rc3-23925-01#7dotnet-bot wants to merge 26 commits intoeerhardt:DependencyVersionsfrom
dotnet-bot wants to merge 26 commits intoeerhardt:DependencyVersionsfrom
Conversation
Move text info tests to their new more up to date modern files
HttpClient defaults to UseCookies=true, which means by default every request ends up asking the CookieContainer to get the cookie header that should be used. Today, even if there aren't any cookies for the Uri, this ends up allocating a CookieCollection, a StringBuilder, a couple of List<T>s, an iterator, etc., none of which are actually necessary. And if there are cookies for the Uri, the serialization of each cookie results in a handful of strings, char[]s, and string[] allocations. This commit fixes the implementation to avoid these. (There are still some that could be cleaned up with further work, but it becomes much more invasive.)
I assume this was a copy'n'paste typo.
Fixes to the dev workflow scripts for OSX
CMake 3.5+ MSI-based installations no longer write the installation directory to the registry. To work around this I have added the default installation directory to the probing logic.
Much of the output from 'git fetch' is to stderr, so it should also be redirected to the log file. The original implementation using &>> was added to Bash in version 4, so to ensure that this script works on OS X, an alternative syntax is used.
Fix syntax errors in if clause (.sh version). Run init-tools script if tools haven't been restored.
Update ExceptionUtils.vb
Use nameof in System.Collections.*
Add default CMake installation path to probe script.
Per PR feedback.
Cleanup TextInfo tests
Implement UpdateDependencies script to automatically take new versions of dependencies
Some duplication was present between tests, so I deleted some test files Also contributes to #2103 Also fixes some todos to enabled some tests for Windows 10
Use nameof in Common
Reduce allocations in CookieContainer.GetCookieHeader
…e-info Cleanup CultureInfo tests
Remove unnecessary branches in UrlDecoder
Redirect 'git fetch' output to log
Build tests as a separate task of build.cmd with a build-tests.cmd script. When we run build.cmd passing /p:BuildTests=false the tests are not build. Note: the property Skiptests=true only disables the execution of the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.