feat: as default not to log the session val#17
Merged
mansonchor merged 25 commits intoeggjs:masterfrom Mar 23, 2021
clChenLiang:master
Merged
feat: as default not to log the session val#17mansonchor merged 25 commits intoeggjs:masterfrom clChenLiang:master
mansonchor merged 25 commits intoeggjs:masterfrom
clChenLiang:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
===========================================
- Coverage 96.42% 39.28% -57.15%
===========================================
Files 4 4
Lines 28 28
===========================================
- Hits 27 11 -16
- Misses 1 17 +16
Continue to review full report at Codecov.
|
mansonchor
reviewed
Mar 4, 2021
app.js
Outdated
| }); | ||
| app.on('session:expired', ({ ctx, key, value }) => { | ||
| ctx.coreLogger.warn('[session][expired] key(%s) value(%j)', key, value); | ||
| ctx.coreLogger.warn('[session][expired] key(%s) value(%j)', key, app.config.logValue ? value : ''); |
Member
There was a problem hiding this comment.
这里应该是 config.session.logValue 吧
config/config.default.js
Outdated
| httpOnly: true, | ||
| encrypt: true, | ||
| // sameSite: null, | ||
| logValue: false, |
Member
|
要补单测的 |
|
ping |
Member
|
LGTM |
popomore
reviewed
Mar 23, 2021
| app.expectLog('[session][expired] key(undefined) value("")', 'coreLogger'); | ||
| }); | ||
|
|
||
| it.only('when logValue is false, valid false, should not log the session value', async () => { |
Member
|
@mansonchor 这个覆盖率低了 |
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change