phone-number: add missing edge cases#1090
Merged
ErikSchierboom merged 4 commits intomasterfrom Jan 12, 2018
Merged
Conversation
The existing descriptions for invalid area codes and exchange codes both cite a range, but only test a single value. This PR tests for all values outside the valid range.
rpottsoh
approved these changes
Jan 9, 2018
ErikSchierboom
approved these changes
Jan 10, 2018
Member
|
Thanks for bumping that. It is so easy to miss. |
leenipper
suggested changes
Jan 11, 2018
leenipper
left a comment
leenipper
left a comment
There was a problem hiding this comment.
Good improvements for test cases.
However, request no deeper nesting of test cases unnecessarily.
| "expected": null | ||
| } | ||
| ] | ||
| }, |
There was a problem hiding this comment.
Agree with the new edge test cases. But, would prefer it without another level of "cases": [ ]. I suggest the two invalid cases be at same level as the other clean test cases. Otherwise, the change will break some generators unnecessarily.
Contributor
Author
There was a problem hiding this comment.
Fair enough; done.
| "phrase": "(223) 156-7890", | ||
| "expected": null | ||
| } | ||
| ] |
There was a problem hiding this comment.
Ditto here. Prefer two new invalid cases, but without another nested level of cases.
leenipper
approved these changes
Jan 11, 2018
Member
|
Merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing descriptions for invalid area codes and exchange codes both cite a range, but only test a single value. This PR tests for all values outside the valid range.