phone-number: Remove test using malformed input.#772
Merged
Insti merged 2 commits intoexercism:masterfrom May 6, 2017
Merged
Conversation
This is not a string parsing exercise and there is no reason why a number should be invalid due to inconsequential non-digit characters. "2a2b3c4d5e6f7g8h9i0j" should be as valid as: "My phone number is: 223 456 7890"
behrtam
approved these changes
May 5, 2017
stkent
approved these changes
May 6, 2017
Contributor
Author
|
Thanks for the reviews. 👍 |
emcoding
pushed a commit
that referenced
this pull request
Nov 19, 2018
meta: Remove issue template.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Letters are not punctuation and this is not primarily a string parsing exercise.
So remove the test using
1a2b3c4d5e6f7g8h9i0jas input.