phone-number: add cases to test data that cover invalid use of "1" or "0"#1327
Merged
rpottsoh merged 3 commits intoexercism:masterfrom Sep 19, 2018
Merged
phone-number: add cases to test data that cover invalid use of "1" or "0"#1327rpottsoh merged 3 commits intoexercism:masterfrom
rpottsoh merged 3 commits intoexercism:masterfrom
Conversation
…11-digit numbers with invalid area/exchange codes
rpottsoh
changed the title
rpottsoh
changed the title
Contributor
Author
|
@rpottsoh Version has been updated |
rpottsoh
requested changes
Sep 17, 2018
| { | ||
| "exercise": "phone-number", | ||
| "version": "1.4.0", | ||
| "version": "1.4.1", |
Member
There was a problem hiding this comment.
This isn't quite right. The changes you are proposing are more substantial. "1.5.0" should be the new version. Test Data Versioning tries to explain it.
rpottsoh
approved these changes
Sep 18, 2018
ErikSchierboom
approved these changes
Sep 19, 2018
Member
|
I am going to go ahead and merge this seeings how there are two approvals and given that the PR has been open for 7 days. |
petertseng
pushed a commit
to exercism/haskell
that referenced
this pull request
Sep 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…11-digit numbers with invalid area/exchange codes
closes #1320