Skip to content

phone-number: Updated the exercise to the 1.6.1 version#759

Merged
coriolinus merged 2 commits intoexercism:masterfrom
ZapAnton:update_phone_number
Nov 24, 2018
Merged

phone-number: Updated the exercise to the 1.6.1 version#759
coriolinus merged 2 commits intoexercism:masterfrom
ZapAnton:update_phone_number

Conversation

@petertseng petertseng added the sync/tests Keep a test suite/version in sync with exercism/problem-specifications label Nov 20, 2018
Copy link
Copy Markdown
Member

@coriolinus coriolinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'll plan to merge this on Friday unless there are objections.

Copy link
Copy Markdown
Member

@petertseng petertseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I identified two duplicates that you could consider deleting. In fact I even recommend it since some of them have slightly confusing names.

Comment thread exercises/phone-number/tests/phone-number.rs Outdated
Comment thread exercises/phone-number/tests/phone-number.rs Outdated
@coriolinus coriolinus merged commit 6fb06d6 into exercism:master Nov 24, 2018
@ZapAnton ZapAnton deleted the update_phone_number branch November 25, 2018 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sync/tests Keep a test suite/version in sync with exercism/problem-specifications

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants