Started using FlutterEngineGroups by default on Android #37822

gaaclarke · 2022-11-21T23:23:54Z

Also started made the group accessible to plugins. There are a few important plugins that spawn new engines that run in the background, this will allow them to share the isolate group across the whole app. I avoided deprecating FlutterEngine constructors until we get wider acceptance from the team.

issue: flutter/flutter#115507

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

gaaclarke · 2022-11-22T19:24:27Z

cc @xster since this may have ramifications for google usage of flutter
cc @stuartmorgan since this changes the plugin interface
cc @reidbaker since it is a big shift for Android
cc @dnfield since he was involved in the discussion to make this happen

gaaclarke · 2022-11-22T19:26:09Z

Switching the reviewer to reid since jason isn't available. Feel free to delegate to someone else.

chinmaygarde · 2022-12-01T21:15:39Z

From Triage: @jason-simmons is unable to review this. Redirecting to @reidbaker .

xster · 2022-12-04T00:30:51Z

+1. I think we should do this by default. @jiahaog, this affects a bit the custom engine holders we have. I think nothing materially right out the gate, but we should also hold the engine group as well as the engine so users can easily spawn new engines from the same group.

stuartmorgan-g

The new plugin API LGTM.

shell/platform/android/io/flutter/embedding/engine/plugins/FlutterPlugin.java

them accessible to plugins.

…ter/engine#37822)

…ter#37822)" This reverts commit 47a358c. This commit caused a regression in the entrypoint_dart_registrant test.

…)" (#38351) This reverts commit 47a358c. This commit caused a regression in the entrypoint_dart_registrant test.

…ter/engine#37822)

* e28b26e [linux] Allow overriding asset, ICU data path (flutter/engine#38296) * 35bdb8b Roll Skia from 9f728d78f10d to f549128104ba (1 revision) (flutter/engine#38319) * 97e246c Roll Dart SDK from 358d0d1aa3e7 to 1dd5b1bf1099 (7 revisions) (flutter/engine#38320) * d9580a5 Migrate iOS text input plugin to use ARC (flutter/engine#38179) * c9e9fa5 Update web_sdk -> package test dependency to get updated package matcher (flutter/engine#38323) * a7ec07f [fuchsia] Manually roll Fuchsia Linux SDK. (flutter/engine#38324) * 61e95ba Remove doc reference to the compute method (flutter/engine#38246) * 353d694 make sure CanvasRecorder updates clip bounds methods (flutter/engine#38325) * 47a358c Started using FlutterEngineGroups by default on Android (flutter/engine#37822) * 7d8e106 Bump github/codeql-action from 2.1.35 to 2.1.36 (flutter/engine#38210) * 8915b81 Update buildroot to b2ab6e1. (flutter/engine#38329) * 4fe6206 Revert "Roll Dart SDK from 358d0d1aa3e7 to 1dd5b1bf1099 (7 revisions) (#38320)" (flutter/engine#38331) * 2ff490c Roll Skia from f549128104ba to 5e69caecd166 (11 revisions) (flutter/engine#38333) * 2225185 Add missing include to FlutterThreadSynchronizer (flutter/engine#38337) * 467cfd7 Roll Fuchsia Mac SDK from VEOIaacOA75U7PYyz... to KtItDj-MERuua77aS... (flutter/engine#38339) * 010f4ee Roll Fuchsia Linux SDK from zwfwHRSLdmV61hYqe... to urDNtEiHFAcBBhYe0... (flutter/engine#38340) * 773b435 Sped up reading with FlutterStandardCodec. (flutter/engine#38327) * 70439f6 Roll Skia from 5e69caecd166 to 62f22c9c7d67 (3 revisions) (flutter/engine#38341) * bc1647f Roll the test package used by Web in preparation for a Dart 3 SDK roll (flutter/engine#38342) * cac228a Roll Dart SDK from 358d0d1aa3e7 to 7b4d4ec3cad1 (14 revisions) (flutter/engine#38344) * 13ae6eb Revert "Started using FlutterEngineGroups by default on Android (#37822)" (flutter/engine#38351) * ed80638 Add an explicit constraint on the matcher package version to ensure Dart 3 compatibility (flutter/engine#38352) * dcafebf Roll Skia from 62f22c9c7d67 to 1b1f53d77ced (1 revision) (flutter/engine#38343) * 6f61585 Roll Fuchsia Mac SDK from KtItDj-MERuua77aS... to bn5VF1-xDf-wKjIw8... (flutter/engine#38348) * 0c00bc0 Remove 30fps cap from playgrounds (flutter/engine#38347) * 38340bb [Impeller] Fix SceneC crash for nodes with children (flutter/engine#38346) * 3a6b3f9 Roll Fuchsia Linux SDK from urDNtEiHFAcBBhYe0... to H6B0UgW07fc1nBtnc... (flutter/engine#38357) * 81b4535 Roll Skia from 1b1f53d77ced to 7b0a9d9a3008 (8 revisions) (flutter/engine#38358) * d91e208 Port touch-based tests from embedder integration test (flutter/engine#38234)

…id (flutter#37822)" (flutter#38351)" This reverts commit 13ae6eb.

* Revert "Revert "Started using FlutterEngineGroups by default on Android (#37822)" (#38351)" This reverts commit 13ae6eb. * fixed the entrypoint test * updated old test * coldpalelight's suggestion * added entrypoint args

* Started using FlutterEngineGroups by default on Android and making them accessible to plugins. * added docstring * format

…ter#37822)" (flutter#38351) This reverts commit 47a358c. This commit caused a regression in the entrypoint_dart_registrant test.

…ter#38367) * Revert "Revert "Started using FlutterEngineGroups by default on Android (flutter#37822)" (flutter#38351)" This reverts commit 13ae6eb. * fixed the entrypoint test * updated old test * coldpalelight's suggestion * added entrypoint args

…17242) * e28b26e [linux] Allow overriding asset, ICU data path (flutter/engine#38296) * 35bdb8b Roll Skia from 9f728d78f10d to f549128104ba (1 revision) (flutter/engine#38319) * 97e246c Roll Dart SDK from 358d0d1aa3e7 to 1dd5b1bf1099 (7 revisions) (flutter/engine#38320) * d9580a5 Migrate iOS text input plugin to use ARC (flutter/engine#38179) * c9e9fa5 Update web_sdk -> package test dependency to get updated package matcher (flutter/engine#38323) * a7ec07f [fuchsia] Manually roll Fuchsia Linux SDK. (flutter/engine#38324) * 61e95ba Remove doc reference to the compute method (flutter/engine#38246) * 353d694 make sure CanvasRecorder updates clip bounds methods (flutter/engine#38325) * 47a358c Started using FlutterEngineGroups by default on Android (flutter/engine#37822) * 7d8e106 Bump github/codeql-action from 2.1.35 to 2.1.36 (flutter/engine#38210) * 8915b81 Update buildroot to b2ab6e1. (flutter/engine#38329) * 4fe6206 Revert "Roll Dart SDK from 358d0d1aa3e7 to 1dd5b1bf1099 (7 revisions) (flutter#38320)" (flutter/engine#38331) * 2ff490c Roll Skia from f549128104ba to 5e69caecd166 (11 revisions) (flutter/engine#38333) * 2225185 Add missing include to FlutterThreadSynchronizer (flutter/engine#38337) * 467cfd7 Roll Fuchsia Mac SDK from VEOIaacOA75U7PYyz... to KtItDj-MERuua77aS... (flutter/engine#38339) * 010f4ee Roll Fuchsia Linux SDK from zwfwHRSLdmV61hYqe... to urDNtEiHFAcBBhYe0... (flutter/engine#38340) * 773b435 Sped up reading with FlutterStandardCodec. (flutter/engine#38327) * 70439f6 Roll Skia from 5e69caecd166 to 62f22c9c7d67 (3 revisions) (flutter/engine#38341) * bc1647f Roll the test package used by Web in preparation for a Dart 3 SDK roll (flutter/engine#38342) * cac228a Roll Dart SDK from 358d0d1aa3e7 to 7b4d4ec3cad1 (14 revisions) (flutter/engine#38344) * 13ae6eb Revert "Started using FlutterEngineGroups by default on Android (flutter#37822)" (flutter/engine#38351) * ed80638 Add an explicit constraint on the matcher package version to ensure Dart 3 compatibility (flutter/engine#38352) * dcafebf Roll Skia from 62f22c9c7d67 to 1b1f53d77ced (1 revision) (flutter/engine#38343) * 6f61585 Roll Fuchsia Mac SDK from KtItDj-MERuua77aS... to bn5VF1-xDf-wKjIw8... (flutter/engine#38348) * 0c00bc0 Remove 30fps cap from playgrounds (flutter/engine#38347) * 38340bb [Impeller] Fix SceneC crash for nodes with children (flutter/engine#38346) * 3a6b3f9 Roll Fuchsia Linux SDK from urDNtEiHFAcBBhYe0... to H6B0UgW07fc1nBtnc... (flutter/engine#38357) * 81b4535 Roll Skia from 1b1f53d77ced to 7b0a9d9a3008 (8 revisions) (flutter/engine#38358) * d91e208 Port touch-based tests from embedder integration test (flutter/engine#38234)

flutter-dashboard bot added the platform-android label Nov 21, 2022

gaaclarke force-pushed the android-flutter-engine-group-always branch 5 times, most recently from 5eb2b04 to 30aa146 Compare November 22, 2022 19:21

gaaclarke requested a review from jason-simmons November 22, 2022 19:22

gaaclarke requested review from reidbaker and removed request for jason-simmons November 22, 2022 19:25

gaaclarke marked this pull request as ready for review November 22, 2022 22:19

reidbaker requested a review from GaryQian December 7, 2022 01:42

stuartmorgan-g reviewed Dec 8, 2022

View reviewed changes

shell/platform/android/io/flutter/embedding/engine/plugins/FlutterPlugin.java Show resolved Hide resolved

Started using FlutterEngineGroups by default on Android and making

36a8dc3

them accessible to plugins.

gaaclarke force-pushed the android-flutter-engine-group-always branch from 30aa146 to 36a8dc3 Compare December 8, 2022 22:53

gaaclarke added 2 commits December 8, 2022 15:04

added docstring

7be0204

format

4c85cab

reidbaker removed their request for review December 13, 2022 15:53

chinmaygarde approved these changes Dec 15, 2022

View reviewed changes

gaaclarke merged commit 47a358c into flutter:main Dec 15, 2022

engine-flutter-autoroll mentioned this pull request Dec 15, 2022

Roll Flutter Engine from 29196519c124 to 7d8e10652a3f (10 revisions) flutter/flutter#117178

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2022

47a358c Started using FlutterEngineGroups by default on Android (flut…

f675813

…ter/engine#37822)

engine-flutter-autoroll mentioned this pull request Dec 15, 2022

Roll Flutter Engine from 29196519c124 to 8915b81d426f (11 revisions) flutter/flutter#117181

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2022

47a358c Started using FlutterEngineGroups by default on Android (flut…

87dbe59

…ter/engine#37822)

engine-flutter-autoroll mentioned this pull request Dec 15, 2022

Roll Flutter Engine from 29196519c124 to 4fe620643a29 (12 revisions) flutter/flutter#117186

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2022

47a358c Started using FlutterEngineGroups by default on Android (flut…

5144301

…ter/engine#37822)

engine-flutter-autoroll mentioned this pull request Dec 16, 2022

Roll Flutter Engine from 29196519c124 to 2ff490c1e72c (13 revisions) flutter/flutter#117187

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022

47a358c Started using FlutterEngineGroups by default on Android (flut…

f34cbd5

…ter/engine#37822)

jason-simmons added a commit that referenced this pull request Dec 16, 2022

Revert "Started using FlutterEngineGroups by default on Android (#37822…

13ae6eb

…)" (#38351) This reverts commit 47a358c. This commit caused a regression in the entrypoint_dart_registrant test.

engine-flutter-autoroll mentioned this pull request Dec 16, 2022

Roll Flutter Engine from 29196519c124 to ed806386167c (22 revisions) flutter/flutter#117218

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022

47a358c Started using FlutterEngineGroups by default on Android (flut…

ce3cb94

…ter/engine#37822)

engine-flutter-autoroll mentioned this pull request Dec 16, 2022

Roll Flutter Engine from 29196519c124 to dcafebf4445c (23 revisions) flutter/flutter#117219

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022

47a358c Started using FlutterEngineGroups by default on Android (flut…

4c423b5

…ter/engine#37822)

engine-flutter-autoroll mentioned this pull request Dec 16, 2022

Roll Flutter Engine from 29196519c124 to 6f6158580a1f (24 revisions) flutter/flutter#117223

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022

47a358c Started using FlutterEngineGroups by default on Android (flut…

6ac5b66

…ter/engine#37822)

engine-flutter-autoroll mentioned this pull request Dec 16, 2022

Roll Flutter Engine from 29196519c124 to 38340bb5734a (26 revisions) flutter/flutter#117225

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022

47a358c Started using FlutterEngineGroups by default on Android (flut…

c641bae

…ter/engine#37822)

engine-flutter-autoroll mentioned this pull request Dec 16, 2022

Roll Flutter Engine from 29196519c124 to 3a6b3f9869c4 (27 revisions) flutter/flutter#117230

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022

47a358c Started using FlutterEngineGroups by default on Android (flut…

3da09ae

…ter/engine#37822)

engine-flutter-autoroll mentioned this pull request Dec 16, 2022

Roll Flutter Engine from 29196519c124 to 81b453535eb8 (28 revisions) flutter/flutter#117232

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022

47a358c Started using FlutterEngineGroups by default on Android (flut…

f542944

…ter/engine#37822)

engine-flutter-autoroll mentioned this pull request Dec 16, 2022

Roll Flutter Engine from 29196519c124 to d91e20879a67 (29 revisions) flutter/flutter#117236

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022

47a358c Started using FlutterEngineGroups by default on Android (flut…

3db17e7

…ter/engine#37822)

engine-flutter-autoroll mentioned this pull request Dec 16, 2022

Roll Flutter Engine from 29196519c124 to d91e20879a67 (29 revisions) flutter/flutter#117242

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022

47a358c Started using FlutterEngineGroups by default on Android (flut…

df23dd7

…ter/engine#37822)

gaaclarke added a commit to gaaclarke/engine that referenced this pull request Dec 17, 2022

Revert "Revert "Started using FlutterEngineGroups by default on Andro…

a65561d

…id (flutter#37822)" (flutter#38351)" This reverts commit 13ae6eb.

gaaclarke mentioned this pull request Dec 17, 2022

reland: Started using FlutterEngineGroups by default on Android #38367

Merged

8 tasks

dballance mentioned this pull request Apr 7, 2023

[Flutter 3.7.0] Sending Class Objects between FlutterEngines created from FlutterEngineGroup produces errors after hot restart. flutter/flutter#119589

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Started using FlutterEngineGroups by default on Android #37822

Started using FlutterEngineGroups by default on Android #37822

Uh oh!

gaaclarke commented Nov 21, 2022 •

edited

Loading

Uh oh!

gaaclarke commented Nov 22, 2022

Uh oh!

gaaclarke commented Nov 22, 2022

Uh oh!

chinmaygarde commented Dec 1, 2022

Uh oh!

xster commented Dec 4, 2022

Uh oh!

stuartmorgan-g left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Started using FlutterEngineGroups by default on Android #37822

Started using FlutterEngineGroups by default on Android #37822

Uh oh!

Conversation

gaaclarke commented Nov 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

gaaclarke commented Nov 22, 2022

Uh oh!

gaaclarke commented Nov 22, 2022

Uh oh!

chinmaygarde commented Dec 1, 2022

Uh oh!

xster commented Dec 4, 2022

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gaaclarke commented Nov 21, 2022 •

edited

Loading