Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add missing include to FlutterThreadSynchronizer #38337

Merged
cbracken merged 2 commits into from
Dec 15, 2022
Merged

Add missing include to FlutterThreadSynchronizer #38337

cbracken merged 2 commits into from
Dec 15, 2022

Conversation

@knopp
Copy link
Member

@knopp knopp commented Dec 15, 2022

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Dec 15, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

cbracken
cbracken approved these changes Dec 15, 2022
View reviewed changes
@Hixie
Copy link
Contributor

Hixie commented Dec 15, 2022

test-exempt: without this the code doesn't compile (in some environments)

@knopp
Copy link
Member Author

knopp commented Dec 15, 2022

I'm wondering if we could build the engine with _LIBCPP_REMOVE_TRANSITIVE_INCLUDES?

@cbracken
Copy link
Member

cbracken commented Dec 15, 2022

/cc @itsjustkevin this will fix b/262764490

@itsjustkevin
Copy link
Contributor

itsjustkevin commented Dec 15, 2022

Thanks @knopp and @cbracken for the lightning fast fix!

@knopp
Copy link
Member Author

knopp commented Dec 15, 2022

Apologies for the missing include. It would have been caught with _LIBCPP_REMOVE_TRANSITIVE_INCLUDES. It seems that the rest of the engine builds with this enabled just fine. I'll create PR for buildroot tomorrow.

@cbracken cbracken merged commit 2225185 into flutter:main Dec 15, 2022
@knopp knopp deleted the add_missing_include branch December 15, 2022 23:55
@cbracken cbracken mentioned this pull request Dec 15, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
2225185 Add missing include to FlutterThreadSynchronizer (flutter/eng…
32be15d 
…ine#38337)
loic-sharma pushed a commit to loic-sharma/flutter-engine that referenced this pull request Dec 16, 2022
@knopp @loic-sharma
Add missing include to FlutterThreadSynchronizer (flutter#38337)
866bd79
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
22251857f Add missing include to FlutterThreadSynchronizer (flutter/e…
5c18a9f 
…ngine#38337)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
2225185 Add missing include to FlutterThreadSynchronizer (flutter/eng…
d16ab0f 
…ine#38337)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
2225185 Add missing include to FlutterThreadSynchronizer (flutter/eng…
bdd7c4b 
…ine#38337)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
2225185 Add missing include to FlutterThreadSynchronizer (flutter/eng…
a2a1048 
…ine#38337)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
2225185 Add missing include to FlutterThreadSynchronizer (flutter/eng…
7fb9fa6 
…ine#38337)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
2225185 Add missing include to FlutterThreadSynchronizer (flutter/eng…
9a4f7b1 
…ine#38337)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
2225185 Add missing include to FlutterThreadSynchronizer (flutter/eng…
04c39d9 
…ine#38337)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
2225185 Add missing include to FlutterThreadSynchronizer (flutter/eng…
7195517 
…ine#38337)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
2225185 Add missing include to FlutterThreadSynchronizer (flutter/eng…
0305239 
…ine#38337)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
2225185 Add missing include to FlutterThreadSynchronizer (flutter/eng…
766f7cf 
…ine#38337)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
2225185 Add missing include to FlutterThreadSynchronizer (flutter/eng…
cd608f5 
…ine#38337)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
2225185 Add missing include to FlutterThreadSynchronizer (flutter/eng…
10d3341 
…ine#38337)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
2225185 Add missing include to FlutterThreadSynchronizer (flutter/eng…
7932ab2 
…ine#38337)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
2225185 Add missing include to FlutterThreadSynchronizer (flutter/eng…
4423aaa 
…ine#38337)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
2225185 Add missing include to FlutterThreadSynchronizer (flutter/eng…
4323351 
…ine#38337)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
Roll Flutter Engine from 2919651 to d91e208 (29 revisions) (#117242)
5018a6c 
* e28b26e [linux] Allow overriding asset, ICU data path (flutter/engine#38296)

* 35bdb8b Roll Skia from 9f728d78f10d to f549128104ba (1 revision) (flutter/engine#38319)

* 97e246c Roll Dart SDK from 358d0d1aa3e7 to 1dd5b1bf1099 (7 revisions) (flutter/engine#38320)

* d9580a5 Migrate iOS text input plugin to use ARC (flutter/engine#38179)

* c9e9fa5 Update web_sdk -> package test dependency to get updated package matcher (flutter/engine#38323)

* a7ec07f [fuchsia] Manually roll Fuchsia Linux SDK. (flutter/engine#38324)

* 61e95ba Remove doc reference to the compute method (flutter/engine#38246)

* 353d694 make sure CanvasRecorder updates clip bounds methods (flutter/engine#38325)

* 47a358c Started using FlutterEngineGroups by default on Android  (flutter/engine#37822)

* 7d8e106 Bump github/codeql-action from 2.1.35 to 2.1.36 (flutter/engine#38210)

* 8915b81 Update buildroot to b2ab6e1. (flutter/engine#38329)

* 4fe6206 Revert "Roll Dart SDK from 358d0d1aa3e7 to 1dd5b1bf1099 (7 revisions) (#38320)" (flutter/engine#38331)

* 2ff490c Roll Skia from f549128104ba to 5e69caecd166 (11 revisions) (flutter/engine#38333)

* 2225185 Add missing include to FlutterThreadSynchronizer (flutter/engine#38337)

* 467cfd7 Roll Fuchsia Mac SDK from VEOIaacOA75U7PYyz... to KtItDj-MERuua77aS... (flutter/engine#38339)

* 010f4ee Roll Fuchsia Linux SDK from zwfwHRSLdmV61hYqe... to urDNtEiHFAcBBhYe0... (flutter/engine#38340)

* 773b435 Sped up reading with FlutterStandardCodec. (flutter/engine#38327)

* 70439f6 Roll Skia from 5e69caecd166 to 62f22c9c7d67 (3 revisions) (flutter/engine#38341)

* bc1647f Roll the test package used by Web in preparation for a Dart 3 SDK roll (flutter/engine#38342)

* cac228a Roll Dart SDK from 358d0d1aa3e7 to 7b4d4ec3cad1 (14 revisions) (flutter/engine#38344)

* 13ae6eb Revert "Started using FlutterEngineGroups by default on Android  (#37822)" (flutter/engine#38351)

* ed80638 Add an explicit constraint on the matcher package version to ensure Dart 3 compatibility (flutter/engine#38352)

* dcafebf Roll Skia from 62f22c9c7d67 to 1b1f53d77ced (1 revision) (flutter/engine#38343)

* 6f61585 Roll Fuchsia Mac SDK from KtItDj-MERuua77aS... to bn5VF1-xDf-wKjIw8... (flutter/engine#38348)

* 0c00bc0 Remove 30fps cap from playgrounds (flutter/engine#38347)

* 38340bb [Impeller] Fix SceneC crash for nodes with children (flutter/engine#38346)

* 3a6b3f9 Roll Fuchsia Linux SDK from urDNtEiHFAcBBhYe0... to H6B0UgW07fc1nBtnc... (flutter/engine#38357)

* 81b4535 Roll Skia from 1b1f53d77ced to 7b0a9d9a3008 (8 revisions) (flutter/engine#38358)

* d91e208 Port touch-based tests from embedder integration test (flutter/engine#38234)
@cbracken cbracken mentioned this pull request Dec 17, 2022
Merged
8 tasks
loic-sharma pushed a commit to loic-sharma/flutter-engine that referenced this pull request Jan 3, 2023
@knopp @loic-sharma
Add missing include to FlutterThreadSynchronizer (flutter#38337)
7c2761c
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@engine-flutter-autoroll @gspencergoog
Roll Flutter Engine from 2919651 to d91e208 (29 revisions) (flutter#1…
1ad4f5b 
…17242)

* e28b26e [linux] Allow overriding asset, ICU data path (flutter/engine#38296)

* 35bdb8b Roll Skia from 9f728d78f10d to f549128104ba (1 revision) (flutter/engine#38319)

* 97e246c Roll Dart SDK from 358d0d1aa3e7 to 1dd5b1bf1099 (7 revisions) (flutter/engine#38320)

* d9580a5 Migrate iOS text input plugin to use ARC (flutter/engine#38179)

* c9e9fa5 Update web_sdk -> package test dependency to get updated package matcher (flutter/engine#38323)

* a7ec07f [fuchsia] Manually roll Fuchsia Linux SDK. (flutter/engine#38324)

* 61e95ba Remove doc reference to the compute method (flutter/engine#38246)

* 353d694 make sure CanvasRecorder updates clip bounds methods (flutter/engine#38325)

* 47a358c Started using FlutterEngineGroups by default on Android  (flutter/engine#37822)

* 7d8e106 Bump github/codeql-action from 2.1.35 to 2.1.36 (flutter/engine#38210)

* 8915b81 Update buildroot to b2ab6e1. (flutter/engine#38329)

* 4fe6206 Revert "Roll Dart SDK from 358d0d1aa3e7 to 1dd5b1bf1099 (7 revisions) (flutter#38320)" (flutter/engine#38331)

* 2ff490c Roll Skia from f549128104ba to 5e69caecd166 (11 revisions) (flutter/engine#38333)

* 2225185 Add missing include to FlutterThreadSynchronizer (flutter/engine#38337)

* 467cfd7 Roll Fuchsia Mac SDK from VEOIaacOA75U7PYyz... to KtItDj-MERuua77aS... (flutter/engine#38339)

* 010f4ee Roll Fuchsia Linux SDK from zwfwHRSLdmV61hYqe... to urDNtEiHFAcBBhYe0... (flutter/engine#38340)

* 773b435 Sped up reading with FlutterStandardCodec. (flutter/engine#38327)

* 70439f6 Roll Skia from 5e69caecd166 to 62f22c9c7d67 (3 revisions) (flutter/engine#38341)

* bc1647f Roll the test package used by Web in preparation for a Dart 3 SDK roll (flutter/engine#38342)

* cac228a Roll Dart SDK from 358d0d1aa3e7 to 7b4d4ec3cad1 (14 revisions) (flutter/engine#38344)

* 13ae6eb Revert "Started using FlutterEngineGroups by default on Android  (flutter#37822)" (flutter/engine#38351)

* ed80638 Add an explicit constraint on the matcher package version to ensure Dart 3 compatibility (flutter/engine#38352)

* dcafebf Roll Skia from 62f22c9c7d67 to 1b1f53d77ced (1 revision) (flutter/engine#38343)

* 6f61585 Roll Fuchsia Mac SDK from KtItDj-MERuua77aS... to bn5VF1-xDf-wKjIw8... (flutter/engine#38348)

* 0c00bc0 Remove 30fps cap from playgrounds (flutter/engine#38347)

* 38340bb [Impeller] Fix SceneC crash for nodes with children (flutter/engine#38346)

* 3a6b3f9 Roll Fuchsia Linux SDK from urDNtEiHFAcBBhYe0... to H6B0UgW07fc1nBtnc... (flutter/engine#38357)

* 81b4535 Roll Skia from 1b1f53d77ced to 7b0a9d9a3008 (8 revisions) (flutter/engine#38358)

* d91e208 Port touch-based tests from embedder integration test (flutter/engine#38234)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@cbracken cbracken cbracken approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs tests platform-macos

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@knopp @Hixie @cbracken @itsjustkevin