Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[linux] Allow overriding asset, ICU data path #38296

Merged
cbracken merged 1 commit into from
Dec 15, 2022
Merged

[linux] Allow overriding asset, ICU data path #38296

cbracken merged 1 commit into from
Dec 15, 2022

Conversation

@cbracken
Copy link
Member

@cbracken cbracken commented Dec 14, 2022 •
edited
Loading

Support setting a custom asset directory and ICU data path.

Fixes: flutter/flutter#117103
Issue: flutter/flutter#117102

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cbracken
[linux] Allow overriding asset, ICU data path
9672466 
Support setting a custom asset directory and ICU data path.

Fixes: flutter/flutter#117103
@cbracken cbracken merged commit e28b26e into flutter:main Dec 15, 2022
@cbracken cbracken deleted the set-linux-asset-path branch December 15, 2022 16:25
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2022
@engine-flutter-autoroll
e28b26e [linux] Allow overriding asset, ICU data path (flutter/engine…
4be60e0 
…#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2022
@engine-flutter-autoroll
e28b26e [linux] Allow overriding asset, ICU data path (flutter/engine…
72c7441 
…#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2022
@engine-flutter-autoroll
e28b26e [linux] Allow overriding asset, ICU data path (flutter/engine…
ff072e7 
…#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2022
@engine-flutter-autoroll
e28b26e [linux] Allow overriding asset, ICU data path (flutter/engine…
54c36f6 
…#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2022
@engine-flutter-autoroll
e28b26e [linux] Allow overriding asset, ICU data path (flutter/engine…
1feeae7 
…#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2022
@engine-flutter-autoroll
e28b26e [linux] Allow overriding asset, ICU data path (flutter/engine…
c778345 
…#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2022
@engine-flutter-autoroll
e28b26e [linux] Allow overriding asset, ICU data path (flutter/engine…
980da6c 
…#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2022
@engine-flutter-autoroll
e28b26e [linux] Allow overriding asset, ICU data path (flutter/engine…
8a0d110 
…#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2022
@engine-flutter-autoroll
e28b26e [linux] Allow overriding asset, ICU data path (flutter/engine…
d0b92ff 
…#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
e28b26e [linux] Allow overriding asset, ICU data path (flutter/engine…
b93abf2 
…#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
e28b26e [linux] Allow overriding asset, ICU data path (flutter/engine…
1401139 
…#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
e28b26e [linux] Allow overriding asset, ICU data path (flutter/engine…
78bf008 
…#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
e28b26e [linux] Allow overriding asset, ICU data path (flutter/engine…
ebaaf6a 
…#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
e28b26e [linux] Allow overriding asset, ICU data path (flutter/engine…
6bfe256 
…#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
e28b26e [linux] Allow overriding asset, ICU data path (flutter/engine…
de7c712 
…#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
e28b26e [linux] Allow overriding asset, ICU data path (flutter/engine…
f151c7d 
…#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
e28b26e [linux] Allow overriding asset, ICU data path (flutter/engine…
ea109cb 
…#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
e28b26e [linux] Allow overriding asset, ICU data path (flutter/engine…
c07aeb0 
…#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
e28b26e1d [linux] Allow overriding asset, ICU data path (flutter/engi…
4bcfe37 
…ne#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
e28b26e [linux] Allow overriding asset, ICU data path (flutter/engine…
49d862c 
…#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
e28b26e [linux] Allow overriding asset, ICU data path (flutter/engine…
b866d9a 
…#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
e28b26e [linux] Allow overriding asset, ICU data path (flutter/engine…
9732934 
…#38296)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
e28b26e [linux] Allow overriding asset, ICU data path (flutter/engine…
68dc5bf 
…#38296)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
Roll Flutter Engine from 2919651 to d91e208 (29 revisions) (#117242)
5018a6c 
* e28b26e [linux] Allow overriding asset, ICU data path (flutter/engine#38296)

* 35bdb8b Roll Skia from 9f728d78f10d to f549128104ba (1 revision) (flutter/engine#38319)

* 97e246c Roll Dart SDK from 358d0d1aa3e7 to 1dd5b1bf1099 (7 revisions) (flutter/engine#38320)

* d9580a5 Migrate iOS text input plugin to use ARC (flutter/engine#38179)

* c9e9fa5 Update web_sdk -> package test dependency to get updated package matcher (flutter/engine#38323)

* a7ec07f [fuchsia] Manually roll Fuchsia Linux SDK. (flutter/engine#38324)

* 61e95ba Remove doc reference to the compute method (flutter/engine#38246)

* 353d694 make sure CanvasRecorder updates clip bounds methods (flutter/engine#38325)

* 47a358c Started using FlutterEngineGroups by default on Android  (flutter/engine#37822)

* 7d8e106 Bump github/codeql-action from 2.1.35 to 2.1.36 (flutter/engine#38210)

* 8915b81 Update buildroot to b2ab6e1. (flutter/engine#38329)

* 4fe6206 Revert "Roll Dart SDK from 358d0d1aa3e7 to 1dd5b1bf1099 (7 revisions) (#38320)" (flutter/engine#38331)

* 2ff490c Roll Skia from f549128104ba to 5e69caecd166 (11 revisions) (flutter/engine#38333)

* 2225185 Add missing include to FlutterThreadSynchronizer (flutter/engine#38337)

* 467cfd7 Roll Fuchsia Mac SDK from VEOIaacOA75U7PYyz... to KtItDj-MERuua77aS... (flutter/engine#38339)

* 010f4ee Roll Fuchsia Linux SDK from zwfwHRSLdmV61hYqe... to urDNtEiHFAcBBhYe0... (flutter/engine#38340)

* 773b435 Sped up reading with FlutterStandardCodec. (flutter/engine#38327)

* 70439f6 Roll Skia from 5e69caecd166 to 62f22c9c7d67 (3 revisions) (flutter/engine#38341)

* bc1647f Roll the test package used by Web in preparation for a Dart 3 SDK roll (flutter/engine#38342)

* cac228a Roll Dart SDK from 358d0d1aa3e7 to 7b4d4ec3cad1 (14 revisions) (flutter/engine#38344)

* 13ae6eb Revert "Started using FlutterEngineGroups by default on Android  (#37822)" (flutter/engine#38351)

* ed80638 Add an explicit constraint on the matcher package version to ensure Dart 3 compatibility (flutter/engine#38352)

* dcafebf Roll Skia from 62f22c9c7d67 to 1b1f53d77ced (1 revision) (flutter/engine#38343)

* 6f61585 Roll Fuchsia Mac SDK from KtItDj-MERuua77aS... to bn5VF1-xDf-wKjIw8... (flutter/engine#38348)

* 0c00bc0 Remove 30fps cap from playgrounds (flutter/engine#38347)

* 38340bb [Impeller] Fix SceneC crash for nodes with children (flutter/engine#38346)

* 3a6b3f9 Roll Fuchsia Linux SDK from urDNtEiHFAcBBhYe0... to H6B0UgW07fc1nBtnc... (flutter/engine#38357)

* 81b4535 Roll Skia from 1b1f53d77ced to 7b0a9d9a3008 (8 revisions) (flutter/engine#38358)

* d91e208 Port touch-based tests from embedder integration test (flutter/engine#38234)
loic-sharma pushed a commit to loic-sharma/flutter-engine that referenced this pull request Jan 3, 2023
@cbracken @loic-sharma
[linux] Allow overriding asset, ICU data path (flutter#38296)
881c130 
Support setting a custom asset directory and ICU data path.

Fixes: flutter/flutter#117103
Issue: flutter/flutter#117102
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@engine-flutter-autoroll @gspencergoog
Roll Flutter Engine from 2919651 to d91e208 (29 revisions) (flutter#1…
1ad4f5b 
…17242)

* e28b26e [linux] Allow overriding asset, ICU data path (flutter/engine#38296)

* 35bdb8b Roll Skia from 9f728d78f10d to f549128104ba (1 revision) (flutter/engine#38319)

* 97e246c Roll Dart SDK from 358d0d1aa3e7 to 1dd5b1bf1099 (7 revisions) (flutter/engine#38320)

* d9580a5 Migrate iOS text input plugin to use ARC (flutter/engine#38179)

* c9e9fa5 Update web_sdk -> package test dependency to get updated package matcher (flutter/engine#38323)

* a7ec07f [fuchsia] Manually roll Fuchsia Linux SDK. (flutter/engine#38324)

* 61e95ba Remove doc reference to the compute method (flutter/engine#38246)

* 353d694 make sure CanvasRecorder updates clip bounds methods (flutter/engine#38325)

* 47a358c Started using FlutterEngineGroups by default on Android  (flutter/engine#37822)

* 7d8e106 Bump github/codeql-action from 2.1.35 to 2.1.36 (flutter/engine#38210)

* 8915b81 Update buildroot to b2ab6e1. (flutter/engine#38329)

* 4fe6206 Revert "Roll Dart SDK from 358d0d1aa3e7 to 1dd5b1bf1099 (7 revisions) (flutter#38320)" (flutter/engine#38331)

* 2ff490c Roll Skia from f549128104ba to 5e69caecd166 (11 revisions) (flutter/engine#38333)

* 2225185 Add missing include to FlutterThreadSynchronizer (flutter/engine#38337)

* 467cfd7 Roll Fuchsia Mac SDK from VEOIaacOA75U7PYyz... to KtItDj-MERuua77aS... (flutter/engine#38339)

* 010f4ee Roll Fuchsia Linux SDK from zwfwHRSLdmV61hYqe... to urDNtEiHFAcBBhYe0... (flutter/engine#38340)

* 773b435 Sped up reading with FlutterStandardCodec. (flutter/engine#38327)

* 70439f6 Roll Skia from 5e69caecd166 to 62f22c9c7d67 (3 revisions) (flutter/engine#38341)

* bc1647f Roll the test package used by Web in preparation for a Dart 3 SDK roll (flutter/engine#38342)

* cac228a Roll Dart SDK from 358d0d1aa3e7 to 7b4d4ec3cad1 (14 revisions) (flutter/engine#38344)

* 13ae6eb Revert "Started using FlutterEngineGroups by default on Android  (flutter#37822)" (flutter/engine#38351)

* ed80638 Add an explicit constraint on the matcher package version to ensure Dart 3 compatibility (flutter/engine#38352)

* dcafebf Roll Skia from 62f22c9c7d67 to 1b1f53d77ced (1 revision) (flutter/engine#38343)

* 6f61585 Roll Fuchsia Mac SDK from KtItDj-MERuua77aS... to bn5VF1-xDf-wKjIw8... (flutter/engine#38348)

* 0c00bc0 Remove 30fps cap from playgrounds (flutter/engine#38347)

* 38340bb [Impeller] Fix SceneC crash for nodes with children (flutter/engine#38346)

* 3a6b3f9 Roll Fuchsia Linux SDK from urDNtEiHFAcBBhYe0... to H6B0UgW07fc1nBtnc... (flutter/engine#38357)

* 81b4535 Roll Skia from 1b1f53d77ced to 7b0a9d9a3008 (8 revisions) (flutter/engine#38358)

* d91e208 Port touch-based tests from embedder integration test (flutter/engine#38234)
@fertrig fertrig mentioned this pull request Jan 31, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stuartmorgan-g stuartmorgan-g Awaiting requested review from stuartmorgan-g

@robert-ancell robert-ancell Awaiting requested review from robert-ancell

1 more reviewer

@loic-sharma loic-sharma loic-sharma approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform-linux

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support overriding asset path and ICU path on Linux

2 participants

@cbracken @loic-sharma