Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Remove PlatformDispatcher.onError reference to the compute method #38246

Merged
auto-submit merged 1 commit into from
Dec 15, 2022
Merged

Remove PlatformDispatcher.onError reference to the compute method #38246

auto-submit merged 1 commit into from
Dec 15, 2022

Conversation

@ueman
Copy link
Contributor

@ueman ueman commented Dec 13, 2022

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

The PlatformDispatcher.onError referenced the implementation of the compute method. This is no longer up to date, since compute is now making use of the Dart method to spawn an Isolate.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 15, 2022
@auto-submit auto-submit bot merged commit 61e95ba into flutter:main Dec 15, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2022
@engine-flutter-autoroll
61e95ba Remove doc reference to the compute method (flutter/engine#38246
00da67c 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2022
@engine-flutter-autoroll
61e95ba Remove doc reference to the compute method (flutter/engine#38246
dce39c5 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2022
@engine-flutter-autoroll
61e95ba Remove doc reference to the compute method (flutter/engine#38246
b2c3d15 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2022
@engine-flutter-autoroll
61e95ba Remove doc reference to the compute method (flutter/engine#38246
c456d8c 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2022
@engine-flutter-autoroll
61e95ba Remove doc reference to the compute method (flutter/engine#38246
e2e4b81 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
61e95ba Remove doc reference to the compute method (flutter/engine#38246
8420816 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
61e95ba Remove doc reference to the compute method (flutter/engine#38246
e454389 
)
loic-sharma pushed a commit to loic-sharma/flutter-engine that referenced this pull request Dec 16, 2022
@ueman @loic-sharma
Remove doc reference to the compute method (flutter#38246)
2004ff8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
61e95ba Remove doc reference to the compute method (flutter/engine#38246
64ec20e 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
61e95ba Remove doc reference to the compute method (flutter/engine#38246
0855b1b 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
61e95ba Remove doc reference to the compute method (flutter/engine#38246
85d629d 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
61e95ba Remove doc reference to the compute method (flutter/engine#38246
72614fc 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
61e95ba Remove doc reference to the compute method (flutter/engine#38246
81e7ce1 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
61e95ba Remove doc reference to the compute method (flutter/engine#38246
e485094 
)
@ueman ueman deleted the patch-1 branch December 16, 2022 06:12
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
61e95ba Remove doc reference to the compute method (flutter/engine#38246
27a30f0 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
61e95ba Remove doc reference to the compute method (flutter/engine#38246
5fc623f 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
61e95ba Remove doc reference to the compute method (flutter/engine#38246
ad52536 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
61e95ba Remove doc reference to the compute method (flutter/engine#38246
2b666cb 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
61e95ba Remove doc reference to the compute method (flutter/engine#38246
573f553 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
61e95ba Remove doc reference to the compute method (flutter/engine#38246
e48cb1d 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
61e95ba Remove doc reference to the compute method (flutter/engine#38246
30c30b4 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
61e95ba Remove doc reference to the compute method (flutter/engine#38246
c15caed 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 16, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
61e95ba Remove doc reference to the compute method (flutter/engine#38246
1e7b591 
)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 16, 2022
@engine-flutter-autoroll
Roll Flutter Engine from 2919651 to d91e208 (29 revisions) (#117242)
5018a6c 
* e28b26e [linux] Allow overriding asset, ICU data path (flutter/engine#38296)

* 35bdb8b Roll Skia from 9f728d78f10d to f549128104ba (1 revision) (flutter/engine#38319)

* 97e246c Roll Dart SDK from 358d0d1aa3e7 to 1dd5b1bf1099 (7 revisions) (flutter/engine#38320)

* d9580a5 Migrate iOS text input plugin to use ARC (flutter/engine#38179)

* c9e9fa5 Update web_sdk -> package test dependency to get updated package matcher (flutter/engine#38323)

* a7ec07f [fuchsia] Manually roll Fuchsia Linux SDK. (flutter/engine#38324)

* 61e95ba Remove doc reference to the compute method (flutter/engine#38246)

* 353d694 make sure CanvasRecorder updates clip bounds methods (flutter/engine#38325)

* 47a358c Started using FlutterEngineGroups by default on Android  (flutter/engine#37822)

* 7d8e106 Bump github/codeql-action from 2.1.35 to 2.1.36 (flutter/engine#38210)

* 8915b81 Update buildroot to b2ab6e1. (flutter/engine#38329)

* 4fe6206 Revert "Roll Dart SDK from 358d0d1aa3e7 to 1dd5b1bf1099 (7 revisions) (#38320)" (flutter/engine#38331)

* 2ff490c Roll Skia from f549128104ba to 5e69caecd166 (11 revisions) (flutter/engine#38333)

* 2225185 Add missing include to FlutterThreadSynchronizer (flutter/engine#38337)

* 467cfd7 Roll Fuchsia Mac SDK from VEOIaacOA75U7PYyz... to KtItDj-MERuua77aS... (flutter/engine#38339)

* 010f4ee Roll Fuchsia Linux SDK from zwfwHRSLdmV61hYqe... to urDNtEiHFAcBBhYe0... (flutter/engine#38340)

* 773b435 Sped up reading with FlutterStandardCodec. (flutter/engine#38327)

* 70439f6 Roll Skia from 5e69caecd166 to 62f22c9c7d67 (3 revisions) (flutter/engine#38341)

* bc1647f Roll the test package used by Web in preparation for a Dart 3 SDK roll (flutter/engine#38342)

* cac228a Roll Dart SDK from 358d0d1aa3e7 to 7b4d4ec3cad1 (14 revisions) (flutter/engine#38344)

* 13ae6eb Revert "Started using FlutterEngineGroups by default on Android  (#37822)" (flutter/engine#38351)

* ed80638 Add an explicit constraint on the matcher package version to ensure Dart 3 compatibility (flutter/engine#38352)

* dcafebf Roll Skia from 62f22c9c7d67 to 1b1f53d77ced (1 revision) (flutter/engine#38343)

* 6f61585 Roll Fuchsia Mac SDK from KtItDj-MERuua77aS... to bn5VF1-xDf-wKjIw8... (flutter/engine#38348)

* 0c00bc0 Remove 30fps cap from playgrounds (flutter/engine#38347)

* 38340bb [Impeller] Fix SceneC crash for nodes with children (flutter/engine#38346)

* 3a6b3f9 Roll Fuchsia Linux SDK from urDNtEiHFAcBBhYe0... to H6B0UgW07fc1nBtnc... (flutter/engine#38357)

* 81b4535 Roll Skia from 1b1f53d77ced to 7b0a9d9a3008 (8 revisions) (flutter/engine#38358)

* d91e208 Port touch-based tests from embedder integration test (flutter/engine#38234)
loic-sharma pushed a commit to loic-sharma/flutter-engine that referenced this pull request Jan 3, 2023
@ueman @loic-sharma
Remove doc reference to the compute method (flutter#38246)
6a86ea4
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@engine-flutter-autoroll @gspencergoog
Roll Flutter Engine from 2919651 to d91e208 (29 revisions) (flutter#1…
1ad4f5b 
…17242)

* e28b26e [linux] Allow overriding asset, ICU data path (flutter/engine#38296)

* 35bdb8b Roll Skia from 9f728d78f10d to f549128104ba (1 revision) (flutter/engine#38319)

* 97e246c Roll Dart SDK from 358d0d1aa3e7 to 1dd5b1bf1099 (7 revisions) (flutter/engine#38320)

* d9580a5 Migrate iOS text input plugin to use ARC (flutter/engine#38179)

* c9e9fa5 Update web_sdk -> package test dependency to get updated package matcher (flutter/engine#38323)

* a7ec07f [fuchsia] Manually roll Fuchsia Linux SDK. (flutter/engine#38324)

* 61e95ba Remove doc reference to the compute method (flutter/engine#38246)

* 353d694 make sure CanvasRecorder updates clip bounds methods (flutter/engine#38325)

* 47a358c Started using FlutterEngineGroups by default on Android  (flutter/engine#37822)

* 7d8e106 Bump github/codeql-action from 2.1.35 to 2.1.36 (flutter/engine#38210)

* 8915b81 Update buildroot to b2ab6e1. (flutter/engine#38329)

* 4fe6206 Revert "Roll Dart SDK from 358d0d1aa3e7 to 1dd5b1bf1099 (7 revisions) (flutter#38320)" (flutter/engine#38331)

* 2ff490c Roll Skia from f549128104ba to 5e69caecd166 (11 revisions) (flutter/engine#38333)

* 2225185 Add missing include to FlutterThreadSynchronizer (flutter/engine#38337)

* 467cfd7 Roll Fuchsia Mac SDK from VEOIaacOA75U7PYyz... to KtItDj-MERuua77aS... (flutter/engine#38339)

* 010f4ee Roll Fuchsia Linux SDK from zwfwHRSLdmV61hYqe... to urDNtEiHFAcBBhYe0... (flutter/engine#38340)

* 773b435 Sped up reading with FlutterStandardCodec. (flutter/engine#38327)

* 70439f6 Roll Skia from 5e69caecd166 to 62f22c9c7d67 (3 revisions) (flutter/engine#38341)

* bc1647f Roll the test package used by Web in preparation for a Dart 3 SDK roll (flutter/engine#38342)

* cac228a Roll Dart SDK from 358d0d1aa3e7 to 7b4d4ec3cad1 (14 revisions) (flutter/engine#38344)

* 13ae6eb Revert "Started using FlutterEngineGroups by default on Android  (flutter#37822)" (flutter/engine#38351)

* ed80638 Add an explicit constraint on the matcher package version to ensure Dart 3 compatibility (flutter/engine#38352)

* dcafebf Roll Skia from 62f22c9c7d67 to 1b1f53d77ced (1 revision) (flutter/engine#38343)

* 6f61585 Roll Fuchsia Mac SDK from KtItDj-MERuua77aS... to bn5VF1-xDf-wKjIw8... (flutter/engine#38348)

* 0c00bc0 Remove 30fps cap from playgrounds (flutter/engine#38347)

* 38340bb [Impeller] Fix SceneC crash for nodes with children (flutter/engine#38346)

* 3a6b3f9 Roll Fuchsia Linux SDK from urDNtEiHFAcBBhYe0... to H6B0UgW07fc1nBtnc... (flutter/engine#38357)

* 81b4535 Roll Skia from 1b1f53d77ced to 7b0a9d9a3008 (8 revisions) (flutter/engine#38358)

* d91e208 Port touch-based tests from embedder integration test (flutter/engine#38234)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

@jason-simmons jason-simmons jason-simmons approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ueman @chinmaygarde @jason-simmons