This repository was archived by the owner on Dec 5, 2024. It is now read-only.
Edits to the branches-view branch #378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Unity DLLs path relative to Unity installation directory
Throw if the manager isn't ready so that windows use their cached data instead
…adme Updating readme to include 2017.1 as a supported version
Warning cleanup
Fixing bugs in the InitProjectView
…nager Adding and using the CacheManager
Initialize Workflow
shana
reviewed
Nov 15, 2017
| public Rect Render(Rect rect, Action<TreeNode> singleClick = null, Action<TreeNode> doubleClick = null) | ||
| { | ||
| if (!nodes.Any()) | ||
| return rect; |
Member
There was a problem hiding this comment.
TODO: take this out and check IsInitialized before calling Render
shana
reviewed
Nov 15, 2017
| } | ||
|
|
||
| public void Load(IEnumerable<ITreeData> data, string title) | ||
| public void Load(IEnumerable<GitBranch> data, string title) |
shana
reviewed
Nov 15, 2017
| private void OnTreeGUI(Rect rect) | ||
| { | ||
| if (!treeLocals.IsInitialized) | ||
| RefreshBranchList(); |
Member
There was a problem hiding this comment.
This was ensuring render doesn't get called before initialization happens, so we need to add this check in a different way now we have the cache going
shana
approved these changes
Nov 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch targets #151