Skip to content
This repository was archived by the owner on Oct 11, 2024. It is now read-only.

Comments

Pickup DB_HOST env variable#1480

Merged
gdbelvin merged 2 commits intogoogle:masterfrom
gdbelvin:fix_mysql
Feb 28, 2020
Merged

Pickup DB_HOST env variable#1480
gdbelvin merged 2 commits intogoogle:masterfrom
gdbelvin:fix_mysql

Conversation

@gdbelvin
Copy link
Contributor

Fixup #1473

@gdbelvin gdbelvin requested a review from a team as a code owner February 28, 2020 11:16
@gdbelvin gdbelvin requested a review from pav-kv February 28, 2020 11:16
@gdbelvin gdbelvin requested review from Mercurrent and removed request for pav-kv February 28, 2020 11:16
@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

Merging #1480 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1480      +/-   ##
=========================================
- Coverage   67.93%   67.9%   -0.03%     
=========================================
  Files          54      54              
  Lines        4026    4026              
=========================================
- Hits         2735    2734       -1     
  Misses        891     891              
- Partials      400     401       +1
Impacted Files Coverage Δ
core/sequencer/trillian_client.go 58.57% <0%> (-2.86%) ⬇️
core/sequencer/server.go 73.94% <0%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38db010...f1a6ccc. Read the comment docs.

@gdbelvin gdbelvin merged commit 9ea84e6 into google:master Feb 28, 2020
@gdbelvin gdbelvin deleted the fix_mysql branch February 28, 2020 11:41
gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Mar 25, 2020
* master: (109 commits)
  Upgrade Prometheus (google#1500)
  Run `go build ./...` with github action (google#1446)
  Replace tinkio.ProtoFile with keyset.BinaryReader (google#1492)
  Bump github.com/golang/mock from 1.4.1 to 1.4.2
  Bump github.com/prometheus/client_golang from 1.5.0 to 1.5.1
  Bump github.com/golang/protobuf from 1.3.3 to 1.3.5
  Bump github.com/google/tink from 1.3.0-rc4 to 1.3.0
  New Design Doc (google#1469)
  Acknowledgements (google#1490)
  Use cases (google#1489)
  Bump github.com/prometheus/client_golang from 1.4.1 to 1.5.0 (google#1486)
  README.md # Related (google#1485)
  Explain authorized keys (google#1484)
  Use new prometheus sidecar deployment (google#1483)
  don't overwrite the ReplicaSet service label (google#1482)
  Update encrypted creds (google#1481)
  Pickup DB_HOST env variable (google#1480)
  Fix credential encryption (google#1479)
  Use Cloud MySQL in GKE (google#1473)
  Update client_secrets.json.enc (google#1478)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants