Skip to content
This repository was archived by the owner on Oct 11, 2024. It is now read-only.

Comments

Update encrypted creds#1481

Merged
gdbelvin merged 1 commit intogoogle:masterfrom
gdbelvin:fix_mysql
Feb 28, 2020
Merged

Update encrypted creds#1481
gdbelvin merged 1 commit intogoogle:masterfrom
gdbelvin:fix_mysql

Conversation

@gdbelvin
Copy link
Contributor

travis encrypt-file client_secret.json --pro -r google/keytransparency

Fixes #1479 and #1478

travis encrypt-file client_secret.json --pro -r google/keytransparency
@gdbelvin gdbelvin requested a review from a team as a code owner February 28, 2020 12:05
@gdbelvin gdbelvin requested a review from taknira February 28, 2020 12:05
@gdbelvin gdbelvin requested review from NatalieDoduc and removed request for taknira February 28, 2020 12:05
@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

Merging #1481 into master will increase coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1481      +/-   ##
==========================================
+ Coverage   67.83%   68.05%   +0.22%     
==========================================
  Files          54       54              
  Lines        4026     4026              
==========================================
+ Hits         2731     2740       +9     
+ Misses        893      884       -9     
  Partials      402      402
Impacted Files Coverage Δ
core/sequencer/election/tracker.go 80.45% <0%> (+10.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ea84e6...cd1f3f0. Read the comment docs.

Copy link

@NatalieDoduc NatalieDoduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shame we can't test this beforehand.

@gdbelvin gdbelvin merged commit b14c3eb into google:master Feb 28, 2020
@gdbelvin gdbelvin deleted the fix_mysql branch February 28, 2020 12:25
gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Mar 25, 2020
* master: (109 commits)
  Upgrade Prometheus (google#1500)
  Run `go build ./...` with github action (google#1446)
  Replace tinkio.ProtoFile with keyset.BinaryReader (google#1492)
  Bump github.com/golang/mock from 1.4.1 to 1.4.2
  Bump github.com/prometheus/client_golang from 1.5.0 to 1.5.1
  Bump github.com/golang/protobuf from 1.3.3 to 1.3.5
  Bump github.com/google/tink from 1.3.0-rc4 to 1.3.0
  New Design Doc (google#1469)
  Acknowledgements (google#1490)
  Use cases (google#1489)
  Bump github.com/prometheus/client_golang from 1.4.1 to 1.5.0 (google#1486)
  README.md # Related (google#1485)
  Explain authorized keys (google#1484)
  Use new prometheus sidecar deployment (google#1483)
  don't overwrite the ReplicaSet service label (google#1482)
  Update encrypted creds (google#1481)
  Pickup DB_HOST env variable (google#1480)
  Fix credential encryption (google#1479)
  Use Cloud MySQL in GKE (google#1473)
  Update client_secrets.json.enc (google#1478)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants