Replace tinkio.ProtoFile with keyset.BinaryReader#1492
Replace tinkio.ProtoFile with keyset.BinaryReader#1492gdbelvin merged 3 commits intogoogle:masterfrom
Conversation
tinkio.ProtoFile can be replaced with the BinaryReader/BinaryWriter
Codecov Report
@@ Coverage Diff @@
## master #1492 +/- ##
==========================================
+ Coverage 68.25% 68.27% +0.01%
==========================================
Files 54 53 -1
Lines 4026 4000 -26
==========================================
- Hits 2748 2731 -17
+ Misses 879 867 -12
- Partials 399 402 +3
Continue to review full report at Codecov.
|
NatalieDoduc
left a comment
NatalieDoduc
left a comment
There was a problem hiding this comment.
Is the Build Error expected? Is there another separate PR in flight that will green-ify the build?
NatalieDoduc
left a comment
NatalieDoduc
left a comment
There was a problem hiding this comment.
Can you add in your PR description what motivates the change?
Also - i'm not familiar with the general codebase, but with this being used in many binaries, is it worth to have a keyset(File) handling library?
Finally - a small request for tests?
|
There appears to be a flakey kubernetes test due to an unreliable |
|
The integration tests build and exercise the command line utility that this PR modifies. |
NatalieDoduc
left a comment
NatalieDoduc
left a comment
There was a problem hiding this comment.
LGTM
For collective future knowledge, what did you do to re-trigger the flaky curl command?
|
To re-run flakey tests, login to travis.com |
* master: (109 commits) Upgrade Prometheus (google#1500) Run `go build ./...` with github action (google#1446) Replace tinkio.ProtoFile with keyset.BinaryReader (google#1492) Bump github.com/golang/mock from 1.4.1 to 1.4.2 Bump github.com/prometheus/client_golang from 1.5.0 to 1.5.1 Bump github.com/golang/protobuf from 1.3.3 to 1.3.5 Bump github.com/google/tink from 1.3.0-rc4 to 1.3.0 New Design Doc (google#1469) Acknowledgements (google#1490) Use cases (google#1489) Bump github.com/prometheus/client_golang from 1.4.1 to 1.5.0 (google#1486) README.md # Related (google#1485) Explain authorized keys (google#1484) Use new prometheus sidecar deployment (google#1483) don't overwrite the ReplicaSet service label (google#1482) Update encrypted creds (google#1481) Pickup DB_HOST env variable (google#1480) Fix credential encryption (google#1479) Use Cloud MySQL in GKE (google#1473) Update client_secrets.json.enc (google#1478) ...
3 participants
tinkio.ProtoFile can be replaced with the BinaryReader/BinaryWriter
Simplify the crypto library by removing duplicate features.