ui/add transit modal#8482
Closed
andaley wants to merge 78 commits into
Closed
Conversation
…ut still need to enable onClose
…dd-transit-modal
* Fix tests for updated transit with modals workflow
…h copy flash message
Add mention of new CLI parameters.
* Pin HTTP Host header for all client requests * Drop port map scheme * Add SRV Lookup environment var * Lookup SRV records only when env var is specified * Add docs Co-Authored-By: Michel Vocks <michelvocks@gmail.com>
* upper case the transit form title for hmac * uppercase hmac for tab * fix indentation
* website: update readme with known issues * website: typo fix * website: typo fix * website: wrap text for better readability
Add missing link
* Remove the versus section on the website. We don't keep it maintained, it's very out of date, and we don't really like comparing ourselves to other software anyways; it's not fair to describe other software or solutions in ways that may not align with how they want to be described. Co-authored-by: Jeff Escalante <jescalan@users.noreply.github.com>
* stackdriver: use label extraction and add debug config * go.mod: update go-metrics-stackdriver * vendor go-metrics-stackdriver
* Fix metric for Get This was incorrectly being reported as List * Measure transactions
Monkeychip
requested changes
Mar 13, 2020
Contributor
Monkeychip
left a comment
Monkeychip
left a comment
There was a problem hiding this comment.
Looks good. I know you're still working on some things, but I QA'd a bit and things worked as expected. Nice work.
chelshaw
reviewed
Mar 16, 2020
chelshaw
approved these changes
Mar 16, 2020
Contributor
chelshaw
left a comment
chelshaw
left a comment
There was a problem hiding this comment.
Went through all the changes carefully and didn't see any red flags. I think it looks good to go!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move Transit Actions into Modals
This PR contains the last portion of the Transit UX improvements. It includes moving the results of transit key actions into a modal instead of on the page.
For example:
[insert gifs here]
Testing
Using the Transit Learn Docs as a guide, verify that you can perform each key action (encrypt, decrypt, HMAC, etc), as well as copy and paste the results of the text.
TODO:
only render modals whenmodal already hasisModalActiveis truedisplay: nonewhich doesn't interfere with screen readers