Release v1.0.1#257
Conversation
- There are no RoleBindings with `account-member` role, so, in case of resources eligible for users with `account-member` role, it used to end up in UnAuthorized. This commit fixes it.
Fix/iam account member role bindings, and resource metrics
feature(infra): added delete pv api
managed resources gh-issue: #252
fix(apps/console): updates mres '.spec.resourceName' when cloning
handled error for the get-device in case of no cluster or no vpn device
🐛 Fixed issue with get-device
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Type: Enhancement
PR Summary: This pull request introduces several enhancements and fixes across multiple components of the application. Key updates include the addition of a resolver for deleting persistent volumes (PVs) in the infrastructure layer, improvements to managed resource creation logic, and updates to role binding validations. It also addresses issues related to environment cloning, observability handling, and more. The changes aim to improve the application's functionality, security, and code maintainability.
Decision: Comment
📝 Type: 'Enhancement' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
- Unsupported files: the diff contains files that Sourcery does not currently support during reviews.
- Big diff: the diff is too large to approve with confidence.
General suggestions:
- Ensure comprehensive testing of the new PV deletion feature to verify that it handles edge cases and permissions correctly.
- Review the changes to managed resource creation and environment cloning for potential impacts on existing workflows or data.
- Consider the broader implications of the modifications to role binding validations and observability handling, especially in terms of user experience and system performance.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
3 participants
Description
kloudlite release v1.0.1