Fail activation if we exceed a timeout#4614
Merged
knative-prow-robot merged 6 commits intoknative:masterfrom Jul 9, 2019
Merged
Fail activation if we exceed a timeout#4614knative-prow-robot merged 6 commits intoknative:masterfrom
knative-prow-robot merged 6 commits intoknative:masterfrom
Conversation
knative-prow-robot
added
the
do-not-merge/work-in-progress
knative-prow-robot
added
the
size/M
Contributor
Author
|
/assign @vagababov WDYT? |
Contributor
knative-prow-robot
left a comment
knative-prow-robot
left a comment
There was a problem hiding this comment.
@jonjohnsonjr: 0 warnings.
Details
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
vagababov
reviewed
Jul 3, 2019
knative-prow-robot
added
size/L
jonjohnsonjr
force-pushed
the
inactive-timeout
branch
from
857b555 to
1a296ed
Compare
This avoids racing the Revision reconciler, which needs to inspect pod statuses before we scale down the Deployment.
Contributor
Author
|
/retest |
knative-prow-robot
removed
the
do-not-merge/work-in-progress
Contributor
Author
|
/retest |
mattmoor
reviewed
Jul 9, 2019
|
The following is the coverage report on pkg/.
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonjohnsonjr, mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Contributor
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This partially addresses #3456
The KPA reconciler will consider activation to have TimedOut if it is activating (Active=Unknown) for ProgressDeadlineSeconds (this is currently a hardcoded constant, but we might want to make it configurable in the future if we revive #810) and scale the deployment to zero, since we don't expect activation to ever succeed.
The Revision reconciler gets triggered after ProgressDeadlineSeconds because the Deployment that it watches will have it status update with Progressing=False,Reason=ProgressDeadlineExceeded. The Revision reconciler currently does pod failure diagnosis, which breaks if the pods get scaled down to zero. To avoid breaking that, the KPA reconciler will wait for ProgressDeadlineSeconds + 10 seconds before scaling to zero, to give the Revision reconciler an opportunity to look at the pod status. In the future we can make the KPA responsible for pod failure diagnosis to remove this race (and the 10 second buffer).
This PR is a continuation of #4094, but I've split apart the not-scaling-to-zero part from the lifecycle changes to make the PR smaller.