Cleanup ZBT-WE826 DTS, add USB WWAN kmods#1
Closed
ndoo wants to merge 1 commit intolede-project:masterfrom
ndoo:zbt-we826
Closed
Cleanup ZBT-WE826 DTS, add USB WWAN kmods#1ndoo wants to merge 1 commit intolede-project:masterfrom ndoo:zbt-we826
ndoo wants to merge 1 commit intolede-project:masterfrom
ndoo:zbt-we826
Conversation
Contributor
|
i have staged a change in my tree that already refactors the dts files. what exactly did you change ? |
Contributor
Author
|
Spaces to tabs. It's non essential though, the patches to dts file can be
skipped.
|
Contributor
|
this should be 1 change / patch. each patch should clearly state what you have changed. i looked at the profile last night while making some changes to timage generation code and i think all of these are not required kmod-scsi-core kmod-scsi-generic kmod-mmc kmod-sdhci block-mount kmod-usb-core |
Contributor
|
i'll manually fold the changes into my staging tree today |
| kmod-mt76 | ||
| kmod-mt76 kmod-scsi-core kmod-scsi-generic kmod-mmc kmod-sdhci \ | ||
| block-mount kmod-usb-core kmod-usb2 kmod-usb-ohci kmod-usb-serial \ | ||
| kmod-usb-serial-option kmod-usb-serial-wwan comgt wwan |
Member
There was a problem hiding this comment.
The general convention is to deploy image with only basic and really needed packages.
This model is available (directly from manufacturer) without the WWAN card, so you shouldn't add custom packages here as the user will be able to install them later.
Remember that there is no way to remove packages which are included/builtin in squashfs image - removing/uninstalling them will not free up space on the FLASH.
Contributor
Author
There was a problem hiding this comment.
Understood. The SDHC modules should remain though, as the connector is
soldered on.
Contributor
There was a problem hiding this comment.
On 12/05/2016 10:04, Andrew Yong wrote:
In target/linux/ramips/mt7620/profiles/zbt.mk
#1 (comment):PACKAGES:=\
kmod-scsi-core kmod-scsi-generic kmod-mmc kmod-sdhci \block-mount kmod-usb-core kmod-usb-dwc2 kmod-usb2 kmod-usb-ohci \kmod-mt76kmod-mt76 kmod-scsi-core kmod-scsi-generic kmod-mmc kmod-sdhci \block-mount kmod-usb-core kmod-usb2 kmod-usb-ohci kmod-usb-serial \kmod-usb-serial-option kmod-usb-serial-wwan comgt wwanUnderstood. The SDHC modules should remain though, as the connector is
soldered on.—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
https://github.com/lede-project/source/pull/1/files/aa6b387161fe65b44216824a4c2c0f9f71a86ffd#r62979358
but its the wrong module. did you test the connector ?
Contributor
Author
There was a problem hiding this comment.
Will test and open a separate PR once I find a working combination.
Contributor
|
there is no modem ? i asked him and he said there always is. anyhow. i am working on a profile cleanup that removes all the broken package selections and i just pulled the status led change into that tree. the rest is a NAK i am afraid. |
Contributor
Author
|
No problem. I understand where you are coming from.
The AliExpress seller will include a Huawei 3G or LTE modem for an
additional fee and PCB antennae are stuck on the inside of the chassis.
I'm not sure if that qualifies as integrated. But it's a valid point that
since they sell a model without the card, users may be better off manually
installing the packages.
Though the disk space saved isn't too significant especially factoring in
that there's a user accessible microSD slot.
|
Member
Exactly. From my POV we shouldn't force users to have any additional packages in basic image. If the modem was soldered on the main board, I would vote for including required packages in basic image to support it. But there is mpci-e slot with USB bus only and it can be used for different hardware, like ex. GPS.
One seller will do that, other will not: http://postimg.org/image/h3ru1zfpd/ Cheers! |
Closed
jclehner
added a commit
to jclehner/lede-source
that referenced
this pull request
Feb 6, 2017
13hakta
referenced
this pull request
in 13hakta/source
Feb 10, 2017
Remove unneeded cpu port property, update external interface init according to mapped ports for RTL8267RB: ext port #1 = extif0 ext port lede-project#2 = extif1 Signed-off-by: Vitaly Chekryzhev <13hakta@gmail.com>
13hakta
referenced
this pull request
in 13hakta/source
Feb 10, 2017
Remove unneeded cpu port property, update external interface init according to mapped ports for RTL8267RB: ext port #1 = extif0 ext port lede-project#2 = extif1 Signed-off-by: Vitaly Chekryzhev <13hakta@gmail.com>
13hakta
referenced
this pull request
in 13hakta/source
Feb 10, 2017
Driver supports 2 chip versions: RTL8367RB, RTL8367R-VB. Each of them has 2 external ports. RTL8367RB has ports indexed as #1,lede-project#2 (PHY lede-project#6, lede-project#7). RTL8367R-VB has ports indexed as #0,#1 (PHY lede-project#5,lede-project#6). Map ports so that extif0 complies to external port 0 or 1 depending on chip ID. Signed-off-by: Vitaly Chekryzhev <13hakta@gmail.com>
13hakta
referenced
this pull request
in 13hakta/source
Feb 10, 2017
Remove unneeded cpu port property, update external interface init according to mapped ports for RTL8267RB: ext port #1 = extif0 ext port lede-project#2 = extif1 Signed-off-by: Vitaly Chekryzhev <13hakta@gmail.com>
13hakta
referenced
this pull request
in 13hakta/source
Feb 10, 2017
Driver supports 2 chip versions: RTL8367RB, RTL8367R-VB. Each of them has 2 external ports. RTL8367RB has ports indexed as #1,lede-project#2 (PHY lede-project#6, lede-project#7). RTL8367R-VB has ports indexed as #0,#1 (PHY lede-project#5,lede-project#6). Map ports so that extif0 complies to external port 0 or 1 depending on chip ID. Signed-off-by: Vitaly Chekryzhev <13hakta@gmail.com>
13hakta
referenced
this pull request
in 13hakta/source
Feb 10, 2017
Remove unneeded cpu port property, update external interface init according to mapped ports for RTL8267RB: ext port #1 = extif0 ext port lede-project#2 = extif1 Signed-off-by: Vitaly Chekryzhev <13hakta@gmail.com>
13hakta
referenced
this pull request
in 13hakta/source
Feb 10, 2017
Remove unneeded cpu port property, update external interface init according to mapped ports for RTL8267RB: ext port #1 = extif0 ext port lede-project#2 = extif1 Signed-off-by: Vitaly Chekryzhev <13hakta@gmail.com>
13hakta
referenced
this pull request
in 13hakta/source
Feb 10, 2017
Remove unneeded cpu port property, update external interface init according to mapped ports for RTL8267RB: ext port #1 = extif0 ext port lede-project#2 = extif1 Signed-off-by: Vitaly Chekryzhev <13hakta@gmail.com>
13hakta
referenced
this pull request
in 13hakta/source
Feb 16, 2017
Remove unneeded cpu port property, update external interface init according to mapped ports for RTL8267RB: ext port #1 = extif0 ext port lede-project#2 = extif1 Signed-off-by: Vitaly Chekryzhev <13hakta@gmail.com>
13hakta
referenced
this pull request
in 13hakta/source
Feb 16, 2017
Driver supports 2 chip versions: RTL8367RB, RTL8367R-VB. Each of them has 2 external ports. RTL8367RB has ports indexed as #1,lede-project#2 (PHY lede-project#6, lede-project#7). RTL8367R-VB has ports indexed as #0,#1 (PHY lede-project#5,lede-project#6). Map ports so that extif0 complies to external port 0 or 1 depending on chip ID. Signed-off-by: Vitaly Chekryzhev <13hakta@gmail.com>
13hakta
referenced
this pull request
in 13hakta/source
Feb 16, 2017
Remove unneeded cpu port property, update external interface init according to mapped ports for RTL8267RB: ext port #1 = extif0 ext port lede-project#2 = extif1 Signed-off-by: Vitaly Chekryzhev <13hakta@gmail.com>
13hakta
referenced
this pull request
in 13hakta/source
Feb 19, 2017
Driver supports 2 chip versions: RTL8367RB, RTL8367R-VB. Each of them has 2 external ports. RTL8367RB has ports indexed as #1,lede-project#2 (PHY lede-project#6, lede-project#7). RTL8367R-VB has ports indexed as #0,#1 (PHY lede-project#5,lede-project#6). Map ports so that extif0 complies to external port 0 or 1 depending on chip ID. Signed-off-by: Vitaly Chekryzhev <13hakta@gmail.com>
13hakta
referenced
this pull request
in 13hakta/source
Feb 19, 2017
Remove unneeded cpu port property, update external interface init according to mapped ports for RTL8267RB: ext port #1 = extif0 ext port lede-project#2 = extif1 Signed-off-by: Vitaly Chekryzhev <13hakta@gmail.com>
13hakta
referenced
this pull request
in 13hakta/source
Feb 19, 2017
Remove unneeded cpu port property, update external interface init according to mapped ports for RTL8267RB: ext port #1 = extif0 ext port lede-project#2 = extif1 Signed-off-by: Vitaly Chekryzhev <13hakta@gmail.com>
Closed
jow-
pushed a commit
that referenced
this pull request
Aug 9, 2019
When enabling atomic-sleep-debugging options in the kernel,
following splat is seen when disabling the interface (which happens on boot):
[ 10.892878] eth0: link down
[ 10.896788] BUG: sleeping function called from invalid context at net/core/dev.c:5563
[ 10.904730] in_atomic(): 1, irqs_disabled(): 1, pid: 425, name: ip
[ 10.911004] 2 locks held by ip/425:
[ 10.914539] #0: (rtnl_mutex){....}, at: [<80377474>] rtnetlink_rcv_msg+0x2d8/0x380
[ 10.922441] #1: (&(&ag->lock)->rlock){....}, at: [<80330158>] ag71xx_hw_disable+0x24/0x94
[ 10.930976] CPU: 0 PID: 425 Comm: ip Not tainted 4.14.136 #0
[ 10.936716] Stack : 805e0000 80589228 80557404 876998ec 80610000 80610000 87cdcafc 805b5327
[ 10.945233] 80551534 000001a9 8061386c 87699ccc 87cfb180 00000001 876998a0 84f70903
[ 10.953751] 00000000 00000000 80b00000 8769979c 6a7407fa 00000000 00000007 00000000
[ 10.962270] 000000b7 16d0954a 000000b6 00000000 80000000 87cb658c 87cb65b0 00000001
[ 10.970787] 8046f97c 87699ccc 87cfb180 87ff2810 00000003 802ce724 0806e098 80610000
[ 10.979306] ...
[ 10.981797] Call Trace:
[ 10.984287] [<8006cb0c>] show_stack+0x58/0x100
[ 10.988814] [<800aab34>] ___might_sleep+0x100/0x120
[ 10.993774] [<8035c434>] napi_disable+0x30/0xd8
[ 10.998377] [<80330198>] ag71xx_hw_disable+0x64/0x94
[ 11.003418] [<8033069c>] ag71xx_stop+0x24/0x38
[ 11.007959] [<80359e30>] __dev_close_many+0xcc/0x104
[ 11.013009] [<80362eac>] __dev_change_flags+0xc8/0x1ac
[ 11.018227] [<80362fb8>] dev_change_flags+0x28/0x70
[ 11.023182] [<80376890>] do_setlink+0x31c/0x91c
[ 11.027786] [<80379360>] rtnl_newlink+0x3ec/0x7f8
[ 11.032563] [<80377498>] rtnetlink_rcv_msg+0x2fc/0x380
[ 11.037799] [<8039a734>] netlink_rcv_skb+0xd4/0x178
[ 11.042754] [<80399d10>] netlink_unicast+0x168/0x250
[ 11.047796] [<8039a2d4>] netlink_sendmsg+0x3d8/0x434
[ 11.052841] [<8033f0e4>] ___sys_sendmsg+0x1dc/0x290
[ 11.057794] [<80340140>] __sys_sendmsg+0x54/0x84
[ 11.062495] [<8007212c>] syscall_common+0x34/0x58
This is caused by calling napi_disable() while holding the spinlock.
Fix it by omitting the spinlock, which is not required here
Extensively tested on GL-MiFi, RB-912 and RB-922 hardware
Signed-off-by: Koen Vandeputte <koen.vandeputte@ncentric.com>
jow-
pushed a commit
that referenced
this pull request
May 8, 2020
Fixes a build error seen when applying the kernel patches. Applying patch generic/435-mtd-add-routerbootpart-parser-config.patch patching file drivers/mtd/parsers/Kconfig Hunk #1 FAILED at 160. 1 out of 1 hunk FAILED -- rejects in file drivers/mtd/parsers/Kconfig patching file drivers/mtd/parsers/Makefile Hunk #1 FAILED at 10. 1 out of 1 hunk FAILED -- rejects in file drivers/mtd/parsers/Makefile This was missed as 5.4 is currently set as testing kernel while the main kernel being used is 4.19 Fixes: 2976e42 ("generic: routerboot partition build bits") Signed-off-by: Koen Vandeputte <koen.vandeputte@ncentric.com>
jow-
pushed a commit
that referenced
this pull request
Dec 22, 2020
The Ubiquiti Network airCube AC is a cube shaped device supporting 2.4 GHz and 5 GHz with internal 2x2 MIMO antennas. It can be powered with either one of: - 24v power supply with 3.0mm x 1.0mm barrel plug - 24v passive PoE on first LAN port There are four 10/100/1000 Mbps ports (1 * WAN + 3 * LAN). First LAN port have optional PoE passthrough to the WAN port. SoC: Qualcomm / Atheros AR9342 RAM: 64 MB DDR2 Flash: 16 MB SPI NOR Ethernet: 4x 10/100/1000 Mbps (1 WAN + 3 LAN) LEDS: 1x via a SPI controller (not yet supported) Buttons: 1x Reset Serial: 1x (only RX and TX); 115200 baud, 8N1 Missing features: - LED control is not supported Physical to internal switch port mapping: - physical port #1 (poe in) = switchport 2 - physical port #2 = switchport 3 - physical port #3 = switchport 5 - physical port #4 (wan/poe out) = switchport 4 Factory update is tested and is the same as for Ubiquiti AirCube ISP hence the shared configuration between that devices. Signed-off-by: Roman Kuzmitskii <damex.pp@icloud.com>
jow-
pushed a commit
that referenced
this pull request
Feb 23, 2021
SMP isn't supported on BCM6358 since it has a shared TLB. Some boards boot with CPU #1 instead of CPU #0, and this is currently not supported do to a smp-bmips bug. Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
jow-
pushed a commit
that referenced
this pull request
May 12, 2021
The code uses get_mtd_device_nm() which must be followed by a call to put_mtd_device() once the handle is no longer used. This fixes spurious shutdown console messages such as: [ 83.099037] Removing MTD device #1 (hard_config) with use count 1 Reported-by: Koen Vandeputte <koen.vandeputte@ncentric.com> Tested-by: Koen Vandeputte <koen.vandeputte@ncentric.com> Signed-off-by: Thibaut VARÈNE <hacks@slashdirt.org> [Backported from master] Signed-off-by: Koen Vandeputte <koen.vandeputte@ncentric.com>
jow-
pushed a commit
that referenced
this pull request
Oct 23, 2021
ag71xx_probe is registering ag71xx_interrupt as handler for the gmac0/gmac1 interrupts. The handler is trying to use napi_schedule to handle the processing of packets. But the netif_napi_add for this device is called a lot later in ag71xx_probe. It can therefore happen that a still running gmac0/gmac1 is triggering the interrupt handler with a bit from AG71XX_INT_POLL set in AG71XX_REG_INT_STATUS. The handler will then call napi_schedule and the napi code will crash the system because the ag->napi is not yet initialized: libphy: Fixed MDIO Bus: probed CPU 0 Unable to handle kernel paging request at virtual address 00000000, epc == 00000000, ra == 81373408 Oops[#1]: CPU: 0 PID: 1 Comm: swapper Not tainted 5.4.152 #0 $ 0 : 00000000 00000001 00000000 8280bf28 $ 4 : 82a98cb0 00000000 81620000 00200140 $ 8 : 00000000 00000000 74657272 7570743a $12 : 0000005b 8280bdb9 ffffffff ffffffff $16 : 00000001 82a98cb0 00000000 8280bf27 $20 : 8280bf28 81620000 ffff8b00 8280bf30 $24 : 00000000 8125af9c $28 : 82828000 8280bed8 81610000 81373408 Hi : 00005fff Lo : 2e48f657 epc : 00000000 0x0 ra : 81373408 __napi_poll+0x3c/0x11c Status: 1100dc03 KERNEL EXL IE Cause : 00800008 (ExcCode 02) BadVA : 00000000 PrId : 00019750 (MIPS 74Kc) Modules linked in: Process swapper (pid: 1, threadinfo=(ptrval), task=(ptrval), tls=00000000) Stack : ffff8afb ffff8afa 81620000 00200140 00000000 82a98cb0 00000008 0000012c 81625620 81373684 ffffffff ffffffff ffffffef 00000008 816153d8 81620000 815b0d60 815bbd54 00000000 81753700 8280bf28 8280bf28 8280bf30 8280bf30 81753748 00000008 00000003 00000004 0000000c 00000100 3fffffff 8175373c 816059f0 814ddb48 00000001 8160ab30 81615488 810618bc 00000006 00000000 ... Call Trace: [<81373684>] net_rx_action+0xfc/0x26c [<814ddb48>] __do_softirq+0x118/0x2ec [<810618bc>] handle_percpu_irq+0x50/0x80 [<8125ab8c>] plat_irq_dispatch+0x94/0xc8 [<81004e98>] handle_int+0x138/0x144 Code: (Bad address in epc) ---[ end trace a60d797432b656b2 ]--- The gmcc0/gmac1 must be brought in a state in which it doesn't signal a AG71XX_INT_POLL related status bits as interrupt before registering the interrupt handler. ag71xx_hw_start will take care of re-initializing the AG71XX_REG_INT_ENABLE. Fixes: f529a37 ("surprise :p") Signed-off-by: Sven Eckelmann <sven@narfation.org>
jow-
pushed a commit
that referenced
this pull request
Nov 28, 2021
Martin Kennedy reported: |Presently, I get this kernel panic on mpc85xx (Aerohive HiveAP 370) |on OpenWrt 'master' which occurs right as the second processor is |initialized: | |[ 0.478804] rcu: Hierarchical SRCU implementation. |[ 0.535569] dyndbg: Ignore empty _ddebug table in a CONFIG_DYNAMIC_DEBUG_CORE build |[ 0.627233] smp: Bringing up secondary CPUs ... |[ 0.681659] kernel tried to execute user page (0) - exploit attempt? (uid: 0) |[ 0.766618] BUG: Unable to handle kernel instruction fetch (NULL pointer?) |[ 0.848899] Faulting instruction address: 0x00000000 |[ 0.908273] Oops: Kernel access of bad area, sig: 11 [#1] |[ 0.972851] BE PAGE_SIZE=4K SMP NR_CPUS=2 P1020 RDB |[ 1.031179] Modules linked in: |[ 1.067640] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.10.80 #0 |[ 1.139507] NIP: 00000000 LR: c0021d2c CTR: 00000000 |[ 1.199921] REGS: c1051cf0 TRAP: 0400 Not tainted (5.10.80) |[...] |[ 1.758220] NIP [00000000] 0x0 |[ 1.794688] LR [c0021d2c] smp_85xx_kick_cpu+0xe8/0x568 |[ 1.856126] Call Trace: |[ 1.885295] [c1051da8] [c0021cb8] smp_85xx_kick_cpu+0x74/0x568 (unreliable) |[ 1.968633] [c1051de8] [c0011460] __cpu_up+0xc0/0x228 |[ 2.029038] [c1051e18] [c0031bbc] bringup_cpu+0x30/0x224 |[ 2.092572] [c1051e48] [c0031f3c] cpu_up.constprop.0+0x180/0x33c |[..] |[ 2.727952] ---[ end trace 9b796a4bafb6bc14 ]--- |[ 3.800879] Kernel panic - not syncing: Fatal exception |[ 3.862353] Rebooting in 1 seconds.. |[ 5.905097] System Halted, OK to turn off power | |I bisected this down to commit 3ae5da5 ("kernel: bump 5.10 to 5.10.80"); |that is, I don't get the panic right before this commit, but I do after. He reported the issue upstream and Xiaoming Ni from huawei came up with the patch (that is on it's way to upstream). While the AP370 is not in Openwrt, this will likely affect other SMP P1020 devices OpenWrt ships with: like the AP330, Enterasys WS-AP3710i, etc. Reported-by: Martin Kennedy <hurricos@gmail.com> Tested-by: Martin Kennedy <hurricos@gmail.com> Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
jow-
pushed a commit
that referenced
this pull request
Dec 5, 2021
Zbtlink ZBT-WG1602 is a Wi-Fi router intendent to use with WWAN
(UMTS/LTE/3G/4G) modems. The router board offsers a couple of miniPCIe
slots with USB and SIM only and another one pure miniPCIe slot as well
as five Gigabit Ethernet ports (4xLAN + WAN).
Specification:
* SoC: MT7621A
* RAM: 256/512 MiB
* Flash: 16/32 MiB (SPI NOR)
* external watchdog (looks like Torexsemi XC6131B)
* Eth: 10/100/1000 Mbps Ethernet x5 ports (4xLAN + WAN)
* WLAN 2GHz: MT7603EN (.11n, MIMO 2x2)
* WLAN 5GHz: MT7612EN (.11ac, MIMO 2x2)
* WLAN Ants: detachable x2, shared by 2GHz & 5GHz radios
* miniPCIe: 2x slots with USB&SIM + 1x slot with regular PCIe bus
* WWAN Ants: detachable x4
* External storage: microSD (SDXC) slot
* USB: 2.0 Type-A port
* LED: 11 (5 per Eth phy, 3 SoC controlled, 2 WLAN 2/5 controlled, 1
power indicator)
* Button: 1 (reset)
* UART: console (115200 baud)
* Power: DC jack (12 V / 2.5 A)
Additional HW information:
* SoC USB port #1 is shared by internal miniPCIe slot and external
Type-A USB port, USB D+/D- lines are toggled between ports using a
GPIO controlled DPDT switch.
* Power of the USB enabled miniPCIe slots can be individually controlled
using dedicated GPIO lines.
* Vendor firmware feeds the external watchdog with 1s pulses. GPIO
watchdog driver is able to either generate a 1us pulses or toggle the
output line. 1us is not enough for the external watchod timer, so
the line toggling driver mode is utilized.
Installation:
Vendor's firmware is OpenWrt (LEDE) based, so the sysupgrade image can
be directly used to install OpenWrt. Firmware must be upgraded using the
'force' and 'do not save configuration' command line options (or
correspondig web interface checkboxes) since the vendor firmware is from
the pre-DSA era.
Signed-off-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>
jow-
pushed a commit
that referenced
this pull request
Mar 25, 2022
Ticerex on the OpenWrt Forum reported a gnarly crash when he was using Samsung 840 and 850 EVOs with his MyBook Live: | BUG: Kernel NULL pointer dereference at 0x00000000 | Faulting instruction address: 0xc03ed4b8 | Oops: Kernel access of bad area, sig: 11 [#1] | BE PAGE_SIZE=4K PowerPC 44x Platform | CPU: 0 PID: 362 Comm: scsi_eh_1 Not tainted 5.4.163 #0 | NIP: c03ed4b8 LR: c03d27e8 CTR: c03ed36c | REGS: cfa59950 TRAP: 0300 Not tainted (5.4.163) | MSR: 00021000 <CE,ME> CR: 42000222 XER: 00000000 | DEAR: 00000000 ESR: 00000000 | GPR00: c03d27e8 cfa59a08 cfa55fe0 00000000 0fa46bc0 [...] | [..] | NIP [c03ed4b8] sata_dwc_qc_issue+0x14c/0x254 | LR [c03d27e8] ata_qc_issue+0x1c8/0x2dc | Call Trace: | [cfa59a08] [c003f4e0] __cancel_work_timer+0x124/0x194 (unreliable) | [cfa59a78] [c03d27e8] ata_qc_issue+0x1c8/0x2dc | [cfa59a98] [c03d2b3c] ata_exec_internal_sg+0x240/0x524 | [cfa59b08] [c03d2e98] ata_exec_internal+0x78/0xe0 | [cfa59b58] [c03d30fc] ata_read_log_page.part.38+0x1dc/0x204 | [cfa59bc8] [c03d324c] ata_identify_page_supported+0x68/0x130 | [...] This turned out this is an issue with upstream changing ATA_TAG_INTERNAL's value from 31 to 32 during 4.18 release. Update "SATA_DWC_QCMD_MAX" to account for that. Link: https://forum.openwrt.org/t/my-book-live-duo-reboot-loop/122464 Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
jow-
pushed a commit
that referenced
this pull request
Mar 26, 2022
Ticerex on the OpenWrt Forum reported a gnarly crash when he was using Samsung 840 and 850 EVOs with his MyBook Live: | BUG: Kernel NULL pointer dereference at 0x00000000 | Faulting instruction address: 0xc03ed4b8 | Oops: Kernel access of bad area, sig: 11 [#1] | BE PAGE_SIZE=4K PowerPC 44x Platform | CPU: 0 PID: 362 Comm: scsi_eh_1 Not tainted 5.4.163 #0 | NIP: c03ed4b8 LR: c03d27e8 CTR: c03ed36c | REGS: cfa59950 TRAP: 0300 Not tainted (5.4.163) | MSR: 00021000 <CE,ME> CR: 42000222 XER: 00000000 | DEAR: 00000000 ESR: 00000000 | GPR00: c03d27e8 cfa59a08 cfa55fe0 00000000 0fa46bc0 [...] | [..] | NIP [c03ed4b8] sata_dwc_qc_issue+0x14c/0x254 | LR [c03d27e8] ata_qc_issue+0x1c8/0x2dc | Call Trace: | [cfa59a08] [c003f4e0] __cancel_work_timer+0x124/0x194 (unreliable) | [cfa59a78] [c03d27e8] ata_qc_issue+0x1c8/0x2dc | [cfa59a98] [c03d2b3c] ata_exec_internal_sg+0x240/0x524 | [cfa59b08] [c03d2e98] ata_exec_internal+0x78/0xe0 | [cfa59b58] [c03d30fc] ata_read_log_page.part.38+0x1dc/0x204 | [cfa59bc8] [c03d324c] ata_identify_page_supported+0x68/0x130 | [...] This turned out this is an issue with upstream changing ATA_TAG_INTERNAL's value from 31 to 32 during 4.18 release. Update "SATA_DWC_QCMD_MAX" to account for that. Link: https://forum.openwrt.org/t/my-book-live-duo-reboot-loop/122464 Signed-off-by: Christian Lamparter <chunkeey@gmail.com> (cherry picked from commit 5ac672cfab60e90ab8a0bf3491fa2a27619d22d6)
jow-
pushed a commit
that referenced
this pull request
Mar 26, 2022
Ticerex on the OpenWrt Forum reported a gnarly crash when he was using Samsung 840 and 850 EVOs with his MyBook Live: | BUG: Kernel NULL pointer dereference at 0x00000000 | Faulting instruction address: 0xc03ed4b8 | Oops: Kernel access of bad area, sig: 11 [#1] | BE PAGE_SIZE=4K PowerPC 44x Platform | CPU: 0 PID: 362 Comm: scsi_eh_1 Not tainted 5.4.163 #0 | NIP: c03ed4b8 LR: c03d27e8 CTR: c03ed36c | REGS: cfa59950 TRAP: 0300 Not tainted (5.4.163) | MSR: 00021000 <CE,ME> CR: 42000222 XER: 00000000 | DEAR: 00000000 ESR: 00000000 | GPR00: c03d27e8 cfa59a08 cfa55fe0 00000000 0fa46bc0 [...] | [..] | NIP [c03ed4b8] sata_dwc_qc_issue+0x14c/0x254 | LR [c03d27e8] ata_qc_issue+0x1c8/0x2dc | Call Trace: | [cfa59a08] [c003f4e0] __cancel_work_timer+0x124/0x194 (unreliable) | [cfa59a78] [c03d27e8] ata_qc_issue+0x1c8/0x2dc | [cfa59a98] [c03d2b3c] ata_exec_internal_sg+0x240/0x524 | [cfa59b08] [c03d2e98] ata_exec_internal+0x78/0xe0 | [cfa59b58] [c03d30fc] ata_read_log_page.part.38+0x1dc/0x204 | [cfa59bc8] [c03d324c] ata_identify_page_supported+0x68/0x130 | [...] This turned out this is an issue with upstream changing ATA_TAG_INTERNAL's value from 31 to 32 during 4.18 release. Update "SATA_DWC_QCMD_MAX" to account for that. Link: https://forum.openwrt.org/t/my-book-live-duo-reboot-loop/122464 Signed-off-by: Christian Lamparter <chunkeey@gmail.com> (cherry picked from commit e95dec8)
jow-
pushed a commit
that referenced
this pull request
May 27, 2022
Original patch: cifsd-team/ksmbd-tools#227 adapted for ksmbd kernel module v3.4.3 by me. Fixes crash in v3.4.3 only. Use original patch when updating to v3.4.4 as this one will fail hunk #1. Signed-off-by: Marius Dinu <m95d+git@psihoexpert.ro>
jow-
pushed a commit
that referenced
this pull request
Sep 10, 2022
Turris MOX randomly crashes up, when there is connected miniPCIe card MediaTek MT7915 with the following output: [ 71.457007] Internal error: synchronous external abort: 96000210 [#1] SMP [ 71.464021] Modules linked in: xt_connlimit pppoe ppp_async nf_conncount iptable_nat ath9k xt_state xt_nat xt_helper xt_conntrack xt_connmark xt_connbytes xt_REDIREl [ 71.464187] btintel br_netfilter bnep bluetooth ath9k_hw ath10k_pci ath10k_core ath sch_tbf sch_ingress sch_htb sch_hfsc em_u32 cls_u32 cls_tcindex cls_route cls_mg [ 71.629589] CPU: 0 PID: 1298 Comm: kworker/u5:3 Not tainted 5.4.114 #0 [ 71.636319] Hardware name: CZ.NIC Turris Mox Board (DT) [ 71.641725] Workqueue: napi_workq napi_workfn [ 71.646221] pstate: 80400085 (Nzcv daIf +PAN -UAO) [ 71.651169] pc : mt76_set_irq_mask+0x118/0x150 [mt76] [ 71.656385] lr : mt7915_init_debugfs+0x358/0x368 [mt7915e] [ 71.662038] sp : ffffffc010003cd0 [ 71.665451] x29: ffffffc010003cd0 x28: 0000000000000060 [ 71.670929] x27: ffffffc010a56f98 x26: ffffffc010c0fa9a [ 71.676407] x25: ffffffc010ba8788 x24: ffffff803e01fe00 [ 71.681885] x23: 0000000000000030 x22: ffffffc010003dc4 [ 71.687361] x21: 0000000000000000 x20: ffffff803e01fea4 [ 71.692839] x19: ffffff803cb725c0 x18: 000000002d660780 [ 71.698317] x17: 0000000000000000 x16: 0000000000000001 [ 71.703795] x15: 0000000000005ee0 x14: ffffffc010d1d000 [ 71.709272] x13: 0000000000002f70 x12: 0000000000000000 [ 71.714749] x11: 0000000000000000 x10: 0000000000000040 [ 71.720226] x9 : ffffffc010bbe980 x8 : ffffffc010bbe978 [ 71.725704] x7 : ffffff803e4003f0 x6 : 0000000000000000 [ 71.731181] x5 : ffffffc02f240000 x4 : ffffffc010003e00 [ 71.736658] x3 : 0000000000000000 x2 : ffffffc008e3f230 [ 71.742135] x1 : 00000000000d7010 x0 : ffffffc0114d7010 [ 71.747613] Call trace: [ 71.750137] mt76_set_irq_mask+0x118/0x150 [mt76] [ 71.754990] mt7915_dual_hif_set_irq_mask+0x108/0xdc0 [mt7915e] [ 71.761098] __handle_irq_event_percpu+0x6c/0x170 [ 71.765950] handle_irq_event_percpu+0x34/0x88 [ 71.770531] handle_irq_event+0x40/0xb0 [ 71.774486] handle_level_irq+0xe0/0x170 [ 71.778530] generic_handle_irq+0x24/0x38 [ 71.782667] advk_pcie_irq_handler+0x11c/0x238 [ 71.787249] __handle_irq_event_percpu+0x6c/0x170 [ 71.792099] handle_irq_event_percpu+0x34/0x88 [ 71.796680] handle_irq_event+0x40/0xb0 [ 71.800633] handle_fasteoi_irq+0xdc/0x190 [ 71.804855] generic_handle_irq+0x24/0x38 [ 71.808988] __handle_domain_irq+0x60/0xb8 [ 71.813213] gic_handle_irq+0x8c/0x198 [ 71.817077] el1_irq+0xf0/0x1c0 [ 71.820314] el1_da+0xc/0xc0 [ 71.823288] mt76_set_irq_mask+0x118/0x150 [mt76] [ 71.828141] mt7915_mac_tx_free+0x4c4/0x828 [mt7915e] [ 71.833352] mt7915_queue_rx_skb+0x5c/0xa8 [mt7915e] [ 71.838473] mt76_dma_cleanup+0x89c/0x1248 [mt76] [ 71.843329] __napi_poll+0x38/0xf8 [ 71.846835] napi_workfn+0x58/0xb0 [ 71.850342] process_one_work+0x1fc/0x390 [ 71.854475] worker_thread+0x48/0x4d0 [ 71.858252] kthread+0x120/0x128 [ 71.861581] ret_from_fork+0x10/0x1c [ 71.865273] Code: 52800000 d65f03c0 f9562c00 8b214000 (b9400000) [ 71.871560] ---[ end trace 1d4e29987011411b ]--- [ 71.876320] Kernel panic - not syncing: Fatal exception in interrupt [ 71.882875] SMP: stopping secondary CPUs [ 71.886923] Kernel Offset: disabled [ 71.890519] CPU features: 0x0002,00002008 [ 71.894649] Memory Limit: none [ 71.897799] Rebooting in 3 seconds.. Patch is awaiting upstream merge: https://lore.kernel.org/linux-pci/20220802123816.21817-1-pali@kernel.org/T/#u There was also discussion about it in the linux-pci mailing list, where can be found response from Marvell's employee regarding A3720 PCIe erratum 3.12, which seems to provide further details which help this issue: https://lore.kernel.org/linux-pci/BN9PR18MB425154FE5019DCAF2028A1D5DB8D9@BN9PR18MB4251.namprd18.prod.outlook.com/t/#u Reported-by: Ondřej Caletka <ondrej@caletka.cz> [Turris MOX] Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com> Reviewed-by: Robert Marko <robimarko@gmail.com>
openwrt-bot
pushed a commit
that referenced
this pull request
Dec 12, 2022
This showed up in the log: |Hunk #1 succeeded at 555 (offset -83 lines). Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
openwrt-bot
pushed a commit
that referenced
this pull request
Jan 3, 2023
Removed upstreamed: pending-5.15/101-Use-stddefs.h-instead-of-compiler.h.patch[1] ipq806x/patches-5.15/122-01-clk-qcom-clk-krait-fix-wrong-div2-functions.patch[2] bcm27xx/patches-5.15/950-0198-drm-fourcc-Add-packed-10bit-YUV-4-2-0-format.patch[3] Manually rebased: ramips/patches-5.15/100-PCI-mt7621-Add-MediaTek-MT7621-PCIe-host-controller-.patch[4] Added patch/backported: ramips/patches-5.15/107-PCI-mt7621-Add-sentinel-to-quirks-table.patch[5] All other patches automatically rebased. 1. https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.15.86&id=c160505c9b574b346031fdf2c649d19e7939ca11 2. https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.15.86&id=a051e10bfc6906d29dae7a31f0773f2702edfe1b 3. https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v5.15.86&id=ec1727f89ecd6f2252c0c75e200058819f7ce47a 4. Quilt gave this output when I applied the patch to rebase it: % quilt push -f Applying patch platform/100-PCI-mt7621-Add-MediaTek-MT7621-PCIe-host-controller-.patch patching file arch/mips/ralink/Kconfig patching file drivers/pci/controller/Kconfig patching file drivers/pci/controller/Makefile patching file drivers/staging/Kconfig patching file drivers/staging/Makefile patching file drivers/staging/mt7621-pci/Kconfig patching file drivers/staging/mt7621-pci/Makefile patching file drivers/staging/mt7621-pci/TODO patching file drivers/staging/mt7621-pci/mediatek,mt7621-pci.txt patching file drivers/staging/mt7621-pci/pci-mt7621.c Hunk #1 FAILED at 1. Not deleting file drivers/staging/mt7621-pci/pci-mt7621.c as content differs from patch 1 out of 1 hunk FAILED -- saving rejects to file drivers/staging/mt7621-pci/pci-mt7621.c.rej patching file drivers/pci/controller/pcie-mt7621.c Applied patch platform/100-PCI-mt7621-Add-MediaTek-MT7621-PCIe-host-controller-.patch (forced; needs refresh) Upon inspecting drivers/staging/mt7621-pci/pci-mt7621.c.rej, it seems that the original patch wants to delete drivers/staging/mt7621-pci/pci-mt7621.c but upstream's version was not an exact match. I opted to delete that file. 5. Suggestion by hauke: torvalds/linux@1909893 "This patch is in upstream kernel, but it was backported to the old staging driver in kernel 5.15." Build system: x86_64 Build-tested: bcm2711/RPi4B, filogic/xiaomi_redmi-router-ax6000-ubootmod Run-tested: bcm2711/RPi4B, filogic/xiaomi_redmi-router-ax6000-ubootmod Signed-off-by: John Audia <therealgraysky@proton.me>
lynxis
pushed a commit
to lynxis/source
that referenced
this pull request
Apr 12, 2023
mt7622/whitebox-v9plus: add factory ip 10.98.11.62/24
openwrt-bot
pushed a commit
that referenced
this pull request
May 20, 2023
Iomega Storcenter ix4-200d is a four-bay SATA NAS powered by a Marvell Kirkwood SoC clocked at 1.2GHz. It has 512MB of RAM and 32MB of flash memory, 3x USB 2.0 and 2x 1Gbit/s NIC Specification: - SoC: Marvell Kirkwood 88F6281 - CPU/Speed: 1200Mhz - Flash size: 32 MiB - RAM: 512MB - LAN: 2x 1Gbit/s - 3x USB 2.0 Notes: - The blue drive LED is triggered by HDD activity, it can not be controlled via GPIO. - The LCD screen requires proprietary code and does not function at this time. - Due to a kernel-related issue with the Marvell 88SE6121 SATA controller, currently only trays numbered #3 and #4 work, #1 and #2 do not. [1] Serial pinout: CN4 -------------- | 10 8 6 4 2 | | 9 7 5 3 1 | -------------- PIN 1 Mark (fat line) 1 = RXD 4 = TXD 6 = GND 9 = 3.3V (not necessary to connect) Installation instructions: 1. download initramfs-uImage and copy into tftp server 2. connect the tftp server to network port #1 3. access uboot environment with serial cable and run setenv mainlineLinux yes setenv arcNumber 1682 setenv console 'console=ttyS0,115200n8' setenv mtdparts 'mtdparts=orion_nand:0x100000@0x000000(u-boot)ro,0x20000@0xA0000(u-boot environment)ro,0x300000@0x100000(kernel),0x1C00000@0x400000(ubi)' setenv bootargs_root 'root=' setenv bootcmd 'setenv bootargs ${console} ${mtdparts} ${bootargs_root}; nand read.e 0x800000 0x100000 0x300000; bootm 0x00800000' saveenv setenv serverip 192.168.1.1 setenv ipaddr 192.168.1.2 tftpboot 0x00800000 [initramfs-uImage filename] bootm 0x00800000 4. connect to LAN on network port #2, log into openwrt and sysupgrade to install into flash [1] https://bugzilla.kernel.org/show_bug.cgi?id=216094 Signed-off-by: Sander van Deijck <sander@vandeijck.com> (aligned FROM from signed-off. LED+key rename, whitespace removal) Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
openwrt-bot
pushed a commit
that referenced
this pull request
Jan 8, 2024
Hardware specification: SoC: MediaTek MT7981B 2x A53 Flash: 16MB NOR RAM: 256MB Ethernet: 2x 10/100/1000 Mbps Switch: MediaTek MT7531AE WiFi: MediaTek MT7976C Button: Reset Power: DC 12V 1A, PoE 802.3af 48V Flash instructions: Option #1 - SSH I was able to SSH into the stock firmware of my device. 1. Attach the router to the network 2. Use scp (-O) to copy the sysupgrade image 3. Connect using SSH and run `sysupgrade -n` Option #2 - U-Boot One way to use the bootloader for flashing is using TFTP: 1. Connect to the router using an ethernet cable 2 Spin up a TFTP server serving the sysupgrade file 3. Open the case and attach a UART 4. Attach power to the router and interrupt the countdown by pressing any key 5. Select option #2 (Upgrade firmware) 6. Enter IP address information and image name 7. Wait patiently Co-Authored-By: Enrique Rodríguez Valencia <enrique.rodriguez@galgus.net> Co-Authored-By: Hauke Mehrtens <hauke@hauke-m.de> Signed-off-by: Leon M. Busch-George <leon@georgemail.eu>
openwrt-bot
pushed a commit
that referenced
this pull request
Mar 11, 2024
Currently, the existing uncompressed kallsym support is causing qualcommax boards to hang on boot, and only after earlycon and verbose BUG() prints are enabled the trace is visible: [ 0.000000] ------------[ cut here ]------------ [ 0.000000] kernel BUG at kernel/kallsyms.c:340! [ 0.000000] Internal error: Oops - BUG: 00000000f2000800 [#1] SMP Felix has fixed up the uncompressed kallsyms support so modify the current patch with the fix. All credits for the code go to Felix. Signed-off-by: Robert Marko <robimarko@gmail.com>
openwrt-bot
pushed a commit
that referenced
this pull request
Mar 28, 2024
Don't add KERNEL_TESTING_PATCHVER yet as there are some issues with it. On TP-Link Archer C2300 serial console seems to stop working after preinit: > Press the [f] key and hit [enter] to enter failsafe mode > Press the [1], [2], [3] or [4] key and hit [enter] to select the de� On Netgear R8000P XHCI causes external abort: [ 2.139586] Internal error: synchronous external abort: 0000000096000210 [#1] SMP [ 2.147212] Modules linked in: xhci_plat_hcd(+) xhci_hcd ohci_platform ohci_hcd fsl_mph_dr_of ehci_platform ehci_fsl ehci_hcd gpio_button_hotplug(O) usbcore nls_base usb_common crc32c_generic [ 2.164774] CPU: 0 PID: 358 Comm: kmodloader Tainted: G O 6.6.22 #0 [ 2.172658] Hardware name: Netgear R8000P (DT) [ 2.177229] pstate: 60400005 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 2.184395] pc : xhci_gen_setup+0x80/0x34c [xhci_hcd] [ 2.189591] lr : xhci_gen_setup+0x74/0x34c [xhci_hcd] [ 2.194788] sp : ffffffc0815d37b0 [ 2.198194] x29: ffffffc0815d37b0 x28: ffffff8002000000 x27: ffffff8001172d88 [ 2.205540] x26: ffffff8002000000 x25: 0000000000000000 x24: ffffffc078b603c0 [ 2.212888] x23: ffffffc078b2a008 x22: ffffff8001172c10 x21: ffffff8002000000 [ 2.220235] x20: ffffff8002000000 x19: ffffff8002000250 x18: 0000000000000000 [ 2.227582] x17: 626d756e20737562 x16: 2064656e67697373 x15: ffffffffffffffff [ 2.234929] x14: ffffff80019e9915 x13: ffffff80019e9913 x12: 00000000ffffffea [ 2.242276] x11: 00000000ffffefff x10: 0000000000000062 x9 : 00000000ffffffd0 [ 2.246760] bcm63138_nand ff801800.nand-controller: timeout waiting for command 0x4 [ 2.249623] x8 : 0000000000000073 x7 : ffffffc0815d37c0 x6 : 0000000000000075 [ 2.257513] bcm63138_nand ff801800.nand-controller: intfc status c00000e0 [ 2.264855] x5 : 0000000000000081 x4 : 0000000000000000 x3 : ffffff8001b61800 [ 2.279193] x2 : ffffffc080b5d000 x1 : ffffff80020003a8 x0 : ffffff8002000398 [ 2.286540] Call trace: [ 2.289048] xhci_gen_setup+0x80/0x34c [xhci_hcd] Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
openwrt-bot
pushed a commit
that referenced
this pull request
Jun 30, 2024
If this function is marked as __init, kernel will splat when driver is (re)bind echo "c080000.ethernet">/sys/bus/platform/drivers/ipqess-edma/unbind echo "c080000.ethernet">/sys/bus/platform/drivers/ipqess-edma/bind Example with additional print messages, functions at boot: [ 2.039468] ipqess-edma c080000.ethernet: ipqess_axi_probe pre register_netdev [ 2.039530] ipqess-edma c080000.ethernet: *netdev: c27d2000 [ 2.045609] ipqess-edma c080000.ethernet: &ipqess_init: c0d1e28c [ 2.051122] ipqess_init [ 2.057338] netdev: c27d2000 [ 2.059492] ess = netdev_priv: c27d2500 [ 2.062615] ess->pdev: c2138c00 [ 2.066174] ess->pdev->dev: c2138c10 [ 2.069314] ess->pdev->dev.of_node: ef6f6368 [ 2.073120] ess->pdev->dev.of_node: /soc/ethernet@c080000 fails (bind) after unbind: [ 34.987948] ipqess-edma c080000.ethernet: ipqess_axi_probe pre register_netdev [ 34.988012] ipqess-edma c080000.ethernet: *netdev: c27d6000 [ 34.994088] ipqess-edma c080000.ethernet: &ipqess_init: c0d1e28c [ 34.999652] 8<--- cut here --- [ 35.005802] Unable to handle kernel paging request at virtual address c0d1e28c when execute [ 35.008676] [c0d1e28c] *pgd=80c1941e(bad) [ 35.016918] Internal error: Oops: 8000000d [#1] SMP ARM Signed-off-by: John Thomson <git@johnthomson.fastmail.com.au> Link: openwrt/openwrt#15831 Signed-off-by: Robert Marko <robimarko@gmail.com>
openwrt-bot
pushed a commit
that referenced
this pull request
Jul 4, 2024
Hardware specification: SoC: MediaTek MT7981B 2x A53 Flash: 16MB NOR RAM: 256MB Ethernet: 2x 10/100/1000 Mbps Switch: MediaTek MT7531AE WiFi: MediaTek MT7976C Button: Reset Power: DC 12V 1A, PoE 802.3af 48V Flash instructions: Option #1 - SSH I was able to SSH into the stock firmware of my device. 1. Attach the router to the network 2. Use scp (-O) to copy the sysupgrade image 3. Connect using SSH and run `sysupgrade -n` Option #2 - U-Boot One way to use the bootloader for flashing is using TFTP: 1. Connect to the router using an ethernet cable 2 Spin up a TFTP server serving the sysupgrade file 3. Open the case and attach a UART 4. Attach power to the router and interrupt the countdown by pressing any key 5. Select option #2 (Upgrade firmware) 6. Enter IP address information and image name 7. Wait patiently Co-Authored-By: Enrique Rodríguez Valencia <enrique.rodriguez@galgus.net> Co-Authored-By: Hauke Mehrtens <hauke@hauke-m.de> Signed-off-by: Leon M. Busch-George <leon@georgemail.eu> (cherry picked from commit b4086f4)
openwrt-bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
Currently, when removing ath11k or any other driver that uses dummy netdev kernel will crash with: [ 365.004961] ------------[ cut here ]------------ [ 365.004992] kernel BUG at net/core/dev.c:10979! [ 365.008642] Internal error: Oops - BUG: 00000000f2000800 [#1] SMP [ 365.012898] Modules linked in: pppoe ppp_async nft_fib_inet nf_flow_table_inet ath11k_ahb(O) ath11k(O) pppox ppp_generic nft_reject_ipv6 nft_reject_ipv4 nft_reject_inet nft_reject nft_redir nft_quota nft_numgen nft_nat nft_masq nft_log nft_limit nft_hash nft_flow_offload nft_fib_c [ 365.064794] CPU: 3 PID: 3896 Comm: procd Tainted: G O 6.6.52 #0 [ 365.087031] Hardware name: QNAP 301w (DT) [ 365.094058] pstate: 20400005 (nzCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 365.098229] pc : free_netdev+0x164/0x1a0 [ 365.104994] lr : free_netdev+0xec/0x1a0 [ 365.109159] sp : ffffffc081d33b90 [ 365.112718] x29: ffffffc081d33b90 x28: ffffff80039d3c00 x27: ffffff800307f000 [ 365.116199] x26: ffffff800538a000 x25: ffffff8005388000 x24: ffffff800538a4c0 [ 365.123317] x23: 00000000000023a4 x22: ffffff8005388f68 x21: ffffff8004e37050 [ 365.130434] x20: ffffff8004e37000 x19: ffffff8004e36ee8 x18: 0000000000000152 [ 365.137552] x17: 63775f357636712e x16: 3030303030646320 x15: ffffffc081436e20 [ 365.144670] x14: ffffff80033f261c x13: 00000000000000d9 x12: 0000000000000002 [ 365.151789] x11: 0000000000000000 x10: 00000000000008a0 x9 : ffffffc081d33980 [ 365.158906] x8 : ffffff80039d4500 x7 : ffffff803fdda6c0 x6 : 0000000000000007 [ 365.166025] x5 : 0000000000000000 x4 : 00000000000000c1 x3 : 00000000000001f4 [ 365.173143] x2 : ffffff803fdd4b78 x1 : ffffff8004e37050 x0 : 0000000000000005 [ 365.180261] Call trace: [ 365.187370] free_netdev+0x164/0x1a0 [ 365.189630] 0xffffffc079b373f0 [ 365.193447] 0xffffffc079b374c0 [ 365.196311] platform_shutdown+0x24/0x34 [ 365.199438] device_shutdown+0x160/0x268 [ 365.203605] kernel_restart+0x40/0xc0 [ 365.207510] __do_sys_reboot+0x104/0x220 [ 365.211070] __arm64_sys_reboot+0x24/0x30 [ 365.215063] invoke_syscall.constprop.0+0x5c/0x108 [ 365.218971] do_el0_svc+0x40/0xc8 [ 365.223655] el0_svc+0x30/0xb8 [ 365.227041] el0t_64_sync_handler+0x120/0x12c [ 365.229995] el0t_64_sync+0x178/0x17c [ 365.234424] Code: f94013f5 a8c37bfd d50323bf d65f03c0 (d4210000) [ 365.238072] ---[ end trace 0000000000000000 ]--- Wireless backports include alloc_netdev_dummy() backport but they dont have the required free_netdev change first, so backport it. Fixes: #16531 Fixes: 384d079 ("mac80211: update to version 6.11") Link: openwrt/openwrt#16549 Signed-off-by: Robert Marko <robimarko@gmail.com>
openwrt-bot
pushed a commit
that referenced
this pull request
Jan 23, 2025
It looks like VRX518 returns phys addr of data buffer in the 'data_ptr' field of the RX descriptor and an actual data offset within the buffer in the 'byte_off' field. In order to map the phys address back to virtual we need the original phys address of the allocated buffer. In the same driver applies offset to phys address before the mapping, what leads to WARN_ON triggering in plat_mem_virt() function with subsequent kernel panic: WARNING: CPU: 0 PID: 0 at .../sw_plat.c:764 0xbf306cd0 [vrx518_tc@8af9f5d0+0x25000] ... Unable to handle kernel NULL pointer dereference at virtual address 00000000 pgd = aff5701e [00000000] *pgd=00000000 Internal error: Oops: 5 [#1] SMP ARM Noticed in ATM mode, when chip always returns byte_off = 4. In order to fix the issue, pass the phys address to plat_mem_virt() as is and apply byte_off later for proper DMA syncing and on mapped virtual address when copying RXed data into the skb. Run tested with FRITZ!Box 7530 on both ADSL and VDSL (thanks Jan) links. Fixes: 474bbe2 ("kernel: add Intel/Lantiq VRX518 TC driver") Tested-by: Jan Hoffmann <jan@3e8.eu> # VDSL link Reported-and-tested-by: nebibigon93@yandex.ru # ADSL link Signed-off-by: Sergey Ryazanov <ryazanov.s.a@gmail.com> Link: https://patchwork.ozlabs.org/project/openwrt/patch/20250122222654.21833-2-ryazanov.s.a@gmail.com/ Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
openwrt-bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
It looks like VRX518 returns phys addr of data buffer in the 'data_ptr' field of the RX descriptor and an actual data offset within the buffer in the 'byte_off' field. In order to map the phys address back to virtual we need the original phys address of the allocated buffer. In the same driver applies offset to phys address before the mapping, what leads to WARN_ON triggering in plat_mem_virt() function with subsequent kernel panic: WARNING: CPU: 0 PID: 0 at .../sw_plat.c:764 0xbf306cd0 [vrx518_tc@8af9f5d0+0x25000] ... Unable to handle kernel NULL pointer dereference at virtual address 00000000 pgd = aff5701e [00000000] *pgd=00000000 Internal error: Oops: 5 [#1] SMP ARM Noticed in ATM mode, when chip always returns byte_off = 4. In order to fix the issue, pass the phys address to plat_mem_virt() as is and apply byte_off later for proper DMA syncing and on mapped virtual address when copying RXed data into the skb. Run tested with FRITZ!Box 7530 on both ADSL and VDSL (thanks Jan) links. Fixes: 474bbe2 ("kernel: add Intel/Lantiq VRX518 TC driver") Tested-by: Jan Hoffmann <jan@3e8.eu> # VDSL link Reported-and-tested-by: nebibigon93@yandex.ru # ADSL link Signed-off-by: Sergey Ryazanov <ryazanov.s.a@gmail.com> Link: https://patchwork.ozlabs.org/project/openwrt/patch/20250122222654.21833-2-ryazanov.s.a@gmail.com/ Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> (cherry picked from commit 7bd5796)
openwrt-bot
pushed a commit
that referenced
this pull request
Jun 19, 2025
Add missing function reference for the l2_hash_seed call in rtl931x_reg in the rtl83xx DSA driver part. While at it, rename the referenced function to proper naming convention and simplify its content. The missing reference causes a hard crash after a short time (on MS510TXM) because the driver assumes the reference always exists. [ 111.785559] CPU 0 Unable to handle kernel paging request at virtual address 00000000, epc == 00000000, ra == 805469a0 [ 111.800991] Oops[#1]: [ 111.801026] CPU: 0 PID: 11 Comm: kworker/u8:0 Tainted: G O 6.12.33 #0 [ 111.801046] Workqueue: dsa_ordered dsa_slave_switchdev_event_work ... [ 111.880600] epc : 00000000 0x0 [ 111.884219] ra : 805469a0 rtl83xx_port_fdb_add+0x7c/0x204 [ 111.890570] Status: 11000403 KERNEL EXL IE [ 111.895263] Cause : 50800008 (ExcCode 02) [ 111.899731] BadVA : 00000000 [ 111.902946] PrId : 0001a120 (MIPS interAptiv (multi)) [ 111.956086] Process kworker/u8:0 (pid: 11, threadinfo=0b107c25, task=265aeb31, tls=00000000) ... [ 112.015167] Call Trace: [ 112.019549] [<80170b04>] load_balance+0x494/0x708 [ 112.025022] [<807bb368>] dsa_port_do_fdb_add+0x24c/0x340 [ 112.031048] [<807bc868>] dsa_switch_event+0xd44/0x13cc [ 112.036845] [<8015867c>] raw_notifier_call_chain+0x48/0x88 [ 112.043031] [<807bcf3c>] dsa_tree_notify+0x10/0x3c [ 112.048395] [<807b2a64>] dsa_port_bridge_host_fdb_add+0x15c/0x190 [ 112.055459] [<807b4e40>] dsa_slave_switchdev_event_work+0x164/0x1cc ... Signed-off-by: Jonas Jelonek <jelonek.jonas@gmail.com> Link: openwrt/openwrt#19170 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
openwrt-bot
pushed a commit
that referenced
this pull request
Jul 19, 2025
The ix4-200d is a 4 bay NAS supported since OpenWrt 23.05. Drive trays controller. Due to a kernel-related issue with the SATA controller, trays #1 and #2 were not recognized. This issue has been fixed in kernel 6.10, so with the adoption of kernel 6.12 in the Kirkwood target trays #1 and #2 can now be made accessible. This requires the kmod-ata-ahci package, which this commit adds as default to the makefile. Signed-off-by: Sander van Deijck <sander@vandeijck.com> Link: openwrt/openwrt#19435 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
openwrt-bot
pushed a commit
that referenced
this pull request
Aug 17, 2025
Booting Realtek switches via TFTP will have a chance of ~5% to fail with the following dump on SMP devices. Sample taken from RTL931x. [ 1.318320] rtl931x_chip_init: init ENCAP done [ 1.323360] rtl931x_chip_init: init MIB done [ 1.328337] rtl931x_chip_init: init ACL done [ 1.333219] rtl931x_chip_init: init ALE done [ 1.344307] CPU 0 Unable to handle kernel paging request at virtual address 00000000, epc == 00000000, ra == 806c5c4c [ 1.356418] Oops[#1]: [ 1.359067] CPU: 0 UID: 0 PID: 1 Comm: swapper/0 Not tainted 6.12.40 #0 [ 1.366582] Hardware name: Linksys LGS352C [ 1.371226] $ 0 : 00000000 00000001 00000000 80b6cc44 [ 1.377179] $ 4 : 836b0540 00000000 00000000 83011d38 [ 1.383119] $ 8 : 00000000 ffffefff 00000001 80b08c08 [ 1.389071] $12 : ffffffea 83011d34 00000072 00000558 [ 1.395060] $16 : 836b0540 00000000 00000100 83011ebf [ 1.401003] $20 : 83011ec0 83011ec8 ffff8b3c 80b00000 [ 1.406984] $24 : 00000000 80b08c38 [ 1.412922] $28 : 83038000 83011e70 82fb37a0 806c5c4c [ 1.418888] Hi : 0000014b [ 1.422201] Lo : c74d8000 [ 1.425490] epc : 00000000 0x0 [ 1.429191] ra : 806c5c4c __napi_poll+0x4c/0x208 [ 1.434728] Status: 11000403 KERNEL EXL IE [ 1.439497] Cause : 50800008 (ExcCode 02) [ 1.444040] BadVA : 00000000 [ 1.447330] PrId : 0001a120 (MIPS interAptiv (multi)) [ 1.453157] Modules linked in: [ 1.456641] Process swapper/0 (pid: 1, threadinfo=(ptrval), task=(ptrval), tls=00000000) [ 1.465742] Stack : 82faf248 80a8d558 817ed500 ffff8b3a 836b0540 8066a348 82fb2bc0 836b0540 [ 1.475209] 82fb3600 00000100 0000012c 806c6274 00000000 00000017 00000002 80196134 [ 1.484701] 80b00000 83011ed0 83011eb8 83011e00 83011ec0 83011ec0 83011ec8 83011ec8 [ 1.494233] 00000001 81920000 81920000 80aefe4c 836b0000 00000000 00000000 00000001 [ 1.503686] 00000100 00000000 83011f20 80aefde0 00000000 8019ac14 80b01550 00000000 [ 1.513144] ... [ 1.515957] Call Trace: [ 1.515996] [ 1.520458] [<8066a348>] rtl93xx_net_irq+0x1a4/0x1ac [ 1.526116] [<806c6274>] net_rx_action+0x18c/0x360 [ 1.531576] [<80196134>] __handle_irq_event_percpu+0x58/0x16c [ 1.538111] [<8019ac14>] handle_level_irq+0x1e0/0x1f4 [ 1.543870] [<80133588>] handle_softirqs+0x14c/0x2ec [ 1.549488] [<801339e4>] irq_exit+0x84/0xb4 [ 1.554183] [<805527dc>] plat_irq_dispatch+0x90/0xdc [ 1.559764] [<801019f0>] except_vec_vi_end+0xc4/0xd0 [ 1.565337] A network interrupt may be received before the device is setup properly. In this case NAPI structures are missing and __napi_poll() will find a NULL pointer in n->poll. Avoid this by registering the device after initialization is complete. Signed-off-by: Markus Stockhausen <markus.stockhausen@gmx.de> Link: openwrt/openwrt#19787 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
openwrt-bot
pushed a commit
that referenced
this pull request
Sep 7, 2025
The receive path of the RTL93xx SoCs is currently discarding packets in software. Analysis gives the following explanation: - RX ring size registers are setup with the full software ring size - When packets are received the packet counter registers are increased - After RX processing the counter registers are changed the wrong way - From then SOC is allowed to receive more packets than software allows - Overflow interrupts are fired - As a reaction to that the software drops packets Change the processing as follows: - Setup ring size registers with a headroom of 2 buffers - Decrease the counter registers with the real work done With this change no more overflow interrupts occur because the SoC disables the queues before they can overflow or hit a buffer that is still owned by the CPU. Benchmark from single stream iperf3 run, with server process running on ZyXEL XGS1210 (RTL930x). iperf3 run before ----------------------------------------------------------- Server listening on 5201 (test #1) ----------------------------------------------------------- Accepted connection from 192.168.2.86, port 54412 [ 5] local 192.168.2.71 port 5201 connected to 192.168.2.86 port 54418 [ ID] Interval Transfer Bitrate [ 5] 0.00-1.00 sec 384 KBytes 3.14 Mbits/sec [ 5] 1.00-2.00 sec 0.00 Bytes 0.00 bits/sec [ 5] 2.00-3.00 sec 0.00 Bytes 0.00 bits/sec [ 5] 3.00-4.01 sec 5.12 MBytes 42.8 Mbits/sec [ 5] 4.01-5.00 sec 11.4 MBytes 95.8 Mbits/sec [ 5] 5.00-6.00 sec 0.00 Bytes 0.00 bits/sec [ 5] 6.00-7.00 sec 0.00 Bytes 0.00 bits/sec [ 5] 7.00-8.00 sec 0.00 Bytes 0.00 bits/sec [ 5] 8.00-9.00 sec 0.00 Bytes 0.00 bits/sec [ 5] 9.00-10.00 sec 0.00 Bytes 0.00 bits/sec iperf3 run after ----------------------------------------------------------- Server listening on 5201 (test #1) ----------------------------------------------------------- Accepted connection from 192.168.2.86, port 55228 [ 5] local 192.168.2.71 port 5201 connected to 192.168.2.86 port 55232 [ ID] Interval Transfer Bitrate [ 5] 0.00-1.00 sec 22.8 MBytes 191 Mbits/sec [ 5] 1.00-2.01 sec 25.4 MBytes 211 Mbits/sec [ 5] 2.01-3.00 sec 25.4 MBytes 215 Mbits/sec [ 5] 3.00-4.01 sec 26.5 MBytes 220 Mbits/sec [ 5] 4.01-5.00 sec 26.2 MBytes 222 Mbits/sec [ 5] 5.00-6.00 sec 26.9 MBytes 225 Mbits/sec [ 5] 6.00-7.00 sec 27.0 MBytes 226 Mbits/sec [ 5] 7.00-8.01 sec 26.9 MBytes 224 Mbits/sec [ 5] 8.01-9.00 sec 26.5 MBytes 223 Mbits/sec [ 5] 9.00-10.00 sec 26.8 MBytes 225 Mbits/sec [ 5] 10.00-10.02 sec 640 KBytes 224 Mbits/sec Signed-off-by: Markus Stockhausen <markus.stockhausen@gmx.de> Link: openwrt/openwrt#19960 Signed-off-by: Robert Marko <robimarko@gmail.com>
openwrt-bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
Fix kernel panic caused by downstream PHY_DETACH_NO_HW_RESET patch. [ 20.994001] airoha_eth 1fb50000.ethernet wan: validation of usxgmii with support 00,00000000,00000000,00006000 and advertisement 00,00000000,00000000,00006000 failed: -EINVAL [ 21.058106] Unable to handle kernel access to user memory outside uaccess routines at virtual address 00000000000000b8 [ 21.068879] Mem abort info: [ 21.071684] ESR = 0x0000000096000005 [ 21.075436] EC = 0x25: DABT (current EL), IL = 32 bits [ 21.080790] SET = 0, FnV = 0 [ 21.083854] EA = 0, S1PTW = 0 [ 21.086997] FSC = 0x05: level 1 translation fault [ 21.091931] Data abort info: [ 21.094829] ISV = 0, ISS = 0x00000005, ISS2 = 0x00000000 [ 21.100359] CM = 0, WnR = 0, TnD = 0, TagAccess = 0 [ 21.105419] GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0 [ 21.110762] user pgtable: 4k pages, 39-bit VAs, pgdp=0000000091bc8000 [ 21.117218] [00000000000000b8] pgd=0800000084ee9003, p4d=0800000084ee9003, pud=0800000084ee9003, pmd=0000000000000000 [ 21.127892] Internal error: Oops: 0000000096000005 [#1] SMP [ 21.133483] Modules linked in: pppoe ppp_async nft_fib_inet nf_flow_table_inet pppox ppp_generic nft_reject_ipv6 nft_reject_ipv4 nft_reject_inet nft_reject nft_redir nft_quota nft_numgen nft_nat nft_masq nfte [ 21.191941] CPU: 3 UID: 0 PID: 1882 Comm: netifd Tainted: G O 6.12.57 #0 [ 21.200046] Tainted: [O]=OOT_MODULE [ 21.203534] Hardware name: Gemtek W1700K (DT) [ 21.207892] pstate: 60400005 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 21.214861] pc : phy_detach+0xe8/0x194 [ 21.218628] lr : phy_detach+0xe4/0x194 [ 21.222387] sp : ffffffc0823ebae0 [ 21.225702] x29: ffffffc0823ebae0 x28: ffffff8005451c00 x27: 0000000000000000 [ 21.232846] x26: 0000000000000000 x25: 0000000000001003 x24: ffffffc080cf8240 [ 21.239990] x23: 0000000000001002 x22: ffffff807fc527f8 x21: ffffffc080c93318 [ 21.247125] x20: ffffff8001cfc000 x19: ffffff80036f7000 x18: ffffff8012cde323 [ 21.254269] x17: 303a302d30333537 x16: 000000000000000e x15: 0000005139b64de4 [ 21.261413] x14: 0000000000000001 x13: ffffff80020b46c0 x12: 0000000000000001 [ 21.268550] x11: ffffff80020b46c0 x10: ffffff8005451cc0 x9 : ffffff807dbf5200 [ 21.275694] x8 : ffffff80020b46c0 x7 : ffffff80010a8ed0 x6 : 0000000000000000 [ 21.282838] x5 : 00000000000013f8 x4 : 0000000000000000 x3 : ffffff8005451c00 [ 21.289983] x2 : 0000000000000000 x1 : ffffff8005451c00 x0 : 0000000000000000 [ 21.297128] Call trace: [ 21.299575] phy_detach+0xe8/0x194 [ 21.302988] phylink_fwnode_phy_connect+0x194/0x1c0 [ 21.307874] phylink_of_phy_connect+0x18/0x20 [ 21.312248] airoha_dev_open+0x44/0x2b0 [ 21.316094] __dev_open+0xe8/0x15c [ 21.319505] __dev_change_flags+0x154/0x1c0 [ 21.323698] dev_change_flags+0x20/0x64 [ 21.327541] dev_ifsioc+0x28c/0x444 [ 21.331032] dev_ioctl+0x290/0x4b8 [ 21.334434] sock_ioctl+0x31c/0x444 [ 21.337923] __arm64_sys_ioctl+0x354/0xe60 [ 21.342020] invoke_syscall.constprop.0+0x58/0xec [ 21.346725] do_el0_svc+0x3c/0xd4 [ 21.350041] el0_svc+0x18/0x60 [ 21.353097] el0t_64_sync_handler+0x118/0x124 [ 21.357455] el0t_64_sync+0x150/0x154 Make sure the phydev have a driver before asserting a signal or we would dereference a NULL address. Signed-off-by: Balázs Triszka <info@balika011.hu> [ improve commit description ] Link: openwrt/openwrt#20740 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup ZBT-WE826 support: