Merge branch develop into main [20220818] #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* With creation of develop, main will not see frequent changes. * main can be covered by the release pipeline alone.
* Increment post-v0.8.0 release. * The idea is to be able to always differentiate between released and development versions. * We have some flexibility now, while in preview phase. If the next release needs major version increase, then we can and will do it just before releasing. The challenge is once we are stable, whether to know if the next release will contain only bug fixes or features also (patch version vs. minor version change).
* Ensure user provided generator if used
* Instead of cherry-picks that can cause conflicts later, or worse, ignored changes, created a patch branch from a common ancestor (git merge-base main develop) and cherry-picked changes onto this branch instead. * This patch branch will then be merged to develop and main.
* With the constructor being private, clients are unable to create the download object to pass as the out param. * Fix: Use std::unique_ptr as the out param instead.
* Without this, Clang complains about "exception specification of overriding function is more lax than base version"
SDK: nothrow API fixes, tests, noexcept
* Before enabling signed binaries on Linux, this is a small step towards helping customers verify the integrity of our binaries. * Packages published to public repositories are indirectly signed since the repo manifest is signed.
* Temporary workaround for Chromium/Edge running on 19H1 or lower Windows versions. * CV and integrity check info is not mandatory for this use case, ok to ignore errors. Chromium/Edge performs its own hash check after download is complete.
* Default image has moved to windows-2022 which has VS2022 installed by default instead of VS2019. We have not yet tested builds with VS2022, so go back to windows-2019 for now. See actions/runner-images#4856.
* Quick workaround: Include prefixes from the predictable naming scheme of systemd. * Future: Look at ifa_flags or something else that is more deterministic than interface names.
* Shorter timeouts ensure timely fallback from MCC to original/CDN source. Also helps CDN downloads since curl's default connect timeout of 300s is too long. * Expand mcc fatal errors and increase ban time. This ensures subsequent are saved from paying the (short) timeout cost. * MCC can be banned for all hosts and per host: this is needed to satisfy the fact that MCC can either be unreachable (applies to all hosts) or is reachable but doesn't support some hosts/content.
* Unused local variable in release build in do_log.cpp. * Incorrect format specifier for uint64_t. * Unused method TimeOperation.
* Removed some details from the public do_errors.h file that were meant for internal use only. * do_error_macros.h was also meant for internal use only. It has been moved and renamed to do_error_helpers.h. * Fix some build warnings related to switch statement, print format specifiers, and narrowing conversions.
* Maintaining both the exceptions model and error return model for reporting errors is unnecessary and adds maintenance overhead. The error return model was chosen as the lowest common denominator. * The throwing methods are deleted from the public API surface and the 'nothrow' suffix removed from the remaining methods. * The plugin-apt project is updated to use the error return model.
shishirb-MSFT
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.