feat(reporter): Add github action reporter.#9191
Merged
mxschmitt merged 24 commits intoOct 4, 2021
Merged
Conversation
…sAnnotations * upstream/master: browser(webkit): disable COOP support (microsoft#9185) fix(test runner): proper serial mode with beforeAll/afterAll failures (microsoft#9183) chore: remove browserType.connect from .net - not yet ready (microsoft#9182) test: canvas updates are reflected on screenshots (microsoft#9180) chore: dedupe return types in the dotnet api generator (microsoft#9181) docs: mention empty string in `userDataDir` (microsoft#9069) feat(expect): toContainText(array) (microsoft#9160) chore: enable object-curly-spacing in ESLint (microsoft#9168) feat(chromium): roll to r925110 (microsoft#9175) chore: render expect in trace viewer (microsoft#9141) devops: use Node.js 16 when rolling browsers docs(python): add docs about threading (microsoft#8829) browser(chromium): roll to r925110 (microsoft#9171) chore(test-runner): launch -> webServer (microsoft#9167) docs: cleanup test.describe.parallel.only doc (microsoft#9159)
Member
|
This looks great! Start with my last comment as it is the most high level. |
Contributor
Author
|
@pavelfeldman I can get started with the tests if the current architecture is fine. |
pavelfeldman
approved these changes
Sep 29, 2021
mxschmitt
reviewed
Sep 29, 2021
Member
|
Happy to merge it, but I think it conflicts with your other change! |
…tionWithBaseChange * upstream/master: (21 commits) fix(test runner): do not write missing snapshot until the last retry (microsoft#9246) feat(reporters): Add error position to JSON Report (microsoft#9151) feat(fetch): import/export storageState (microsoft#9244) fix: allow binary response interception (microsoft#9236) test(cookies): add a test for SameSite=None cookies (microsoft#9242) feat(webkit): roll WebKit to 1550 (microsoft#9239) test: add test for downloading PDF files (microsoft#9235) fix: leaking route handlers when times is used in Page.route (microsoft#9234) chore: upgrade commander.js to version 8 (microsoft#9230) feat(fetch): store cookies between requests (microsoft#9221) fix(selenium connect): register in gracefullyCloseAll for driver cleanup (microsoft#9218) fix(toBeHidden): return true to missing elements (microsoft#9205) chore: fix PlaywrightClient disconnection logic (microsoft#9149) fix(expect): beautiful expect stacks (microsoft#9204) feat(fetch): support ignoreHTTPSErrors option (microsoft#9206) feat(api): introduce locator.waitFor (microsoft#9200) feat(fetch): send Playwright as default user-agent for global fetch (microsoft#9195) feat(test runner): collect test error from worker teardown (microsoft#9190) test: add tests for Cross-Origin-Opener-Policy navigation (microsoft#9184) test: get response body for COOP responses (microsoft#9196) ...
Contributor
Author
|
@pavelfeldman should we try enabling the reporter for this repo? |
Member
Sure, as a separate change. Windows Test Runner bot looks unhappy, the rest errors are unrelated, we are sorting them out. |
…tionWithBaseChange * upstream/master: chore: roll Electron to 12.2.1 (microsoft#9271) test: use separate Playwright instance to automate inspector (microsoft#9270) feat(inspector): use chrome/msedge when chromium is not available (microsoft#9269) fix(webkit): deduce response mime type from content-type (microsoft#9264) fix(fetch): use data, form and multipart for different post data (microsoft#9248) chore: split ContextRecorder from inspector (microsoft#9250) feat: add path option to `toMatchSnapshot` (microsoft#9156) feat(cli): Support trace file URLs (microsoft#9030) browser(webkit): roll to 23/09/21 (microsoft#9107) feat(chromium): roll to r926934 (microsoft#9259) browser(chromium): roll to r926934 (microsoft#9255) test: fix 'should fulfill with fetch result and overrides' test (microsoft#9252) feat(test-runner): add reuse context mode to share a single context between tests (microsoft#9115) fix(docs): test-runner location column type (microsoft#9222)
Contributor
Author
|
Oops, thought windows failure was part of the flakyness, so didn't check the details. |
mxschmitt
approved these changes
Oct 4, 2021
Contributor
|
Thank you @sidharthv96! Next step would be probably to automatically add it as a reporter in the default configuration if the |
sidharthv96
added a commit
to sidharthv96/playwright
that referenced
this pull request
Oct 4, 2021
* upstream/master: fix(create-playwright): add extra -- for the debug script (microsoft#9257) feat(test-runner): Add GitHub Actions reporter (microsoft#9191) fix: installation with folders which contain spaces (microsoft#9275)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related discussion: #9155
Fixes: #9147
@pavelfeldman This fixes the duplication issues.
TODO: