Skip to content

Fix include_tmax not considered in mne.io.Raw.crop to check tmax in bounds #11204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
larsoner merged 6 commits into from
Sep 26, 2022
Merged

Fix include_tmax not considered in mne.io.Raw.crop to check tmax in bounds #11204

larsoner merged 6 commits into from
Sep 26, 2022
+17 −2

Conversation

@gemeinl
Copy link
Contributor

@gemeinl gemeinl commented Sep 26, 2022 •
edited by larsoner
Loading

Closes #11196

larsoner
larsoner reviewed Sep 26, 2022
View reviewed changes
@larsoner larsoner added this to the 1.2 milestone Sep 26, 2022
@larsoner larsoner enabled auto-merge (squash) September 26, 2022 13:06
@larsoner larsoner disabled auto-merge September 26, 2022 13:06
@larsoner larsoner enabled auto-merge (squash) September 26, 2022 13:06
@larsoner larsoner merged commit de546e2 into mne-tools:main Sep 26, 2022
@agramfort
Copy link
Member

agramfort commented Sep 26, 2022

thanks a lot @gemeinl !

larsoner added a commit to drammock/mne-python that referenced this pull request Sep 28, 2022
@larsoner
Merge remote-tracking branch 'upstream/main' into fix-mesh-display
c5b4198 
* upstream/main:
  MAINT: Fix CircleCI error (mne-tools#11205) [circle deploy]
  Add regression-based approach to removing EOG artifacts (mne-tools#11046)
  [DOC, MRG] Minor documentation improvements and remove glossary entry for array-like (mne-tools#11207)
  Fix `include_tmax` not considered in `mne.io.Raw.crop` to check `tmax` in bounds (mne-tools#11204)
  MAINT: Fix notebook backend (mne-tools#11206)
  MRG: Fix displayed Raw duration in Jupyter notebook (mne-tools#11203)
  add EpochsSpectrum.average() (mne-tools#11198)
larsoner added a commit to alexrockhill/mne-python that referenced this pull request Sep 28, 2022
@larsoner
Merge remote-tracking branch 'upstream/main' into stc
e1414ad 
* upstream/main:
  MAINT: Fix CircleCI error (mne-tools#11205) [circle deploy]
  Add regression-based approach to removing EOG artifacts (mne-tools#11046)
  [DOC, MRG] Minor documentation improvements and remove glossary entry for array-like (mne-tools#11207)
  Fix `include_tmax` not considered in `mne.io.Raw.crop` to check `tmax` in bounds (mne-tools#11204)
  MAINT: Fix notebook backend (mne-tools#11206)
  MRG: Fix displayed Raw duration in Jupyter notebook (mne-tools#11203)
  add EpochsSpectrum.average() (mne-tools#11198)
  reduce memory [circle deploy] (mne-tools#11199)
  [BUG, MRG] Fix bug in find_bads_muscle (mne-tools#11197)
  BUG: Fix bug with long legend labels (mne-tools#11181)
larsoner added a commit to drammock/mne-python that referenced this pull request Sep 28, 2022
@larsoner
Merge remote-tracking branch 'upstream/main' into standardize-topomap…
0267853 
…-args

* upstream/main:
  Fix mesh display in tutorial (mne-tools#11200)
  MAINT: Add arm64 CI using CirrusCI (mne-tools#11209)
  Fix spatial colors (mne-tools#11201)
  MAINT: Fix CircleCI error (mne-tools#11205) [circle deploy]
  Add regression-based approach to removing EOG artifacts (mne-tools#11046)
  [DOC, MRG] Minor documentation improvements and remove glossary entry for array-like (mne-tools#11207)
  Fix `include_tmax` not considered in `mne.io.Raw.crop` to check `tmax` in bounds (mne-tools#11204)
  MAINT: Fix notebook backend (mne-tools#11206)
  MRG: Fix displayed Raw duration in Jupyter notebook (mne-tools#11203)
  add EpochsSpectrum.average() (mne-tools#11198)
larsoner added a commit to larsoner/mne-python that referenced this pull request Oct 11, 2022
@larsoner
Merge remote-tracking branch 'upstream/main' into fix_fnirschannelmerge
6f62a9d 
* upstream/main: (64 commits)
  MAINT: Better check (mne-tools#11229)
  MAINT: Fix link and update instantiation note (mne-tools#11228)
  BUG: Add estimated fiducials when missing / assumed head coords (mne-tools#11212)
  Fix tfr db (mne-tools#11223)
  MAINT: Update link (mne-tools#11222)
  add CPGRL doc section (mne-tools#11216)
  Don't insert superfluous newlines in subprocess log messages (mne-tools#11219)
  purge _get_args helper func (mne-tools#11215)
  Standardize topomap args (mne-tools#11123)
  MAINT: Ensure no datasets are downloaded in tests (mne-tools#11213)
  MAINT: Fix Cirrus caching (mne-tools#11211)
  Fix mesh display in tutorial (mne-tools#11200)
  MAINT: Add arm64 CI using CirrusCI (mne-tools#11209)
  Fix spatial colors (mne-tools#11201)
  MAINT: Fix CircleCI error (mne-tools#11205) [circle deploy]
  Add regression-based approach to removing EOG artifacts (mne-tools#11046)
  [DOC, MRG] Minor documentation improvements and remove glossary entry for array-like (mne-tools#11207)
  Fix `include_tmax` not considered in `mne.io.Raw.crop` to check `tmax` in bounds (mne-tools#11204)
  MAINT: Fix notebook backend (mne-tools#11206)
  MRG: Fix displayed Raw duration in Jupyter notebook (mne-tools#11203)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larsoner larsoner larsoner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.2

Development

Successfully merging this pull request may close these issues.

include_tmax not considered in mne.io.Raw.crop to check tmax in bounds

3 participants

@gemeinl @agramfort @larsoner