-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix tfr db #11223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tfr db #11223
Conversation
I was wrong about this. They're only combined as (so the |
|
maybe just wrap with |
|
Thanks in advance @drammock , marking for auto merge |
* upstream/main: (64 commits) MAINT: Better check (mne-tools#11229) MAINT: Fix link and update instantiation note (mne-tools#11228) BUG: Add estimated fiducials when missing / assumed head coords (mne-tools#11212) Fix tfr db (mne-tools#11223) MAINT: Update link (mne-tools#11222) add CPGRL doc section (mne-tools#11216) Don't insert superfluous newlines in subprocess log messages (mne-tools#11219) purge _get_args helper func (mne-tools#11215) Standardize topomap args (mne-tools#11123) MAINT: Ensure no datasets are downloaded in tests (mne-tools#11213) MAINT: Fix Cirrus caching (mne-tools#11211) Fix mesh display in tutorial (mne-tools#11200) MAINT: Add arm64 CI using CirrusCI (mne-tools#11209) Fix spatial colors (mne-tools#11201) MAINT: Fix CircleCI error (mne-tools#11205) [circle deploy] Add regression-based approach to removing EOG artifacts (mne-tools#11046) [DOC, MRG] Minor documentation improvements and remove glossary entry for array-like (mne-tools#11207) Fix `include_tmax` not considered in `mne.io.Raw.crop` to check `tmax` in bounds (mne-tools#11204) MAINT: Fix notebook backend (mne-tools#11206) MRG: Fix displayed Raw duration in Jupyter notebook (mne-tools#11203) ...
closes #11091
after reading through the TFR code, to me it seems that #10978 introduced a mistake. Specifically, the changed coef here:
mne-python/mne/time_frequency/tfr.py
Lines 2439 to 2440 in 7127158
is only appropriate for complex data (which have been converted to real-valued amplitude a few lines above). Data that is already real-valued will be power, not amplitude, and so should have coef
10not20in the dB conversion.My only hesitation is the case of
avg_power_itcwhere the data will be complex, but the complex part is ITC, so it seems like the test ofif np.iscomplexobjis too coarse here:mne-python/mne/time_frequency/tfr.py
Lines 2413 to 2414 in 7127158
...and data in the form
avg_power_itcneeds to be special-cased to simply discard the imaginary part and get treated like the (non-complex) power cases. @alexrockhill @agramfort @larsoner since you three authored/reviewed #10978 can you confirm that I'm interpreting the code correctly here and that what I've said makes sense?