Skip to content

MAINT: Fix CircleCI error #11205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
drammock merged 13 commits into from
Sep 27, 2022
Merged

MAINT: Fix CircleCI error #11205

drammock merged 13 commits into from
Sep 27, 2022

Conversation

@larsoner
Copy link
Member

@larsoner larsoner commented Sep 26, 2022 •
edited
Loading

  • Replicate error with [circle full]
  • Switch to PyQt6, see problem with report + Qt browser not clearing all instances
  • Fix problem with clearing instances
  • Merge BUG: Fix ref bug using weakref mne-qt-browser#145
  • Cut mne-qt-browser release
  • Add conditionals here for version assertions based on mne-qt-browser version
  • Remove use of custom mne-qt-browser branch in tests here

@larsoner larsoner mentioned this pull request Sep 26, 2022
Merged
@larsoner larsoner added this to the 1.2 milestone Sep 26, 2022
@larsoner
Copy link
Member Author

larsoner commented Sep 26, 2022

Okay the commit above shows failures on Azure, CircleCI, and GH Actions regarding reference cleanup. I'll try changing CIs to use mne-tools/mne-qt-browser#145

@larsoner
Copy link
Member Author

larsoner commented Sep 26, 2022

Some good news @drammock it at least gets past the previously failing tutorial on this PR:

https://app.circleci.com/pipelines/github/mne-tools/mne-python/16584/workflows/ce28aaf3-a2ef-49c5-94d3-32d13bcf0b08/jobs/49574

So I think once we cut a mne-qt-browser release and merge this PR things then the CircleCI main builds might work again

@larsoner larsoner marked this pull request as ready for review September 27, 2022 17:45
@larsoner
Copy link
Member Author

larsoner commented Sep 27, 2022

@drammock feel free to merge if you're happy. Bonus points for adding [circle deploy] to the message so we find out in 2h if it actually worked.

In the end the fixes were to switch 1) to PyQt6 (from PySide6) to deal with the weird xcb error, and 2) to CircleCI machine medium+ from medium (the default) to have 2GB more memory.

@drammock drammock merged commit 35e466f into mne-tools:main Sep 27, 2022
@larsoner larsoner deleted the check branch September 27, 2022 19:09
larsoner added a commit to drammock/mne-python that referenced this pull request Sep 28, 2022
@larsoner
Merge remote-tracking branch 'upstream/main' into fix-mesh-display
c5b4198 
* upstream/main:
  MAINT: Fix CircleCI error (mne-tools#11205) [circle deploy]
  Add regression-based approach to removing EOG artifacts (mne-tools#11046)
  [DOC, MRG] Minor documentation improvements and remove glossary entry for array-like (mne-tools#11207)
  Fix `include_tmax` not considered in `mne.io.Raw.crop` to check `tmax` in bounds (mne-tools#11204)
  MAINT: Fix notebook backend (mne-tools#11206)
  MRG: Fix displayed Raw duration in Jupyter notebook (mne-tools#11203)
  add EpochsSpectrum.average() (mne-tools#11198)
larsoner added a commit to alexrockhill/mne-python that referenced this pull request Sep 28, 2022
@larsoner
Merge remote-tracking branch 'upstream/main' into stc
e1414ad 
* upstream/main:
  MAINT: Fix CircleCI error (mne-tools#11205) [circle deploy]
  Add regression-based approach to removing EOG artifacts (mne-tools#11046)
  [DOC, MRG] Minor documentation improvements and remove glossary entry for array-like (mne-tools#11207)
  Fix `include_tmax` not considered in `mne.io.Raw.crop` to check `tmax` in bounds (mne-tools#11204)
  MAINT: Fix notebook backend (mne-tools#11206)
  MRG: Fix displayed Raw duration in Jupyter notebook (mne-tools#11203)
  add EpochsSpectrum.average() (mne-tools#11198)
  reduce memory [circle deploy] (mne-tools#11199)
  [BUG, MRG] Fix bug in find_bads_muscle (mne-tools#11197)
  BUG: Fix bug with long legend labels (mne-tools#11181)
larsoner added a commit to drammock/mne-python that referenced this pull request Sep 28, 2022
@larsoner
Merge remote-tracking branch 'upstream/main' into standardize-topomap…
0267853 
…-args

* upstream/main:
  Fix mesh display in tutorial (mne-tools#11200)
  MAINT: Add arm64 CI using CirrusCI (mne-tools#11209)
  Fix spatial colors (mne-tools#11201)
  MAINT: Fix CircleCI error (mne-tools#11205) [circle deploy]
  Add regression-based approach to removing EOG artifacts (mne-tools#11046)
  [DOC, MRG] Minor documentation improvements and remove glossary entry for array-like (mne-tools#11207)
  Fix `include_tmax` not considered in `mne.io.Raw.crop` to check `tmax` in bounds (mne-tools#11204)
  MAINT: Fix notebook backend (mne-tools#11206)
  MRG: Fix displayed Raw duration in Jupyter notebook (mne-tools#11203)
  add EpochsSpectrum.average() (mne-tools#11198)
larsoner added a commit to larsoner/mne-python that referenced this pull request Oct 11, 2022
@larsoner
Merge remote-tracking branch 'upstream/main' into fix_fnirschannelmerge
6f62a9d 
* upstream/main: (64 commits)
  MAINT: Better check (mne-tools#11229)
  MAINT: Fix link and update instantiation note (mne-tools#11228)
  BUG: Add estimated fiducials when missing / assumed head coords (mne-tools#11212)
  Fix tfr db (mne-tools#11223)
  MAINT: Update link (mne-tools#11222)
  add CPGRL doc section (mne-tools#11216)
  Don't insert superfluous newlines in subprocess log messages (mne-tools#11219)
  purge _get_args helper func (mne-tools#11215)
  Standardize topomap args (mne-tools#11123)
  MAINT: Ensure no datasets are downloaded in tests (mne-tools#11213)
  MAINT: Fix Cirrus caching (mne-tools#11211)
  Fix mesh display in tutorial (mne-tools#11200)
  MAINT: Add arm64 CI using CirrusCI (mne-tools#11209)
  Fix spatial colors (mne-tools#11201)
  MAINT: Fix CircleCI error (mne-tools#11205) [circle deploy]
  Add regression-based approach to removing EOG artifacts (mne-tools#11046)
  [DOC, MRG] Minor documentation improvements and remove glossary entry for array-like (mne-tools#11207)
  Fix `include_tmax` not considered in `mne.io.Raw.crop` to check `tmax` in bounds (mne-tools#11204)
  MAINT: Fix notebook backend (mne-tools#11206)
  MRG: Fix displayed Raw duration in Jupyter notebook (mne-tools#11203)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.2

Development

Successfully merging this pull request may close these issues.

2 participants

@larsoner @drammock