Simplified Nextcloud logo icon #5288
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
…mmon::copyFromStorage. Issue# 5071
Signed-off-by: Joas Schilling <coding@schilljs.com>
UserManager Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Fixed typo and removed doclink symbol. Reported at transifex Update util.php Another l10n improvement from transifex. Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Marin Treselj <marin@pixelipo.com>
…ale mode Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
…ut fields Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
* password form overlaps upload button and doesn't allow to click it * regression from nextcloud#5259 Signed-off-by: Morris Jobke <hey@morrisjobke.de> make sure that we always clear all floating rules after the user settings parts Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
…s-regression Allow to change avatar when groups are disables
Don't try to generate logs for chunking paths
Member
|
cc @nextcloud/designers |
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
…e users email address Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
show input fields if they are not empty but disable them in global scale mode
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
Signed-off-by: Artem Anufrij <artem.anufrij@live.de>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
…escaping Fix escaping of user and group names in "shared by" message
This reverts commit 28e1a9d. See nextcloud#5259
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Add quota to the files view
Fix nextcloud#5349, no themed icon when dragging folder
…h-auth-headers-for-clients-that-dont-follow-specs Prevent sending second WWW-Authenticate header
Revert "allow admin to disable groups on personal page"
fix "add to your nextcloud" input field
Better error message on invalid sharing link
Fix example theme
Fixed a crash caused by Local::copyFromStorage() not conforming to Co…
Member
|
@pixelipo Could I ask you to resolve the conflict? |
…oppatches_to_birthday_calendar allow PropPatch requests to contact_birthdays
…al-dir-from-encryption don't try to encrypt/decrypt the certificate bundle
…avauth-check remove check, user_webdavauth is not an app anymore for long
Member
|
We need to check this with theming also cc @nextcloud/theming |
juliusknorr
requested changes
Jun 14, 2017
| #header .logo-icon { | ||
| #header .logo { | ||
| background-image: url(#{$image-logo}); | ||
| @if $theming-logo-mime != '' { |
Member
There was a problem hiding this comment.
That should not be removed, otherwise we have #4585 again.
Member
There was a problem hiding this comment.
Yeah … when seeing the "contain" I was reminded of something too :D
Contributor
Author
There was a problem hiding this comment.
Well, if we want to limit this logo to 175px, as is defined here, than the solution would be to simply change the width of the .logo element. Why is it set to 252px if it never fills that space?
Signed-off-by: Marin Treselj <marin@pixelipo.com>
Codecov Report
@@ Coverage Diff @@
## master #5288 +/- ##
============================================
+ Coverage 54.16% 54.16% +<.01%
Complexity 22311 22311
============================================
Files 1380 1380
Lines 85406 85406
Branches 1321 1321
============================================
+ Hits 46257 46259 +2
+ Misses 39149 39147 -2
|
Contributor
Author
|
@MorrisJobke I just managed to royally screw up this PR while attempting a rebase 👎 I guess I'll have to create a new one... |
Member
|
@pixelipo happens to all of us sometimes. ;) It's always best to test the rebase locally, then in case it's broken the last good version is still in the main repository. :) |
Member
|
@pixelipo You should be able to just create a new branch from master and run |
Contributor
Author
|
Replaced by #5407 @juliushaertl @jancborchardt please review over there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the SVG optimization task #5157
Nextcloud logo code has been simplified, but at the same time it's more human-readable.
I've changed the size to more traditional values (256*128). Circles are a bit fatter than they used to be (+0.5px at 128px width). If that is an issue, I can change their width to 21.5px.
logo-icon.svgis deprecated since newlogo.svgis already much smaller in weight.I've combined
.logoand.logo-icon- this is not strictly needed, I can revert if @nextcloud/designers disagree. It requires addinglogoclass to tags that havelogo-iconclass in apps - mainly where pages are shared publicly, e.g. Calendar.PNG images and favicons were not edited.
Signed-off-by: Marin Treselj marin@pixelipo.com