[bot] Bump openshift/prometheus to v2.45.0#166
Merged
openshift-merge-robot merged 119 commits intoopenshift:masterfrom Jun 27, 2023
Merged
[bot] Bump openshift/prometheus to v2.45.0#166openshift-merge-robot merged 119 commits intoopenshift:masterfrom
openshift-merge-robot merged 119 commits intoopenshift:masterfrom
Conversation
Signed-off-by: Patryk Prus <p@trykpr.us>
Signed-off-by: René Scheibe <rene.scheibe@gmail.com>
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
Fix changelog about scrape configs
Signed-off-by: znley <shanjiantao@loongson.cn>
Signed-off-by: Justin Lei <justin.lei@grafana.com>
Signed-off-by: Justin Lei <justin.lei@grafana.com>
Signed-off-by: Justin Lei <justin.lei@grafana.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Justin Lei <justin.lei@grafana.com>
Signed-off-by: Justin Lei <justin.lei@grafana.com>
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
Refactors textparser test to use a common test utility to create protobuf representation from MetricFamily Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
…e and return an error Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
Signed-off-by: cui fliter <imcusg@gmail.com>
Signed-off-by: Paschalis Tsilias <paschalist0@gmail.com>
Co-authored-by: Julien Pivotto <roidelapluie@o11y.eu> Signed-off-by: Paschalis Tsilias <tpaschalis@users.noreply.github.com>
Signed-off-by: Jesus Vazquez <jesus.vazquez@grafana.com>
…us-vazquez-as-2-45-release-shepherd Propose Jesus Vazquez as 2.45 release shepherd
Signed-off-by: Paschalis Tsilias <paschalist0@gmail.com>
Signed-off-by: Paschalis Tsilias <paschalist0@gmail.com>
Co-authored-by: Julien Pivotto <roidelapluie@o11y.eu> Signed-off-by: Paschalis Tsilias <tpaschalis@users.noreply.github.com>
…rotoc Fix recommended protoc version
Consider code like:
for i := 0; i < numTargets; i++ {
stopFuncs = append(stopFuncs, func() {
time.Sleep(i*20*time.Millisecond)
})
}
Because the loop variable i is shared by all closures,
all the stopFuncs sleep for numTargets*20 ms.
If the i were made per-iteration, as we are considering
for a future Go release, the stopFuncs would have sleep
durations ranging from 0 to (numTargets-1)*20 ms.
Two tests had code like this and were checking that the
aggregate sleep was at least numTargets*20 ms
("at least as long as the last target slept"). This is only true
today because i == numTarget during all the sleeps.
To keep the code working even if the semantics of this loop
change, this PR computes
d := time.Duration((i+1)*20) * time.Millisecond
outside the closure (but inside the loop body), and then each
closure has its own d. Now the sleeps range from 20 ms
to numTargets*20 ms, keeping the test passing
(and probably behaving closer to the intent of the test author).
The failure being fixed can be reproduced by using the current
Go development branch with
GOEXPERIMENT=loopvar go test
Signed-off-by: Russ Cox <rsc@golang.org>
Fix some comments.
scrape: fix two loop variable scoping bugs in test
The storage.ChunkSeries iterator assumes that a histogram sample can always be appended to the currently open chunk. This is not the case when there is a counter reset, or when appending a stale sample to a chunk with non-stale samples. In addition, the open chunk sometimes needs to be recoded before a sample can be appended. This commit addresses the issue by implementing a RecodingAppender which can recode incoming samples in a transparent way. It also detects cases when a sample cannot be appended at all and returns `false` so that the caller can open a new chunk. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> Co-authored-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> Co-authored-by: Ganesh Vernekar <ganeshvern@gmail.com>
Add support for inline TLS certificates
…)" This reverts commit dfae954. Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
Revert "Improving Performance on the API Gzip Handler (prometheus#12363)"
Signed-off-by: Jesus Vazquez <jesusvzpg@gmail.com>
Signed-off-by: Jesus Vazquez <jesusvzpg@gmail.com>
Signed-off-by: Jesus Vazquez <jesusvzpg@gmail.com>
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @openshift-monitoring-bot[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
monitoring-commit-bot
bot
force-pushed
the
automated-updates-master
branch
2 times, most recently
from
6cb079b to
2ebf7a2
Compare
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
|
/test e2e-agnostic-cmo |
v2.45.0 # -----BEGIN PGP SIGNATURE----- # # iQGzBAABCAAdFiEEu716pYzBHhE8naWpGN/83iMsuS0FAmSVtQMACgkQGN/83iMs # uS3ZiAv/ZyMGu4JQbs7XS2CB94cB5TUJkaqtNtiQudbhzwoOTHVf5O9SJ0RXLJqk # wsQV4hAiWCjZjsMsPqxcsFQItCMVYSrL1IyHc05rcVI7hf6iVHfYQ7jBtRu0CkIM # L0RD84JTtDQgQU6Iumy0KWHKcwAzbK+ui0fRtg3NHEYncUNDRKwF2FgJqHgSDrRT # 8SVOBRk0anyw0Eko5nwdPZFdxJdQTAFOfxHiE8iBxrV/+rPgqzYqHk5RgTCuSJzW # YolZ2irsqR0F3KjtkPgdwxWTFZCuAHnm42dZzGWJ+EI76PGsJ0NH6yzjWI2QRx5U # iQGxfh2giuuj7ewt6aAUsGJhUpt1CRk1OB+EO0hx9GbYgbQZmP2CX/it8g7j6HSm # hENU/4rVTygfpGnfJgSQTRlbP8KO/3B7x+i5hc+l4Yd0KxhvSp0HsEJJAQevZsWa # y6bIxW4dVtGcht07L+oT4hOA4ppBYUUfUdq6OxOTWbn5NPOiFZo9SjPggyzcsWIJ # zWYEoEkt # =41CO # -----END PGP SIGNATURE----- # gpg: directory '/home/runner/.gnupg' created # gpg: keybox '/home/runner/.gnupg/pubring.kbx' created # gpg: Signature made Fri Jun 23 15:06:43 2023 UTC # gpg: using RSA key BBBD7AA58CC11E113C9DA5A918DFFCDE232CB92D # gpg: Can't check signature: No public key
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
monitoring-commit-bot
bot
force-pushed
the
automated-updates-master
branch
from
2ebf7a2 to
8db7e26
Compare
|
@openshift-monitoring-bot[bot]: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-monitoring-bot[bot], simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot bot
pushed a commit
that referenced
this pull request
Oct 9, 2025
When doing a config reload that need to stop some providers while also sending SIGTERM to Prometheus at the same time can sometimes hang
1: sync.WaitGroup.Wait [83 minutes] [Created by run.(*Group).Run in goroutine 1 @ group.go:37]
sync sema.go:110 runtime_SemacquireWaitGroup(*uint32(#166))
sync waitgroup.go:118 (*WaitGroup).Wait(*WaitGroup(#23))
discovery manager.go:276 (*Manager).ApplyConfig(#23, #167)
main main.go:964 main.func5(#120)
main main.go:1505 reloadConfig({#183, 0x1b}, 1, #40, #43, #50, {#31, 0xa, 0})
main main.go:1182 main.func22()
run group.go:38 (*Group).Run.func1(*Group(#26), #51)
Add a test for it.
Signed-off-by: Lukasz Mierzwa <l.mierzwa@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is an automated version bump from CI.
If you wish to perform this manually, execute the following commands from openshift/prometheus repo,