OCPBUGS-22531: bump otel dependencies#183
OCPBUGS-22531: bump otel dependencies#183openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.14from
Conversation
openshift-ci-robot
added
jira/severity-moderate
|
@simonpasquier: This pull request references Jira Issue OCPBUGS-22531, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
jira/invalid-bug
|
/hold Need to wait for the fix to land in the master branch. |
openshift-ci
bot
added
do-not-merge/hold
go.mod
Outdated
| @@ -55,12 +55,12 @@ require ( | |||
| github.com/stretchr/testify v1.8.4 | |||
| github.com/vultr/govultr/v2 v2.17.2 | |||
| go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.42.0 | |||
There was a problem hiding this comment.
| go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.42.0 | |
| go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.44.0 |
Should this dependency not also be updated?
simonpasquier
force-pushed
the
OCPBUGS-22531
branch
from
b1632d1 to
d8fd794
Compare
Required to address CVE-2023-45142. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
simonpasquier
force-pushed
the
OCPBUGS-22531
branch
from
d8fd794 to
ea6e008
Compare
|
/label backport-risk-assessed |
openshift-ci
bot
added
the
backport-risk-assessed
|
@simonpasquier: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jan--f, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Blocked by #185 |
|
/jira refresh |
|
@simonpasquier: This pull request references Jira Issue OCPBUGS-22531, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@simonpasquier: This pull request references Jira Issue OCPBUGS-22531, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: juzhao. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/label cherry-pick-approved |
openshift-ci
bot
added
cherry-pick-approved
|
@simonpasquier: This pull request references Jira Issue OCPBUGS-22531, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: juzhao. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@simonpasquier: Jira Issue OCPBUGS-22531: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-22531 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build golang-github-prometheus-prometheus-container-v4.14.0-202312051151.p0.gb7c61bc.assembly.stream for distgit golang-github-prometheus-prometheus. |
|
Fix included in accepted release 4.14.0-0.nightly-2023-12-05-123655 |
When doing a config reload that need to stop some providers while also sending SIGTERM to Prometheus at the same time can sometimes hang
1: sync.WaitGroup.Wait [83 minutes] [Created by run.(*Group).Run in goroutine 1 @ group.go:37]
sync sema.go:110 runtime_SemacquireWaitGroup(*uint32(#166))
sync waitgroup.go:118 (*WaitGroup).Wait(*WaitGroup(#23))
discovery manager.go:276 (*Manager).ApplyConfig(#23, #167)
main main.go:964 main.func5(#120)
main main.go:1505 reloadConfig({#183, 0x1b}, 1, #40, #43, #50, {#31, 0xa, 0})
main main.go:1182 main.func22()
run group.go:38 (*Group).Run.func1(*Group(#26), #51)
Add a test for it.
Signed-off-by: Lukasz Mierzwa <l.mierzwa@gmail.com>
6 participants
Required to address CVE-2023-45142.