Reload certificates from disk automatically + bump to v2.7.2#26
Merged
openshift-merge-robot merged 3 commits intoopenshift:masterfrom Mar 13, 2019
Merged
Conversation
It should be a unix timestamp, not the seconds in the minute. Signed-off-by: beorn7 <beorn@soundcloud.com> Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> Signed-off-by: Simon Pasquier <spasquie@redhat.com>
This change bumps github.com/prometheus/common to include the necessary bits. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
openshift-ci-robot
added
the
size/XXL
openshift-ci-robot
added
the
approved
Author
|
cc @brancz |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pgier, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/prometheus
that referenced
this pull request
Jan 9, 2025
[release-2.7] Triggering image rebuild
openshift-merge-bot bot
pushed a commit
that referenced
this pull request
Oct 9, 2025
When doing a config reload that need to stop some providers while also sending SIGTERM to Prometheus at the same time can sometimes hang
1: sync.WaitGroup.Wait [83 minutes] [Created by run.(*Group).Run in goroutine 1 @ group.go:37]
sync sema.go:110 runtime_SemacquireWaitGroup(*uint32(#166))
sync waitgroup.go:118 (*WaitGroup).Wait(*WaitGroup(#23))
discovery manager.go:276 (*Manager).ApplyConfig(#23, #167)
main main.go:964 main.func5(#120)
main main.go:1505 reloadConfig({#183, 0x1b}, 1, #40, #43, #50, {#31, 0xa, 0})
main main.go:1182 main.func22()
run group.go:38 (*Group).Run.func1(*Group(#26), #51)
Add a test for it.
Signed-off-by: Lukasz Mierzwa <l.mierzwa@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch comparison between the upstream v2.7.2 tag and this PR:
prometheus/prometheus@v2.7.2...simonpasquier:bump-prometheus-common
This includes prometheus/common#173 which makes sure that Prometheus reloads certificate files from disk automatically whenever they are rotated.