[bot] Bump openshift/prometheus to v2.46.0#167
[bot] Bump openshift/prometheus to v2.46.0#167openshift-merge-robot merged 183 commits intoopenshift:masterfrom
Conversation
Signed-off-by: songjiayang <songjiayang1@gmail.com>
Signed-off-by: Ashish Kurmi <akurmi@stepsecurity.io>
I found it hard to understand how EvalTimestamp works, so I wanted to simplify the math there. This PR should be a noop.
Current formula is:
```
offset = g.hash % g.interval
adjNow = startTime - offset
base = adjNow - (adjNow % g.interval)
EvalTimestamp = base + offset
```
I simplify `EvalTimestamp`
```
EvalTimestamp = base + offset
# expand base
= adjNow - (adjNow % g.interval) + offset
# expand adjNow
= startTime - offset - ((startTime - offset) % g.interval) + offset
# cancel out offset
= startTime - ((startTime - offset) % g.interval)
# expand A+B (mod M) = (A (mod M) + B (mod M)) (mod M)
= startTime - (startTime % g.interval - offset % g.interval) % g.interval
# expand offset
= startTime - (startTime % g.interval - ((g.hash % g.interval) % g.interval)) % g.interval
# remove redundant mod g.interval
= startTime - (startTime % g.interval - g.hash % g.interval) % g.interval
# simplify (A (mod M) + B (mod M)) (mod M) = A+B (mod M)
= startTime - (startTime - g.hash) % g.interval
offset = (startTime - g.hash) % g.interval
EvalTimestamp = startTime - offset
```
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Co-authored-by: Christian Hoffmann <christian@hoffie.info> Signed-off-by: Ashish Kurmi <100655670+boahc077@users.noreply.github.com>
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
…to target group Signed-off-by: Aaron George <aaron@ometria.com> Signed-off-by: Aaron George <aaron@ometria.com>
Signed-off-by: Paweł Krupa (paulfantom) <pawel@krupa.net.pl>
…dpoints Signed-off-by: Charles Korn <charles.korn@grafana.com>
Signed-off-by: Charles Korn <charles.korn@grafana.com>
…form a type assertion against Response.Data. Signed-off-by: Charles Korn <charles.korn@grafana.com>
Signed-off-by: Charles Korn <charles.korn@grafana.com>
Signed-off-by: Charles Korn <charleskorn@users.noreply.github.com>
…low overriding the default API codec. Signed-off-by: Charles Korn <charles.korn@grafana.com>
Signed-off-by: Charles Korn <charles.korn@grafana.com>
Currently github actions keep sending me mails about things that should only run on the prometheus organisation actions. This change makes sure to check who owns the repository before running the CI workflow. Signed-off-by: Francis Begyn <francis@begyn.be>
In Thanos we would like to start experimenting with custom functions that are currently not part of the PromQL spec. We would do this by adding an implementation for those functions in the Thanos engine: https://github.com/thanos-community/promql-engine and allow users to decide which engine they want to use on a per-query basis. Since we use the PromQL parser from Prometheus, injecting functions in the global `Functions` variable would mean they also become available for the Prometheus engine. To avoid this side-effect, this commit exposes a Parser interface in which the supported functions can be injected as an option. If not functions are injected, the parser implementation will default to the functions defined in the global Functions variable. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Signed-off-by: François Gouteroux <francois.gouteroux@gmail.com>
Signed-off-by: Xiaochao Dong (@damnever) <the.xcdong@gmail.com>
Signed-off-by: François Gouteroux <francois.gouteroux@gmail.com>
Signed-off-by: ianwoolf <btw515wolf2@gmail.com>
Signed-off-by: John Losito <lositojohnj@gmail.com>
Signed-off-by: François Gouteroux <francois.gouteroux@gmail.com>
Signed-off-by: François Gouteroux <francois.gouteroux@gmail.com>
Signed-off-by: François Gouteroux <francois.gouteroux@gmail.com>
Signed-off-by: Justin Lei <justin.lei@grafana.com>
Signed-off-by: Justin Lei <justin.lei@grafana.com>
Signed-off-by: François Gouteroux <francois.gouteroux@gmail.com>
Signed-off-by: François Gouteroux <francois.gouteroux@gmail.com>
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
Prepare go dependencies for 2.46
Native histograms without a zero threshold aren't federated properly. This adds a test to prove the specific failure mode, which is that histograms with a zero threshold of zero are federated as classic histograms. The underlying reason is that the protobuf parser identifies a native histogram by detecting a zero bucket or by detecting integer buckets. Therefore, a float histogram with a zero threshold of zero and an unpopulated zero bucket falls through the cracks (no integer buckets, no zero bucket). This commit also addse a test case for the latter. Signed-off-by: beorn7 <beorn@grafana.com>
If a float histogram has a zero bucket with a threshold of zero _and_ an empty zero bucket, it wasn't identified as a native histogram because the `isNativeHistogram` helper function only looked at integer buckets. Signed-off-by: beorn7 <beorn@grafana.com>
histograms: Fix parsing of float histograms without zero bucket
scrape: Enable ingestion of multiple exemplars per sample
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
Release 2.46.0-rc.0
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
Release 2.46.0
v2.46.0 # -----BEGIN PGP SIGNATURE----- # # iHUEABYKAB0WIQQmXJ5XCZMypkpKK5sUxTiRCP+xLAUCZL+/yAAKCRAUxTiRCP+x # LKJeAP9abnbmnT5Ovl3U4xUbqXcdT/50q8+C02xj2JTGoCPE7wD/VegCYYydTJSg # vCUMjKuixggoYRQQtsz+mc9YYGmRvwg= # =0yXM # -----END PGP SIGNATURE----- # gpg: directory '/home/runner/.gnupg' created # gpg: keybox '/home/runner/.gnupg/pubring.kbx' created # gpg: Signature made Tue Jul 25 12:27:52 2023 UTC # gpg: using EDDSA key 265C9E57099332A64A4A2B9B14C5389108FFB12C # gpg: Can't check signature: No public key
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
Hi @openshift-monitoring-bot[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-monitoring-bot[bot], simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
@openshift-monitoring-bot[bot]: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
When doing a config reload that need to stop some providers while also sending SIGTERM to Prometheus at the same time can sometimes hang
1: sync.WaitGroup.Wait [83 minutes] [Created by run.(*Group).Run in goroutine 1 @ group.go:37]
sync sema.go:110 runtime_SemacquireWaitGroup(*uint32(#166))
sync waitgroup.go:118 (*WaitGroup).Wait(*WaitGroup(#23))
discovery manager.go:276 (*Manager).ApplyConfig(#23, #167)
main main.go:964 main.func5(#120)
main main.go:1505 reloadConfig({#183, 0x1b}, 1, #40, #43, #50, {#31, 0xa, 0})
main main.go:1182 main.func22()
run group.go:38 (*Group).Run.func1(*Group(#26), #51)
Add a test for it.
Signed-off-by: Lukasz Mierzwa <l.mierzwa@gmail.com>
Description
This is an automated version bump from CI.
If you wish to perform this manually, execute the following commands from openshift/prometheus repo,