Skip to content

Raise slow RPC ack warning threshold to 15s#1760

Merged
juliusmarminge merged 2 commits intomainfrom
feature/raise-rpc-ack-threshold
Apr 5, 2026
Merged

Raise slow RPC ack warning threshold to 15s#1760
juliusmarminge merged 2 commits intomainfrom
feature/raise-rpc-ack-threshold

Conversation

@juliusmarminge
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge commented Apr 5, 2026

git.status is quite slow, so 3s is a bit low. increasing it til we make that query faster

Summary

  • Increased SLOW_RPC_ACK_THRESHOLD_MS from 2.5 seconds to 15 seconds in apps/web/src/rpc/requestLatencyState.ts.
  • This reduces premature slow-ack tracking for RPC requests that are still within an acceptable response window.

Testing

  • Not run (change is a one-line constant update).
  • Not run: bun fmt
  • Not run: bun lint
  • Not run: bun typecheck

Note

Low Risk
Low risk: adjusts a client-side slow-ack warning timeout and updates a unit test to use a configurable threshold, without changing RPC behavior or data handling.

Overview
Raises the slow RPC ack tracking threshold from 2.5s to 15s so unary RPC requests are only flagged as slow after a longer delay.

Introduces a test-only override (setSlowRpcAckThresholdMsForTests) and resets it in resetRequestLatencyStateForTests, then updates the WsTransport slow-ack test to use a short threshold and tighter timeouts.

Reviewed by Cursor Bugbot for commit 09b179e. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Raise slow RPC ack warning threshold from 2.5s to 15s

Increases SLOW_RPC_ACK_THRESHOLD_MS from 2_500 to 15_000 in requestLatencyState.ts to reduce false-positive slow-ack warnings. The constant is also promoted to a mutable module-scoped variable to allow test-time overrides via the new setSlowRpcAckThresholdMsForTests utility, avoiding slow timers in tests.

Macroscope summarized 09b179e.

- Reduce false slow-ack warnings for normal RPC latency
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 5, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 6ddd1e07-eda8-498d-9f78-b6a602be85e8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/raise-rpc-ack-threshold

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Apr 5, 2026
@juliusmarminge juliusmarminge enabled auto-merge (squash) April 5, 2026 15:56
macroscopeapp[bot]
macroscopeapp bot previously approved these changes Apr 5, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp bot commented Apr 5, 2026

Approvability

Verdict: Approved

This PR raises a warning threshold constant from 2.5s to 15s for slow RPC acknowledgments, affecting only when UI warnings are displayed. The change is self-contained, low-risk, and includes appropriate test helpers for the new configurable threshold.

You can customize Macroscope's approvability policy. Learn more.

- Add a test-only setter for the slow RPC ack timer
- Use a shorter threshold in wsTransport coverage to keep the test fast
@github-actions github-actions bot added size:S 10-29 changed lines (additions + deletions). and removed size:XS 0-9 changed lines (additions + deletions). labels Apr 5, 2026
@macroscopeapp macroscopeapp bot dismissed their stale review April 5, 2026 16:51

Dismissing prior approval to re-evaluate 09b179e

@juliusmarminge juliusmarminge merged commit e0874b6 into main Apr 5, 2026
12 checks passed
@juliusmarminge juliusmarminge deleted the feature/raise-rpc-ack-threshold branch April 5, 2026 16:53
thezem pushed a commit to thezem/t3code that referenced this pull request Apr 5, 2026
gigq pushed a commit to gigq/t3code that referenced this pull request Apr 6, 2026
Chrono-byte pushed a commit to Chrono-byte/t3code that referenced this pull request Apr 7, 2026
rororowyourboat added a commit to rororowyourboat/t3code that referenced this pull request Apr 9, 2026
…threadId (#2)

* Raise slow RPC ack warning threshold to 15s (pingdotgg#1760)

* Use active worktree path for workspace saves (pingdotgg#1762)

* Stream git status updates over WebSocket (pingdotgg#1763)

Co-authored-by: codex <codex@users.noreply.github.com>

* fix(web): unwrap windows shell command wrappers (pingdotgg#1719)

* Rename "Chat" to "Build" in interaction mode toggle (pingdotgg#1769)

Co-authored-by: Julius Marminge <julius0216@outlook.com>

* Assign default capabilities to Codex custom models (pingdotgg#1793)

* Add project rename support in the sidebar (pingdotgg#1798)

* Support multi-select pending user inputs (pingdotgg#1797)

* Add Zed support to Open actions via editor command aliases (pingdotgg#1303)

Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>

* Closes pingdotgg#1795 - Support building and developing in a devcontainer (pingdotgg#1791)

* Add explicit timeouts to CI and release workflows (pingdotgg#1825)

* fix(web): distinguish singular/plural in pending action submit label (pingdotgg#1826)

* Refactor web stores into atomic slices ready to split ChatView (pingdotgg#1708)

* Add VSCode Insiders and VSCodium icons (pingdotgg#1847)

* Prepare datamodel for multi-environment (pingdotgg#1765)

Co-authored-by: justsomelegs <145564979+justsomelegs@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com>

* Implement server auth bootstrap and pairing flow (pingdotgg#1768)

Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius@macmini.local>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com>

* Use dev proxy for loopback auth and environment requests (pingdotgg#1853)

* Refresh local git status on turn completion (pingdotgg#1821)

Co-authored-by: codex <codex@users.noreply.github.com>

* fix(desktop): add Copy Link action for chat links (pingdotgg#1835)

* fix: map runtime modes to correct permission levels (pingdotgg#1587)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>

* Fix persisted composer image hydration typo (pingdotgg#1831)

* Clarify environment and workspace picker labels (pingdotgg#1854)

* Scope git toast state by thread ref (pingdotgg#1855)

* fix build (pingdotgg#1859)

* Stabilize keybindings toast stream setup (pingdotgg#1860)

Co-authored-by: Julius Marminge <julius@macmini.local>

* feat(web): add embeddable thread route for canvas tile hosts

Adds /embed/thread/:environmentId/:threadId — a standalone route that
renders the existing ChatView without the app sidebar chrome. This is the
iframe target for t3-canvas agent shapes (see rororowyourboat/t3-canvas#3).

- New file-based route embed.thread.\$environmentId.\$threadId.tsx
- __root.tsx bypasses AppSidebarLayout for any /embed/* pathname so the
  environment connection + websocket surface + toasts still initialize
  but the sidebar/diff/plan chrome does not render
- minimal=1 search param is parsed and wired to a data attribute on the
  container for future targeted CSS; chrome hiding (BranchToolbar,
  PlanSidebar, ThreadTerminalDrawer) stays as a follow-up pass
- routeTree.gen.ts regenerated by the @tanstack/router-plugin

---------

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: legs <145564979+justsomelegs@users.noreply.github.com>
Co-authored-by: sonder <168988030+heysonder@users.noreply.github.com>
Co-authored-by: Adem Ben Abdallah <96244394+AdemBenAbdallah@users.noreply.github.com>
Co-authored-by: Kyle Gottfried <6462596+Spitfire1900@users.noreply.github.com>
Co-authored-by: Jacob <589761+jvzijp@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius@macmini.local>
Co-authored-by: Klemencina <56873773+Klemencina@users.noreply.github.com>
Co-authored-by: Oskar Sekutowicz <me.oski646@gmail.com>
Co-authored-by: Noxire <59626436+noxire-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant