Skip to content

Refresh local git status on turn completion#1821

Merged
juliusmarminge merged 2 commits intomainfrom
t3code/turn-completion-invalidation
Apr 9, 2026
Merged

Refresh local git status on turn completion#1821
juliusmarminge merged 2 commits intomainfrom
t3code/turn-completion-invalidation

Conversation

@juliusmarminge
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge commented Apr 7, 2026

Summary

  • Refreshes only the cached local git status when a provider turn completes, using the session CWD.
  • Wires turn completion handling in CheckpointReactor to trigger a local status refresh without forcing a full status recompute.
  • Adds coverage for the new local-refresh path and updates git status broadcaster tests for cache invalidation behavior.

Testing

  • Not run (PR description only).
  • Existing test coverage added in apps/server/src/orchestration/Layers/CheckpointReactor.test.ts for turn completion refresh behavior.
  • Existing test coverage added in apps/server/src/git/Layers/GitStatusBroadcaster.test.ts for local snapshot refresh and cache invalidation.

Note

Medium Risk
Touches turn completion handling in CheckpointReactor and git status caching behavior, which can affect UI/status freshness and checkpoint flow timing. Failures are caught and only warn, but incorrect CWD normalization or session resolution could cause missed/extra refreshes.

Overview
On provider turn.completed, CheckpointReactor now triggers a local-only git status cache refresh via GitStatusBroadcaster.refreshLocalStatus(session.cwd) before capturing the post-turn checkpoint; refresh failures are logged and do not block checkpointing.

GitStatusBroadcaster adds a new refreshLocalStatus(cwd) API (including CWD normalization) to invalidate/reload just the local snapshot without forcing a remote refresh, with new test coverage validating local-only invalidation and updated harnesses stubbing the new service dependency.

Reviewed by Cursor Bugbot for commit 883489c. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Refresh local git status on turn completion in CheckpointReactor

  • Adds refreshLocalStatus(cwd) to the GitStatusBroadcasterShape interface and implements it in GitStatusBroadcasterLive, normalizing the cwd before invalidating and reloading the local git status cache.
  • On turn.completed events, CheckpointReactorLive now calls gitStatusBroadcaster.refreshLocalStatus with the session cwd before capturing a checkpoint; failures log a warning and do not block the checkpoint.
  • Test harnesses for both CheckpointReactor and the orchestration integration layer are updated to inject a stub GitStatusBroadcaster that records refreshLocalStatus calls.

Macroscope summarized 883489c.

- Invalidate and recache the session cwd git snapshot when a turn completes
- Add broadcaster coverage for local-only refresh and reactor integration
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 7, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 419f64a8-4a74-4a69-b89c-1daaecf37074

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch t3code/turn-completion-invalidation

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Apr 7, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp bot commented Apr 7, 2026

Approvability

Verdict: Needs human review

This PR adds new automatic runtime behavior that triggers git status refresh on every turn completion. While well-tested and authored by a primary contributor to these files, the addition of new observable behavior that runs automatically warrants human review.

No code changes detected at 883489c. Prior analysis still applies.

You can customize Macroscope's approvability policy. Learn more.

Co-authored-by: codex <codex@users.noreply.github.com>
@juliusmarminge juliusmarminge merged commit 2aa7398 into main Apr 9, 2026
12 checks passed
@juliusmarminge juliusmarminge deleted the t3code/turn-completion-invalidation branch April 9, 2026 18:02
rororowyourboat added a commit to rororowyourboat/t3code that referenced this pull request Apr 9, 2026
…threadId (#2)

* Raise slow RPC ack warning threshold to 15s (pingdotgg#1760)

* Use active worktree path for workspace saves (pingdotgg#1762)

* Stream git status updates over WebSocket (pingdotgg#1763)

Co-authored-by: codex <codex@users.noreply.github.com>

* fix(web): unwrap windows shell command wrappers (pingdotgg#1719)

* Rename "Chat" to "Build" in interaction mode toggle (pingdotgg#1769)

Co-authored-by: Julius Marminge <julius0216@outlook.com>

* Assign default capabilities to Codex custom models (pingdotgg#1793)

* Add project rename support in the sidebar (pingdotgg#1798)

* Support multi-select pending user inputs (pingdotgg#1797)

* Add Zed support to Open actions via editor command aliases (pingdotgg#1303)

Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>

* Closes pingdotgg#1795 - Support building and developing in a devcontainer (pingdotgg#1791)

* Add explicit timeouts to CI and release workflows (pingdotgg#1825)

* fix(web): distinguish singular/plural in pending action submit label (pingdotgg#1826)

* Refactor web stores into atomic slices ready to split ChatView (pingdotgg#1708)

* Add VSCode Insiders and VSCodium icons (pingdotgg#1847)

* Prepare datamodel for multi-environment (pingdotgg#1765)

Co-authored-by: justsomelegs <145564979+justsomelegs@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com>

* Implement server auth bootstrap and pairing flow (pingdotgg#1768)

Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius@macmini.local>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com>

* Use dev proxy for loopback auth and environment requests (pingdotgg#1853)

* Refresh local git status on turn completion (pingdotgg#1821)

Co-authored-by: codex <codex@users.noreply.github.com>

* fix(desktop): add Copy Link action for chat links (pingdotgg#1835)

* fix: map runtime modes to correct permission levels (pingdotgg#1587)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>

* Fix persisted composer image hydration typo (pingdotgg#1831)

* Clarify environment and workspace picker labels (pingdotgg#1854)

* Scope git toast state by thread ref (pingdotgg#1855)

* fix build (pingdotgg#1859)

* Stabilize keybindings toast stream setup (pingdotgg#1860)

Co-authored-by: Julius Marminge <julius@macmini.local>

* feat(web): add embeddable thread route for canvas tile hosts

Adds /embed/thread/:environmentId/:threadId — a standalone route that
renders the existing ChatView without the app sidebar chrome. This is the
iframe target for t3-canvas agent shapes (see rororowyourboat/t3-canvas#3).

- New file-based route embed.thread.\$environmentId.\$threadId.tsx
- __root.tsx bypasses AppSidebarLayout for any /embed/* pathname so the
  environment connection + websocket surface + toasts still initialize
  but the sidebar/diff/plan chrome does not render
- minimal=1 search param is parsed and wired to a data attribute on the
  container for future targeted CSS; chrome hiding (BranchToolbar,
  PlanSidebar, ThreadTerminalDrawer) stays as a follow-up pass
- routeTree.gen.ts regenerated by the @tanstack/router-plugin

---------

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: legs <145564979+justsomelegs@users.noreply.github.com>
Co-authored-by: sonder <168988030+heysonder@users.noreply.github.com>
Co-authored-by: Adem Ben Abdallah <96244394+AdemBenAbdallah@users.noreply.github.com>
Co-authored-by: Kyle Gottfried <6462596+Spitfire1900@users.noreply.github.com>
Co-authored-by: Jacob <589761+jvzijp@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius@macmini.local>
Co-authored-by: Klemencina <56873773+Klemencina@users.noreply.github.com>
Co-authored-by: Oskar Sekutowicz <me.oski646@gmail.com>
Co-authored-by: Noxire <59626436+noxire-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant