Skip to content

fix(web): distinguish singular/plural in pending action submit label#1826

Merged
juliusmarminge merged 2 commits intopingdotgg:mainfrom
jvzijp:fix/pending-action-singular-plural-label
Apr 7, 2026
Merged

fix(web): distinguish singular/plural in pending action submit label#1826
juliusmarminge merged 2 commits intopingdotgg:mainfrom
jvzijp:fix/pending-action-singular-plural-label

Conversation

@jvzijp
Copy link
Copy Markdown
Contributor

@jvzijp jvzijp commented Apr 7, 2026

What Changed

The pending action submit button now displays "Submit answer" (singular) when there is only one question, and "Submit answers" (plural) when there are multiple questions. Previously it always showed "Submit answers" regardless of count.

  • Added questionIndex to the formatPendingPrimaryActionLabel input
  • When isLastQuestion is true and questionIndex === 0, the label is "Submit answer"; otherwise "Submit answers"
  • Exported formatPendingPrimaryActionLabel and added unit tests covering all branches

Why

Showing "Submit answers" when the user is answering a single question is misleading — it implies there are multiple responses being submitted. This small copy fix makes the UI more accurate and less confusing.

UI Changes

Scenario Before After
Single question (questionIndex: 0) "Submit answers" "Submit answer"
Multiple questions (questionIndex > 0) "Submit answers" "Submit answers" (unchanged)

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes — N/A, no animation changes

Note

Low Risk
Low risk UI copy/labeling change scoped to the chat composer submit button, with added unit coverage to prevent regressions.

Overview
Updates the chat composer’s pending-action primary button label to use singular Submit answer when submitting a single-question flow (questionIndex === 0), and plural Submit answers when multiple questions are involved.

Exports formatPendingPrimaryActionLabel, passes through questionIndex, and adds a Vitest suite covering responding/compact/non-compact label variants.

Reviewed by Cursor Bugbot for commit 896e77e. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Distinguish singular/plural in submit button label for pending actions

In non-compact mode, formatPendingPrimaryActionLabel now returns 'Submit answer' when questionIndex is 0 and 'Submit answers' when questionIndex > 0, so the label reflects how many answers have been given. Compact mode and responding state behavior are unchanged. Eight unit test cases are added to cover all label variants.

Macroscope summarized 896e77e.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 7, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 5134721f-a78c-4665-a0b0-026d22af563f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Apr 7, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp bot commented Apr 7, 2026

Approvability

Verdict: Approved

Simple UI copy fix that distinguishes singular/plural grammar in a button label based on question count. The change is minimal, well-tested, and has no runtime behavior impact beyond display text.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge juliusmarminge merged commit 28e481e into pingdotgg:main Apr 7, 2026
10 checks passed
@jvzijp jvzijp deleted the fix/pending-action-singular-plural-label branch April 7, 2026 21:51
gigq pushed a commit to gigq/t3code that referenced this pull request Apr 8, 2026
rororowyourboat added a commit to rororowyourboat/t3code that referenced this pull request Apr 9, 2026
…threadId (#2)

* Raise slow RPC ack warning threshold to 15s (pingdotgg#1760)

* Use active worktree path for workspace saves (pingdotgg#1762)

* Stream git status updates over WebSocket (pingdotgg#1763)

Co-authored-by: codex <codex@users.noreply.github.com>

* fix(web): unwrap windows shell command wrappers (pingdotgg#1719)

* Rename "Chat" to "Build" in interaction mode toggle (pingdotgg#1769)

Co-authored-by: Julius Marminge <julius0216@outlook.com>

* Assign default capabilities to Codex custom models (pingdotgg#1793)

* Add project rename support in the sidebar (pingdotgg#1798)

* Support multi-select pending user inputs (pingdotgg#1797)

* Add Zed support to Open actions via editor command aliases (pingdotgg#1303)

Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>

* Closes pingdotgg#1795 - Support building and developing in a devcontainer (pingdotgg#1791)

* Add explicit timeouts to CI and release workflows (pingdotgg#1825)

* fix(web): distinguish singular/plural in pending action submit label (pingdotgg#1826)

* Refactor web stores into atomic slices ready to split ChatView (pingdotgg#1708)

* Add VSCode Insiders and VSCodium icons (pingdotgg#1847)

* Prepare datamodel for multi-environment (pingdotgg#1765)

Co-authored-by: justsomelegs <145564979+justsomelegs@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com>

* Implement server auth bootstrap and pairing flow (pingdotgg#1768)

Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius@macmini.local>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com>

* Use dev proxy for loopback auth and environment requests (pingdotgg#1853)

* Refresh local git status on turn completion (pingdotgg#1821)

Co-authored-by: codex <codex@users.noreply.github.com>

* fix(desktop): add Copy Link action for chat links (pingdotgg#1835)

* fix: map runtime modes to correct permission levels (pingdotgg#1587)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>

* Fix persisted composer image hydration typo (pingdotgg#1831)

* Clarify environment and workspace picker labels (pingdotgg#1854)

* Scope git toast state by thread ref (pingdotgg#1855)

* fix build (pingdotgg#1859)

* Stabilize keybindings toast stream setup (pingdotgg#1860)

Co-authored-by: Julius Marminge <julius@macmini.local>

* feat(web): add embeddable thread route for canvas tile hosts

Adds /embed/thread/:environmentId/:threadId — a standalone route that
renders the existing ChatView without the app sidebar chrome. This is the
iframe target for t3-canvas agent shapes (see rororowyourboat/t3-canvas#3).

- New file-based route embed.thread.\$environmentId.\$threadId.tsx
- __root.tsx bypasses AppSidebarLayout for any /embed/* pathname so the
  environment connection + websocket surface + toasts still initialize
  but the sidebar/diff/plan chrome does not render
- minimal=1 search param is parsed and wired to a data attribute on the
  container for future targeted CSS; chrome hiding (BranchToolbar,
  PlanSidebar, ThreadTerminalDrawer) stays as a follow-up pass
- routeTree.gen.ts regenerated by the @tanstack/router-plugin

---------

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: legs <145564979+justsomelegs@users.noreply.github.com>
Co-authored-by: sonder <168988030+heysonder@users.noreply.github.com>
Co-authored-by: Adem Ben Abdallah <96244394+AdemBenAbdallah@users.noreply.github.com>
Co-authored-by: Kyle Gottfried <6462596+Spitfire1900@users.noreply.github.com>
Co-authored-by: Jacob <589761+jvzijp@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius@macmini.local>
Co-authored-by: Klemencina <56873773+Klemencina@users.noreply.github.com>
Co-authored-by: Oskar Sekutowicz <me.oski646@gmail.com>
Co-authored-by: Noxire <59626436+noxire-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants