Fixed spm integration on regular Xcode project#586
Merged
garrettmoon merged 5 commits intopinterest:masterfrom Jan 6, 2021
Merged
Fixed spm integration on regular Xcode project#586garrettmoon merged 5 commits intopinterest:masterfrom
garrettmoon merged 5 commits intopinterest:masterfrom
Conversation
Contributor
3a4oT
commented
Nov 17, 2020
3a4oT
commented
- without this change project itself can be built as spm package, but failed to do so when you integrate it as a dependency via Xcode.
Contributor
Author
|
Will appreciate a new release if possible :) There is a similar PR fo the pinterest/PINCache#301 |
3 tasks
Collaborator
|
Thanks for putting this up! I hate to ask, but would you mind updating the CI test to ensure that SPM works when integrating into a project? |
Contributor
Author
|
Yes sir! Will add it to my list. |
garrettmoon
approved these changes
Jan 6, 2021
Collaborator
garrettmoon
left a comment
garrettmoon
left a comment
There was a problem hiding this comment.
Thank you so much for putting this up, greatly appreciated!
|
Can we get a release with this in it, please? @garrettmoon |
Open
|
Going to ask as well, can we please get a release for these fixes? @garrettmoon |
annomusa
added a commit
to annomusa/PINRemoteImage
that referenced
this pull request
Dec 17, 2021
* master-pinremoteimage: Disable asserts in release builds when using Swift Package Manager unarchiveObjectWithData: and archivedDataWithRootObject: are deprecated (pinterest#610) update comment Set cachePolicy accordingly when PINRemoteImageManagerDownloadOptionsIgnoreCache is provided Decode WebP images directly into a buffer Core Animation likes (pinterest#600) Xcode 12.5 / SPM - Add missing headers to fix build errors with SPM and Xcode 12.5 (pinterest#597) Fixed spm integration on regular Xcode project (pinterest#586) Fix PINRemoteImageManager.h Close Comment Formatting (pinterest#594) Fix typo in PINRemoteImageManager.html (pinterest#593) Carthage is broken on Xcode 12 (pinterest#584) Update podspec to match release Hopefully fix publish for real this time... # Conflicts: # Package.swift
Lilfaen
pushed a commit
to Lilfaen/PINRemoteImage
that referenced
this pull request
Apr 20, 2023
* work with imports. * fixed imports for Xcode spa consumers * added exmple project * carthage workaround * updated CI # Conflicts: # .github/workflows/ci.yaml # Makefile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.