Skip to content

Fix PINRemoteImageManager.h Close Comment Formatting#594

Merged
garrettmoon merged 1 commit intopinterest:masterfrom
nuorder:fix-pinremoteimagemanager-h-close-comment-formatting
Jan 6, 2021
Merged

Fix PINRemoteImageManager.h Close Comment Formatting#594
garrettmoon merged 1 commit intopinterest:masterfrom
nuorder:fix-pinremoteimagemanager-h-close-comment-formatting

Conversation

@paulryanclark
Copy link
Copy Markdown
Contributor

  • The */ was not correctly placed on a new line. This prevents Xcode from correctly parsing the header file.

* The `*/` was not correctly placed on a new line. This prevents Xcode from correctly parsing the header file.
Copy link
Copy Markdown
Collaborator

@garrettmoon garrettmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution!

@garrettmoon garrettmoon merged commit 963b030 into pinterest:master Jan 6, 2021
annomusa added a commit to annomusa/PINRemoteImage that referenced this pull request Dec 17, 2021
* master-pinremoteimage:
  Disable asserts in release builds when using Swift Package Manager
  unarchiveObjectWithData: and archivedDataWithRootObject: are deprecated (pinterest#610)
  update comment
  Set cachePolicy accordingly when PINRemoteImageManagerDownloadOptionsIgnoreCache is provided
  Decode WebP images directly into a buffer Core Animation likes (pinterest#600)
  Xcode 12.5 / SPM - Add missing headers to fix build errors with SPM and Xcode 12.5 (pinterest#597)
  Fixed spm  integration on regular Xcode project (pinterest#586)
  Fix PINRemoteImageManager.h Close Comment Formatting (pinterest#594)
  Fix typo in PINRemoteImageManager.html (pinterest#593)
  Carthage is broken on Xcode 12 (pinterest#584)
  Update podspec to match release
  Hopefully fix publish for real this time...

# Conflicts:
#	Package.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants