unarchiveObjectWithData: and archivedDataWithRootObject: are deprecated#610
Merged
bolsinga merged 5 commits intopinterest:masterfrom Sep 2, 2021
Merged
unarchiveObjectWithData: and archivedDataWithRootObject: are deprecated#610bolsinga merged 5 commits intopinterest:masterfrom
bolsinga merged 5 commits intopinterest:masterfrom
Conversation
…iler, but not sure why only issue on iphone 8
…rm to NSSecureCoding
jparise
reviewed
Sep 1, 2021
jparise
approved these changes
Sep 2, 2021
Comment on lines
+22
to
+23
| PINDiskCacheErrorReadFailure = -1000, | ||
| PINDiskCacheErrorWriteFailure = -1001, |
Collaborator
There was a problem hiding this comment.
I think you could revert this formatting change, too.
Contributor
Author
There was a problem hiding this comment.
i could but previously they're not right indented?
Collaborator
There was a problem hiding this comment.
It's fine then. It's just not related to the rest of this change.
bolsinga
approved these changes
Sep 2, 2021
annomusa
added a commit
to annomusa/PINRemoteImage
that referenced
this pull request
Dec 17, 2021
* master-pinremoteimage: Disable asserts in release builds when using Swift Package Manager unarchiveObjectWithData: and archivedDataWithRootObject: are deprecated (pinterest#610) update comment Set cachePolicy accordingly when PINRemoteImageManagerDownloadOptionsIgnoreCache is provided Decode WebP images directly into a buffer Core Animation likes (pinterest#600) Xcode 12.5 / SPM - Add missing headers to fix build errors with SPM and Xcode 12.5 (pinterest#597) Fixed spm integration on regular Xcode project (pinterest#586) Fix PINRemoteImageManager.h Close Comment Formatting (pinterest#594) Fix typo in PINRemoteImageManager.html (pinterest#593) Carthage is broken on Xcode 12 (pinterest#584) Update podspec to match release Hopefully fix publish for real this time... # Conflicts: # Package.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
migrate code to new apis.