Skip to content

Xcode 12.5 / SPM - Add missing headers to fix build errors#597

Merged
garrettmoon merged 1 commit intopinterest:masterfrom
bpollman:patch-xcode-12.5
May 18, 2021
Merged

Xcode 12.5 / SPM - Add missing headers to fix build errors#597
garrettmoon merged 1 commit intopinterest:masterfrom
bpollman:patch-xcode-12.5

Conversation

@bpollman
Copy link
Copy Markdown
Contributor

@bpollman bpollman commented Apr 23, 2021

Not sure if this just showed up in the final build of Xcode 12.5 but we're seeing builds errors this in our own project and in the the Example-Xcode-SPM sample project.

I've included the missing headers and it seems to fix the issues for us but not sure if I have impacted Carthage or Cocoapods.

The PINRemoteImage package itself builds fine, but the UIKit classes and extensions are not being exposed resulting in errors like:

<module-includes>:1:9: note: in file included from <module-includes>:1:
#import "/Users/bpollman/Library/Developer/Xcode/DerivedData/app-hdhkkktbvfylmkdtvwdwaqekbyzv/SourcePackages/checkouts/PINRemoteImage/Source/Classes/include/PINRemoteImage.h"
        ^
/Users/bpollman/Library/Developer/Xcode/DerivedData/app-hdhkkktbvfylmkdtvwdwaqekbyzv/SourcePackages/checkouts/PINRemoteImage/Source/Classes/include/PINRemoteImage.h:26:1: warning: umbrella header for module 'PINRemoteImage' does not include header 'PINAnimatedImageView+PINRemoteImage.h'

^
<module-includes>:1:9: note: in file included from <module-includes>:1:
#import "/Users/bpollman/Library/Developer/Xcode/DerivedData/app-hdhkkktbvfylmkdtvwdwaqekbyzv/SourcePackages/checkouts/PINRemoteImage/Source/Classes/include/PINRemoteImage.h"
        ^
/Users/bpollman/Library/Developer/Xcode/DerivedData/app-hdhkkktbvfylmkdtvwdwaqekbyzv/SourcePackages/checkouts/PINRemoteImage/Source/Classes/include/PINRemoteImage.h:26:1: warning: umbrella header for module 'PINRemoteImage' does not include header 'PINAnimatedImageView.h'

^
<module-includes>:1:9: note: in file included from <module-includes>:1:
#import "/Users/bpollman/Library/Developer/Xcode/DerivedData/app-hdhkkktbvfylmkdtvwdwaqekbyzv/SourcePackages/checkouts/PINRemoteImage/Source/Classes/include/PINRemoteImage.h"
        ^
/Users/bpollman/Library/Developer/Xcode/DerivedData/app-hdhkkktbvfylmkdtvwdwaqekbyzv/SourcePackages/checkouts/PINRemoteImage/Source/Classes/include/PINRemoteImage.h:26:1: warning: umbrella header for module 'PINRemoteImage' does not include header 'PINButton+PINRemoteImage.h'

^
<module-includes>:1:9: note: in file included from <module-includes>:1:
#import "/Users/bpollman/Library/Developer/Xcode/DerivedData/app-hdhkkktbvfylmkdtvwdwaqekbyzv/SourcePackages/checkouts/PINRemoteImage/Source/Classes/include/PINRemoteImage.h"
        ^
/Users/bpollman/Library/Developer/Xcode/DerivedData/app-hdhkkktbvfylmkdtvwdwaqekbyzv/SourcePackages/checkouts/PINRemoteImage/Source/Classes/include/PINRemoteImage.h:26:1: warning: umbrella header for module 'PINRemoteImage' does not include header 'PINImageView+PINRemoteImage.h'

^
/Users/bpollman/Library/Developer/Xcode/DerivedData/app-hdhkkktbvfylmkdtvwdwaqekbyzv/SourcePackages/checkouts/PINRemoteImage/Examples/Example-Xcode-SPM/Example-Xcode-SPM/ViewController.swift:13:33: error: cannot find type 'PINAnimatedImageView' in scope
    @IBOutlet weak var imgView: PINAnimatedImageView!
                                ^

@bpollman
Copy link
Copy Markdown
Contributor Author

bpollman commented Apr 30, 2021

Is anyone else seeing this issue with Xcode 12.5?

@ezhes
Copy link
Copy Markdown

ezhes commented May 5, 2021 •
edited
Loading

Also seeing this. Building against a Swift target succeeded but UIKit dependent classes (like PINAnimatedImageView) do not seem to get exposed and so cause errors. Not entirely sure why this broke but your commit fixes, so I appreciate it :)

@bpollman
Copy link
Copy Markdown
Contributor Author

bpollman commented May 18, 2021

Can we get this merged?

@garrettmoon garrettmoon merged commit 93428e8 into pinterest:master May 18, 2021
@bpollman
Copy link
Copy Markdown
Contributor Author

bpollman commented May 18, 2021

Thank you @garrettmoon!

annomusa added a commit to annomusa/PINRemoteImage that referenced this pull request Dec 17, 2021
@annomusa
Merge branch 'master-pinremoteimage' into non-webp
5e5a69b 
* master-pinremoteimage:
  Disable asserts in release builds when using Swift Package Manager
  unarchiveObjectWithData: and archivedDataWithRootObject: are deprecated (pinterest#610)
  update comment
  Set cachePolicy accordingly when PINRemoteImageManagerDownloadOptionsIgnoreCache is provided
  Decode WebP images directly into a buffer Core Animation likes (pinterest#600)
  Xcode 12.5 / SPM - Add missing headers to fix build errors with SPM and Xcode 12.5 (pinterest#597)
  Fixed spm  integration on regular Xcode project (pinterest#586)
  Fix PINRemoteImageManager.h Close Comment Formatting (pinterest#594)
  Fix typo in PINRemoteImageManager.html (pinterest#593)
  Carthage is broken on Xcode 12 (pinterest#584)
  Update podspec to match release
  Hopefully fix publish for real this time...

# Conflicts:
#	Package.swift
@mr-fixit
Copy link
Copy Markdown

mr-fixit commented Oct 22, 2022

could i request a 3.0.4 release ?

Lilfaen pushed a commit to Lilfaen/PINRemoteImage that referenced this pull request Apr 20, 2023
@bpollman @Lilfaen
Xcode 12.5 / SPM - Add missing headers to fix build errors with SPM a…
a307fe7 
…nd Xcode 12.5 (pinterest#597)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bpollman @ezhes @mr-fixit @garrettmoon