export top level enumeration types in typescript-fetch mode#4820
Merged
wing328 merged 1 commit intoswagger-api:masterfrom Mar 27, 2017
tzneal:master
Merged
export top level enumeration types in typescript-fetch mode#4820wing328 merged 1 commit intoswagger-api:masterfrom tzneal:master
wing328 merged 1 commit intoswagger-api:masterfrom
tzneal:master
Conversation
This change enables top level enumeratons to be written out as:
export type SortDirection = "Ascending" | "Descending";
vs.
export class SortDirection {
}
Contributor
|
@tzneal thanks for the PR, which looks good to me. |
Contributor
|
For your upcoming PRs, I would suggest creating a new branch as per git best practices. |
spr3nk3ls
pushed a commit
to spr3nk3ls/swagger-codegen
that referenced
this pull request
Mar 28, 2017
…api#4820) This change enables top level enumeratons to be written out as: export type SortDirection = "Ascending" | "Descending"; vs. export class SortDirection { }
russtacular
added a commit
to russtacular/swagger-codegen
that referenced
this pull request
Mar 28, 2017
…ile-upload-and-dependency-updates * swagger/master: (59 commits) [Java][Retrofit2] update gradle, sbt build file with latest dependencies (swagger-api#5238) update retrofit2 dependencies (swagger-api#5235) Issue swagger-api#3084: remove timestamps from undertow samples (swagger-api#5231) add port 80 to swagger spec (swagger-api#5232) fix msf4j bin script fix c# docstring typo (swagger-api#5223) add comments to csharp methods (swagger-api#5222) fix retrofit2 indentation (swagger-api#5221) Updating samples for spring-stubs, springboot-delegate, springboot-delegate-j8. (swagger-api#5211) export top level enumeration types in typescript-fetch mode (swagger-api#4820) [Erlang] pretty print swagger json (swagger-api#5215) add ci test for msf4j server (swagger-api#5220) Updating samples for JaxRS servers: Spec + CXF-CDI. (swagger-api#5213) Update samples for JaxRS/RestEasy/Joda. (swagger-api#5205) Update samples for Undertow. (swagger-api#5207) Update samples for okhttp-gson-parcelableModel. (swagger-api#5208) Update samples for Java Inflector. (swagger-api#5204) [java][msf4j] Update msf4j samples (and fix artifact name) (swagger-api#5210) Update samples for Ruby-Client + Rails server. (swagger-api#5214) [ASP.NET] Issue swagger-api#5196: add packageGuid parameter to AspNetCoreServerCodegen. (swagger-api#5199) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enables top level enumeratons to be written out as:
vs.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)