Conversation
spr3nk3ls
pushed a commit
to spr3nk3ls/swagger-codegen
that referenced
this pull request
Mar 28, 2017
russtacular
added a commit
to russtacular/swagger-codegen
that referenced
this pull request
Mar 28, 2017
…ile-upload-and-dependency-updates * swagger/master: (59 commits) [Java][Retrofit2] update gradle, sbt build file with latest dependencies (swagger-api#5238) update retrofit2 dependencies (swagger-api#5235) Issue swagger-api#3084: remove timestamps from undertow samples (swagger-api#5231) add port 80 to swagger spec (swagger-api#5232) fix msf4j bin script fix c# docstring typo (swagger-api#5223) add comments to csharp methods (swagger-api#5222) fix retrofit2 indentation (swagger-api#5221) Updating samples for spring-stubs, springboot-delegate, springboot-delegate-j8. (swagger-api#5211) export top level enumeration types in typescript-fetch mode (swagger-api#4820) [Erlang] pretty print swagger json (swagger-api#5215) add ci test for msf4j server (swagger-api#5220) Updating samples for JaxRS servers: Spec + CXF-CDI. (swagger-api#5213) Update samples for JaxRS/RestEasy/Joda. (swagger-api#5205) Update samples for Undertow. (swagger-api#5207) Update samples for okhttp-gson-parcelableModel. (swagger-api#5208) Update samples for Java Inflector. (swagger-api#5204) [java][msf4j] Update msf4j samples (and fix artifact name) (swagger-api#5210) Update samples for Ruby-Client + Rails server. (swagger-api#5214) [ASP.NET] Issue swagger-api#5196: add packageGuid parameter to AspNetCoreServerCodegen. (swagger-api#5199) ...
Contributor
|
Shouldn't port 80 be the default for HTTP, i.e. shouldn't mentioning it be superfluous? |
Contributor
Author
|
@ePaul I remember there was an issue the port number was not captured in {{host}} so that's why I put 80 there to ensure the port number is there. Ideally we should write a unit test to ensure |
ePaul
added a commit
to ePaul/swagger-codegen
that referenced
this pull request
Mar 28, 2017
Contributor
|
I updated the samples (in #5243), the diff might show the relevant places (potentially where we have 8080 → 80?). |
Contributor
Author
|
@ePaul thanks! Later I'l add a Java test case as well.
Not something I would expect. |
ePaul
pushed a commit
to ePaul/swagger-codegen
that referenced
this pull request
Mar 28, 2017
3 tasks
wing328
pushed a commit
that referenced
this pull request
Mar 29, 2017
* Updating samples after #5232. * Fix tests after #5232. * Fix Javascript client tests. * JaxRS server: set serverPort only when not given from outside. * Update JaxRS sample creator scripts to fix serverPort. * Preliminary test fix for JaxRS server generators. * Updating samples for JaxRS with Jersey1/2. * Updating JaxRS samples again.
davidgri
pushed a commit
to davidgri/swagger-codegen
that referenced
this pull request
May 11, 2017
* Updating samples after swagger-api#5232. * Fix tests after swagger-api#5232. * Fix Javascript client tests. * JaxRS server: set serverPort only when not given from outside. * Update JaxRS sample creator scripts to fix serverPort. * Preliminary test fix for JaxRS server generators. * Updating samples for JaxRS with Jersey1/2. * Updating JaxRS samples again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
Add port 80 to Swagger spec so as to ensure the port is shown correctly in the auto-generated code/doc.