Skip to content

[Java][Retrofit2] update retrofit2 dependencies#5235

Merged
wing328 merged 1 commit intoswagger-api:masterfrom
wing328:update_retrofit2_version
Mar 28, 2017
Merged

[Java][Retrofit2] update retrofit2 dependencies#5235
wing328 merged 1 commit intoswagger-api:masterfrom
wing328:update_retrofit2_version

Conversation

@wing328
Copy link
Copy Markdown
Contributor

@wing328 wing328 commented Mar 28, 2017

PR checklist

  • Read the contribution guidelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

update retrofit2 dependencies

For play, we keep retrofit2 version to 2.1.0 due to the following errors:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project swagger-java-client: Compilation failure: Compilation failure:
[ERROR] /Users/williamcheng/Code/jan2017/swagger-codegen/samples/client/petstore/java/retrofit2-play24/src/main/java/io/swagger/client/Play24CallAdapterFactory.java:[17,23] wrong number of type arguments; required 2
[ERROR] /Users/williamcheng/Code/jan2017/swagger-codegen/samples/client/petstore/java/retrofit2-play24/src/main/java/io/swagger/client/Play24CallAdapterFactory.java:[44,24] wrong number of type arguments; required 2
[ERROR] /Users/williamcheng/Code/jan2017/swagger-codegen/samples/client/petstore/java/retrofit2-play24/src/main/java/io/swagger/client/Play24CallAdapterFactory.java:[52,59] wrong number of type arguments; required 2
[ERROR] /Users/williamcheng/Code/jan2017/swagger-codegen/samples/client/petstore/java/retrofit2-play24/src/main/java/io/swagger/client/Play24CallFactory.java:[82,12] io.swagger.client.Play24CallFactory.PlayWSCall is not abstract and does not override abstract method clone() in okhttp3.Call
[ERROR] /Users/williamcheng/Code/jan2017/swagger-codegen/samples/client/petstore/java/retrofit2-play24/src/main/java/io/swagger/client/Play24CallAdapterFactory.java:[60,9] method does not override or implement a method from a supertype
[ERROR] /Users/williamcheng/Code/jan2017/swagger-codegen/samples/client/petstore/java/retrofit2-play24/src/main/java/io/swagger/client/Play24CallAdapterFactory.java:[65,9] method does not override or implement a method from a supertype

@wing328 wing328 added this to the v2.2.3 milestone Mar 28, 2017
@wing328 wing328 merged commit 55e648c into swagger-api:master Mar 28, 2017
@wing328 wing328 deleted the update_retrofit2_version branch March 28, 2017 10:50
russtacular added a commit to russtacular/swagger-codegen that referenced this pull request Mar 28, 2017
…ile-upload-and-dependency-updates

* swagger/master: (59 commits)
  [Java][Retrofit2] update gradle, sbt build file with latest dependencies (swagger-api#5238)
  update retrofit2 dependencies (swagger-api#5235)
  Issue swagger-api#3084: remove timestamps from undertow samples (swagger-api#5231)
  add port 80 to swagger spec (swagger-api#5232)
  fix msf4j bin script
  fix c# docstring typo (swagger-api#5223)
  add comments to csharp methods (swagger-api#5222)
  fix retrofit2 indentation (swagger-api#5221)
  Updating samples for spring-stubs, springboot-delegate, springboot-delegate-j8. (swagger-api#5211)
  export top level enumeration types in typescript-fetch mode (swagger-api#4820)
  [Erlang] pretty print swagger json (swagger-api#5215)
  add ci test for msf4j server (swagger-api#5220)
  Updating samples for JaxRS servers: Spec + CXF-CDI. (swagger-api#5213)
  Update samples for JaxRS/RestEasy/Joda. (swagger-api#5205)
  Update samples for Undertow. (swagger-api#5207)
  Update samples for okhttp-gson-parcelableModel. (swagger-api#5208)
  Update samples for Java Inflector. (swagger-api#5204)
  [java][msf4j] Update msf4j samples (and fix artifact name) (swagger-api#5210)
  Update samples for Ruby-Client + Rails server. (swagger-api#5214)
  [ASP.NET] Issue swagger-api#5196: add packageGuid parameter to AspNetCoreServerCodegen. (swagger-api#5199)
  ...
davidgri pushed a commit to davidgri/swagger-codegen that referenced this pull request May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant