chore: updated amplify.yml file by hdJerry · Pull Request #729 · thisdot/starter.dev-github-showcases

hdJerry · 2022-10-26T12:38:30Z

Setup app deployment for new project

Background

Acceptance

AWS setup for new showcase with working url
Adjust the production environment file to include the new deployment url

Notes

We use AWS Amplify for our deployments
If you do not have access to the AWS account, please ask a manager for access
You should have to modify the amplify.yaml in the top-level directory

aws-amplify-us-east-1 · 2022-10-26T12:41:47Z

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-729.dbm2zhgk5abrj.amplifyapp.com

aws-amplify-us-east-1 · 2022-10-26T12:42:31Z

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-729.d3sqkonra6x7y9.amplifyapp.com

mbicknese · 2022-10-28T12:05:51Z

amplify.yml

+        preBuild:
+          commands:
+            - nvm install --lts=gallium
+            - pnpm install


Not sure if nvm supplies pnpm by default. Do we need to install it?

I think we need to install it, no first class support yet

pnpm/pnpm#1808

@hdJerry what's the update on this?

We can use nvm then.

* chore: updated amplify.yml file * changed pnpm to npm

* in progress * chore: get all repos api * [Angular - NgRx - SCSS] 440: state & service refactor (#527) * setup: get branch caught up and ready for work * feat: refactored repository service and test * feat: refactor of user service and test * feat: updated user service spec * feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls * attempt to fix issues with service updates; some refactoring and adjusting so app compiles * feat: added auth user data to auth state; updated nav component to use auth state * feat: adjusted auth call; fixed user call so home page loads * moved some user logic; still having reload issues and repo view issues * feat: got app working again! cleaned out console logs * rebased and fixed most files * fix broken tests * removed unused code * fix: fix pr comments and most tests * fix: fixed final broken unit test * fix: updated test; removed unused code in user effect; new user mapping file * add todo for refactor improvements; update authUser effect to use different rxjs operation Co-authored-by: LindaT <linda@thisdot.co> * feat(solidjs) - Create navigation header (#840) * fix(angular-apollo-tailwind): append protocol if missing from user url (#637) * fix(angular-apollo-tailwind): append protocol if missing from user url Refs: #591 * test(angular-apollo-tailwind): update with testcases Closes: #591 * chore: repo card with story and test (#737) * chore: repo card with story and test * fix comments * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * chore: gist panel UI (#741) * chore: gist panel UI * fix coment * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * [solidjs-pod] : Create component for search input and filter sort buttons (#831) * in progress * in progress * in progress, paused for now * chore: search filter sort component * fixed comments on icons * [solidjs-tailwinf] Add user profile card (#830) * [SolidJS-Tailwind] Implement authentication (#734) * chore(solidjs): remove example components * feat(solidjs): add signin page * refactor(solidjs): improve auth setup * feat(solidjs): pencil in auth flow * feat(solidjs): add example github communication * [Angular - NgRx - SCSS] 440: state & service refactor (#527) * setup: get branch caught up and ready for work * feat: refactored repository service and test * feat: refactor of user service and test * feat: updated user service spec * feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls * attempt to fix issues with service updates; some refactoring and adjusting so app compiles * feat: added auth user data to auth state; updated nav component to use auth state * feat: adjusted auth call; fixed user call so home page loads * moved some user logic; still having reload issues and repo view issues * feat: got app working again! cleaned out console logs * rebased and fixed most files * fix broken tests * removed unused code * fix: fix pr comments and most tests * fix: fixed final broken unit test * fix: updated test; removed unused code in user effect; new user mapping file * add todo for refactor improvements; update authUser effect to use different rxjs operation Co-authored-by: LindaT <linda@thisdot.co> * feat(solidjs) - Create navigation header (#840) * fix(angular-apollo-tailwind): append protocol if missing from user url (#637) * fix(angular-apollo-tailwind): append protocol if missing from user url Refs: #591 * test(angular-apollo-tailwind): update with testcases Closes: #591 * chore: repo card with story and test (#737) * chore: repo card with story and test * fix comments * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * chore: gist panel UI (#741) * chore: gist panel UI * fix coment * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * chore(solidjs): remove example components * fixed comments, clean ups Co-authored-by: Linda Thompson <lindakt16@gmail.com> Co-authored-by: LindaT <linda@thisdot.co> Co-authored-by: Daian Scuarissi <scuarissid@gmail.com> Co-authored-by: Oluwakorede Cole <asincole@gmail.com> Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co> Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * chore: updated amplify.yml file (#729) * chore: updated amplify.yml file * changed pnpm to npm * chore: workflow added (#745) * chore: workflow added * CI setup fixes and testing * CI setup fixes and testing * CI setup fixes and testing * tried everything but doesn't work, i think we have to merge this * auth token added to header * ..updates * ..updates * auth token added to header * fix file issues * CI adjustments * CI adjustments Co-authored-by: Linda Thompson <lindakt16@gmail.com> Co-authored-by: LindaT <linda@thisdot.co> Co-authored-by: Daian Scuarissi <scuarissid@gmail.com> Co-authored-by: Oluwakorede Cole <asincole@gmail.com> Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> Co-authored-by: Maarten Bicknese <maarten.bicknese@thisdot.co>

* chore: get gists api * updated gists api function * [Angular - NgRx - SCSS] 440: state & service refactor (#527) * setup: get branch caught up and ready for work * feat: refactored repository service and test * feat: refactor of user service and test * feat: updated user service spec * feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls * attempt to fix issues with service updates; some refactoring and adjusting so app compiles * feat: added auth user data to auth state; updated nav component to use auth state * feat: adjusted auth call; fixed user call so home page loads * moved some user logic; still having reload issues and repo view issues * feat: got app working again! cleaned out console logs * rebased and fixed most files * fix broken tests * removed unused code * fix: fix pr comments and most tests * fix: fixed final broken unit test * fix: updated test; removed unused code in user effect; new user mapping file * add todo for refactor improvements; update authUser effect to use different rxjs operation Co-authored-by: LindaT <linda@thisdot.co> * feat(solidjs) - Create navigation header (#840) * fix(angular-apollo-tailwind): append protocol if missing from user url (#637) * fix(angular-apollo-tailwind): append protocol if missing from user url Refs: #591 * test(angular-apollo-tailwind): update with testcases Closes: #591 * chore: repo card with story and test (#737) * chore: repo card with story and test * fix comments * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * chore: gist panel UI (#741) * chore: gist panel UI * fix coment * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * [solidjs-pod] : Create component for search input and filter sort buttons (#831) * in progress * in progress * in progress, paused for now * chore: search filter sort component * fixed comments on icons * [solidjs-tailwinf] Add user profile card (#830) * [SolidJS-Tailwind] Implement authentication (#734) * chore(solidjs): remove example components * feat(solidjs): add signin page * refactor(solidjs): improve auth setup * feat(solidjs): pencil in auth flow * feat(solidjs): add example github communication * [Angular - NgRx - SCSS] 440: state & service refactor (#527) * setup: get branch caught up and ready for work * feat: refactored repository service and test * feat: refactor of user service and test * feat: updated user service spec * feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls * attempt to fix issues with service updates; some refactoring and adjusting so app compiles * feat: added auth user data to auth state; updated nav component to use auth state * feat: adjusted auth call; fixed user call so home page loads * moved some user logic; still having reload issues and repo view issues * feat: got app working again! cleaned out console logs * rebased and fixed most files * fix broken tests * removed unused code * fix: fix pr comments and most tests * fix: fixed final broken unit test * fix: updated test; removed unused code in user effect; new user mapping file * add todo for refactor improvements; update authUser effect to use different rxjs operation Co-authored-by: LindaT <linda@thisdot.co> * feat(solidjs) - Create navigation header (#840) * fix(angular-apollo-tailwind): append protocol if missing from user url (#637) * fix(angular-apollo-tailwind): append protocol if missing from user url Refs: #591 * test(angular-apollo-tailwind): update with testcases Closes: #591 * chore: repo card with story and test (#737) * chore: repo card with story and test * fix comments * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * chore: gist panel UI (#741) * chore: gist panel UI * fix coment * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * chore(solidjs): remove example components * fixed comments, clean ups Co-authored-by: Linda Thompson <lindakt16@gmail.com> Co-authored-by: LindaT <linda@thisdot.co> Co-authored-by: Daian Scuarissi <scuarissid@gmail.com> Co-authored-by: Oluwakorede Cole <asincole@gmail.com> Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co> Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * chore: updated amplify.yml file (#729) * chore: updated amplify.yml file * changed pnpm to npm * chore: workflow added (#745) * chore: workflow added * CI setup fixes and testing * CI setup fixes and testing * CI setup fixes and testing * tried everything but doesn't work, i think we have to merge this * ..updates * ..updates * ..updates * added auth token * added auth token Co-authored-by: Linda Thompson <lindakt16@gmail.com> Co-authored-by: LindaT <linda@thisdot.co> Co-authored-by: Daian Scuarissi <scuarissid@gmail.com> Co-authored-by: Oluwakorede Cole <asincole@gmail.com> Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> Co-authored-by: Maarten Bicknese <maarten.bicknese@thisdot.co>

chore: updated amplify.yml file

a68b378

hdJerry requested review from Zelig880, mbicknese and vyktoremario October 26, 2022 12:38

hdJerry self-assigned this Oct 26, 2022

hdJerry linked an issue Oct 26, 2022 that may be closed by this pull request

[solidjs-pod] 01 Setup App deployment #682

Closed

2 tasks

mbicknese reviewed Oct 28, 2022

View reviewed changes

changed pnpm to npm

4b4306c

hdJerry requested review from kodejuice and mbicknese November 14, 2022 11:55

vyktoremario approved these changes Nov 17, 2022

View reviewed changes

hdJerry merged commit 8c14460 into main Nov 17, 2022

hdJerry deleted the solidjs/setup-app-deployment branch November 17, 2022 12:44

hdJerry added a commit that referenced this pull request Nov 17, 2022

chore: updated amplify.yml file (#729)

02c5cb3

* chore: updated amplify.yml file * changed pnpm to npm

hdJerry added a commit that referenced this pull request Nov 17, 2022

chore: updated amplify.yml file (#729)

7bc24ec

* chore: updated amplify.yml file * changed pnpm to npm

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: updated amplify.yml file#729

chore: updated amplify.yml file#729
hdJerry merged 2 commits intomainfrom
solidjs/setup-app-deployment

hdJerry commented Oct 26, 2022 •

edited

Loading

Uh oh!

aws-amplify-us-east-1 bot commented Oct 26, 2022

Uh oh!

aws-amplify-us-east-1 bot commented Oct 26, 2022

Uh oh!

mbicknese Oct 28, 2022

Uh oh!

kodejuice Oct 28, 2022

Uh oh!

kodejuice Oct 28, 2022

Uh oh!

vyktoremario Nov 11, 2022

Uh oh!

hdJerry Nov 14, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

hdJerry commented Oct 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Setup app deployment for new project

Background

Acceptance

Notes

Uh oh!

aws-amplify-us-east-1 bot commented Oct 26, 2022

Uh oh!

aws-amplify-us-east-1 bot commented Oct 26, 2022

Uh oh!

mbicknese Oct 28, 2022

Choose a reason for hiding this comment

Uh oh!

kodejuice Oct 28, 2022

Choose a reason for hiding this comment

Uh oh!

kodejuice Oct 28, 2022

Choose a reason for hiding this comment

Uh oh!

vyktoremario Nov 11, 2022

Choose a reason for hiding this comment

Uh oh!

hdJerry Nov 14, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hdJerry commented Oct 26, 2022 •

edited

Loading