[solidjs-tailwinf] Add user profile card#830
Merged
vyktoremario merged 3 commits intomainfrom Nov 17, 2022
Merged
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
hdJerry
suggested changes
Nov 7, 2022
| @@ -0,0 +1,19 @@ | |||
| import { For } from 'solid-js'; | |||
| function OrgList(props) { | |||
Contributor
There was a problem hiding this comment.
Use splitProps as it shows a major feature in SolidJs
Contributor
Author
There was a problem hiding this comment.
@hdJerry I don't understand this comment. Can you explain why splitProps is required and how what you mean by it shows a major feature in SolidJs?
Contributor
Author
There was a problem hiding this comment.
@hdJerry splitProps is used when you want to pick out certain properties from an object and pass the rest into a child component. It works the same with Pick in typescript.
It doesn't make sense to use it when all the properties passed are going to be used in that component.
If we need to show how major a feature it is, we can have a store that returns both user and repositories data in one object, then split it into two and pass it into their respective components(or into components where the data is needed). Or do the split inside the component and retrieve just the properties needed by the component.
Contributor
There was a problem hiding this comment.
If the props are not reactive then no need. @vyktoremario , though it also help to know the props expected in there just like how TS does. SO if I view the component with the spiltProps or mergeProps i know the props allowed in that component.
…showcases into feat/688-create-user-profile-card
vyktoremario
requested review from
hdJerry
and removed request for
mbicknese
hdJerry
previously approved these changes
Nov 17, 2022
hdJerry
approved these changes
Nov 17, 2022
hdJerry
pushed a commit
that referenced
this pull request
Nov 17, 2022
hdJerry
pushed a commit
that referenced
this pull request
Nov 17, 2022
hdJerry
added a commit
that referenced
this pull request
Nov 17, 2022
* in progress * chore: get all repos api * [Angular - NgRx - SCSS] 440: state & service refactor (#527) * setup: get branch caught up and ready for work * feat: refactored repository service and test * feat: refactor of user service and test * feat: updated user service spec * feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls * attempt to fix issues with service updates; some refactoring and adjusting so app compiles * feat: added auth user data to auth state; updated nav component to use auth state * feat: adjusted auth call; fixed user call so home page loads * moved some user logic; still having reload issues and repo view issues * feat: got app working again! cleaned out console logs * rebased and fixed most files * fix broken tests * removed unused code * fix: fix pr comments and most tests * fix: fixed final broken unit test * fix: updated test; removed unused code in user effect; new user mapping file * add todo for refactor improvements; update authUser effect to use different rxjs operation Co-authored-by: LindaT <linda@thisdot.co> * feat(solidjs) - Create navigation header (#840) * fix(angular-apollo-tailwind): append protocol if missing from user url (#637) * fix(angular-apollo-tailwind): append protocol if missing from user url Refs: #591 * test(angular-apollo-tailwind): update with testcases Closes: #591 * chore: repo card with story and test (#737) * chore: repo card with story and test * fix comments * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * chore: gist panel UI (#741) * chore: gist panel UI * fix coment * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * [solidjs-pod] : Create component for search input and filter sort buttons (#831) * in progress * in progress * in progress, paused for now * chore: search filter sort component * fixed comments on icons * [solidjs-tailwinf] Add user profile card (#830) * [SolidJS-Tailwind] Implement authentication (#734) * chore(solidjs): remove example components * feat(solidjs): add signin page * refactor(solidjs): improve auth setup * feat(solidjs): pencil in auth flow * feat(solidjs): add example github communication * [Angular - NgRx - SCSS] 440: state & service refactor (#527) * setup: get branch caught up and ready for work * feat: refactored repository service and test * feat: refactor of user service and test * feat: updated user service spec * feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls * attempt to fix issues with service updates; some refactoring and adjusting so app compiles * feat: added auth user data to auth state; updated nav component to use auth state * feat: adjusted auth call; fixed user call so home page loads * moved some user logic; still having reload issues and repo view issues * feat: got app working again! cleaned out console logs * rebased and fixed most files * fix broken tests * removed unused code * fix: fix pr comments and most tests * fix: fixed final broken unit test * fix: updated test; removed unused code in user effect; new user mapping file * add todo for refactor improvements; update authUser effect to use different rxjs operation Co-authored-by: LindaT <linda@thisdot.co> * feat(solidjs) - Create navigation header (#840) * fix(angular-apollo-tailwind): append protocol if missing from user url (#637) * fix(angular-apollo-tailwind): append protocol if missing from user url Refs: #591 * test(angular-apollo-tailwind): update with testcases Closes: #591 * chore: repo card with story and test (#737) * chore: repo card with story and test * fix comments * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * chore: gist panel UI (#741) * chore: gist panel UI * fix coment * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * chore(solidjs): remove example components * fixed comments, clean ups Co-authored-by: Linda Thompson <lindakt16@gmail.com> Co-authored-by: LindaT <linda@thisdot.co> Co-authored-by: Daian Scuarissi <scuarissid@gmail.com> Co-authored-by: Oluwakorede Cole <asincole@gmail.com> Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co> Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * chore: updated amplify.yml file (#729) * chore: updated amplify.yml file * changed pnpm to npm * chore: workflow added (#745) * chore: workflow added * CI setup fixes and testing * CI setup fixes and testing * CI setup fixes and testing * tried everything but doesn't work, i think we have to merge this * auth token added to header * ..updates * ..updates * auth token added to header * fix file issues * CI adjustments * CI adjustments Co-authored-by: Linda Thompson <lindakt16@gmail.com> Co-authored-by: LindaT <linda@thisdot.co> Co-authored-by: Daian Scuarissi <scuarissid@gmail.com> Co-authored-by: Oluwakorede Cole <asincole@gmail.com> Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> Co-authored-by: Maarten Bicknese <maarten.bicknese@thisdot.co>
hdJerry
added a commit
that referenced
this pull request
Nov 18, 2022
* chore: get gists api * updated gists api function * [Angular - NgRx - SCSS] 440: state & service refactor (#527) * setup: get branch caught up and ready for work * feat: refactored repository service and test * feat: refactor of user service and test * feat: updated user service spec * feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls * attempt to fix issues with service updates; some refactoring and adjusting so app compiles * feat: added auth user data to auth state; updated nav component to use auth state * feat: adjusted auth call; fixed user call so home page loads * moved some user logic; still having reload issues and repo view issues * feat: got app working again! cleaned out console logs * rebased and fixed most files * fix broken tests * removed unused code * fix: fix pr comments and most tests * fix: fixed final broken unit test * fix: updated test; removed unused code in user effect; new user mapping file * add todo for refactor improvements; update authUser effect to use different rxjs operation Co-authored-by: LindaT <linda@thisdot.co> * feat(solidjs) - Create navigation header (#840) * fix(angular-apollo-tailwind): append protocol if missing from user url (#637) * fix(angular-apollo-tailwind): append protocol if missing from user url Refs: #591 * test(angular-apollo-tailwind): update with testcases Closes: #591 * chore: repo card with story and test (#737) * chore: repo card with story and test * fix comments * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * chore: gist panel UI (#741) * chore: gist panel UI * fix coment * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * [solidjs-pod] : Create component for search input and filter sort buttons (#831) * in progress * in progress * in progress, paused for now * chore: search filter sort component * fixed comments on icons * [solidjs-tailwinf] Add user profile card (#830) * [SolidJS-Tailwind] Implement authentication (#734) * chore(solidjs): remove example components * feat(solidjs): add signin page * refactor(solidjs): improve auth setup * feat(solidjs): pencil in auth flow * feat(solidjs): add example github communication * [Angular - NgRx - SCSS] 440: state & service refactor (#527) * setup: get branch caught up and ready for work * feat: refactored repository service and test * feat: refactor of user service and test * feat: updated user service spec * feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls * attempt to fix issues with service updates; some refactoring and adjusting so app compiles * feat: added auth user data to auth state; updated nav component to use auth state * feat: adjusted auth call; fixed user call so home page loads * moved some user logic; still having reload issues and repo view issues * feat: got app working again! cleaned out console logs * rebased and fixed most files * fix broken tests * removed unused code * fix: fix pr comments and most tests * fix: fixed final broken unit test * fix: updated test; removed unused code in user effect; new user mapping file * add todo for refactor improvements; update authUser effect to use different rxjs operation Co-authored-by: LindaT <linda@thisdot.co> * feat(solidjs) - Create navigation header (#840) * fix(angular-apollo-tailwind): append protocol if missing from user url (#637) * fix(angular-apollo-tailwind): append protocol if missing from user url Refs: #591 * test(angular-apollo-tailwind): update with testcases Closes: #591 * chore: repo card with story and test (#737) * chore: repo card with story and test * fix comments * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * chore: gist panel UI (#741) * chore: gist panel UI * fix coment * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * chore(solidjs): remove example components * fixed comments, clean ups Co-authored-by: Linda Thompson <lindakt16@gmail.com> Co-authored-by: LindaT <linda@thisdot.co> Co-authored-by: Daian Scuarissi <scuarissid@gmail.com> Co-authored-by: Oluwakorede Cole <asincole@gmail.com> Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co> Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * chore: updated amplify.yml file (#729) * chore: updated amplify.yml file * changed pnpm to npm * chore: workflow added (#745) * chore: workflow added * CI setup fixes and testing * CI setup fixes and testing * CI setup fixes and testing * tried everything but doesn't work, i think we have to merge this * ..updates * ..updates * ..updates * added auth token * added auth token Co-authored-by: Linda Thompson <lindakt16@gmail.com> Co-authored-by: LindaT <linda@thisdot.co> Co-authored-by: Daian Scuarissi <scuarissid@gmail.com> Co-authored-by: Oluwakorede Cole <asincole@gmail.com> Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> Co-authored-by: Maarten Bicknese <maarten.bicknese@thisdot.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #688