[SolidJS-Tailwind] Implement authentication by mbicknese · Pull Request #734 · thisdot/starter.dev-github-showcases

mbicknese · 2022-10-27T09:37:19Z

Implements: #693

aws-amplify-us-east-1 · 2022-10-27T09:40:31Z

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-734.dbm2zhgk5abrj.amplifyapp.com

aws-amplify-us-east-1 · 2022-10-27T09:41:18Z

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-734.d3sqkonra6x7y9.amplifyapp.com

mbicknese · 2022-10-28T08:29:03Z

I'm hesitant about the bailing mechanism, trying to figure out if there's a more native way.

mbicknese · 2022-10-28T08:34:06Z

solidjs-tailwind/vite.config.js

+  resolve: {
+    conditions: ['development', 'browser'],
+    alias: {
+      'node-fetch': 'isomorphic-fetch',


this makes octokit work in the browser

hdJerry · 2022-10-28T09:16:39Z

solidjs-tailwind/src/pages/Signin.jsx

+    }
+
+    setAuth({ token: token() });
+    navigate(sessionStorage.getItem('auth_return_path'));


what happens if auth_return_path undefined and i am not sure what's happening here after token is stored.

Can't hurt to implement a fallback, I'll add it 👍

The trick is to return the user to where they came from before going through the authentication loop.

hdJerry · 2022-10-28T10:20:02Z

solidjs-tailwind/src/auth/preventUnauthorised.js

+  const location = useLocation();
+
+  if (!authStore.isAuthenticated) {
+    sessionStorage.setItem('auth_return_path', location.pathname);


WHat's happening here? Why do we need to do this?

This way we know where we came from on Signin.jsx:22 . It helps us to return the user to their origin.

hdJerry · 2022-10-28T10:24:34Z

solidjs-tailwind/src/routes.js

@@ -0,0 +1,6 @@
+const ROUTES = {
+  HOME: '/',


we can make this like so also in other to distinguish auth required pages from others

HOME: { path: '/', requiresAuth: true, }

using Home as example.

My idea was to split pages and routes. The page knows whether it needs authentication or not, the route is just the pointer to that page.
Maybe PATHS is a better name for this constant?

mbicknese · 2022-10-28T11:50:33Z

#744 should be done at some point, cleaning up some of the mess created here.

kodejuice · 2022-10-28T14:22:59Z

solidjs-tailwind/src/pages/Signin.jsx

+import { useNavigate } from '@solidjs/router';
+
+const fetchToken = () =>
+  fetch('http://localhost:4000/api/auth/token', {


Can you make this an ebvironment variable, other showcases do it that way http://api.starter.dev/api/

kodejuice · 2022-10-28T14:23:16Z

solidjs-tailwind/src/pages/Signin.jsx

+    <main class="absolute bg-black text-gray-500 w-full h-full m-0 p-0 table">
+      <form class="p-64 block mx-auto mb-2">
+        <a
+          href="http://localhost:4000/api/auth/signin?redirect_url=http%3A%2F%2Flocalhost%3A3000"


same, env variable

how did we get this? http%3A%2F%2Flocalhost%3A3000

hdJerry · 2022-10-31T08:29:30Z

solidjs-tailwind/src/pages/Home.jsx

+        .rest.users.getAuthenticated()
+        .then((response) => response.data);
+    } catch {
+      return Promise.resolve({});


Promise.resolve or Promise.reject?

* setup: get branch caught up and ready for work * feat: refactored repository service and test * feat: refactor of user service and test * feat: updated user service spec * feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls * attempt to fix issues with service updates; some refactoring and adjusting so app compiles * feat: added auth user data to auth state; updated nav component to use auth state * feat: adjusted auth call; fixed user call so home page loads * moved some user logic; still having reload issues and repo view issues * feat: got app working again! cleaned out console logs * rebased and fixed most files * fix broken tests * removed unused code * fix: fix pr comments and most tests * fix: fixed final broken unit test * fix: updated test; removed unused code in user effect; new user mapping file * add todo for refactor improvements; update authUser effect to use different rxjs operation Co-authored-by: LindaT <linda@thisdot.co>

#637) * fix(angular-apollo-tailwind): append protocol if missing from user url Refs: #591 * test(angular-apollo-tailwind): update with testcases Closes: #591

* chore: repo card with story and test * fix comments * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>

* chore: gist panel UI * fix coment * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>

approved

* chore(solidjs): remove example components * feat(solidjs): add signin page * refactor(solidjs): improve auth setup * feat(solidjs): pencil in auth flow * feat(solidjs): add example github communication * [Angular - NgRx - SCSS] 440: state & service refactor (#527) * setup: get branch caught up and ready for work * feat: refactored repository service and test * feat: refactor of user service and test * feat: updated user service spec * feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls * attempt to fix issues with service updates; some refactoring and adjusting so app compiles * feat: added auth user data to auth state; updated nav component to use auth state * feat: adjusted auth call; fixed user call so home page loads * moved some user logic; still having reload issues and repo view issues * feat: got app working again! cleaned out console logs * rebased and fixed most files * fix broken tests * removed unused code * fix: fix pr comments and most tests * fix: fixed final broken unit test * fix: updated test; removed unused code in user effect; new user mapping file * add todo for refactor improvements; update authUser effect to use different rxjs operation Co-authored-by: LindaT <linda@thisdot.co> * feat(solidjs) - Create navigation header (#840) * fix(angular-apollo-tailwind): append protocol if missing from user url (#637) * fix(angular-apollo-tailwind): append protocol if missing from user url Refs: #591 * test(angular-apollo-tailwind): update with testcases Closes: #591 * chore: repo card with story and test (#737) * chore: repo card with story and test * fix comments * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * chore: gist panel UI (#741) * chore: gist panel UI * fix coment * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * chore(solidjs): remove example components * fixed comments, clean ups Co-authored-by: Linda Thompson <lindakt16@gmail.com> Co-authored-by: LindaT <linda@thisdot.co> Co-authored-by: Daian Scuarissi <scuarissid@gmail.com> Co-authored-by: Oluwakorede Cole <asincole@gmail.com> Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co> Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>

* in progress * chore: get all repos api * [Angular - NgRx - SCSS] 440: state & service refactor (#527) * setup: get branch caught up and ready for work * feat: refactored repository service and test * feat: refactor of user service and test * feat: updated user service spec * feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls * attempt to fix issues with service updates; some refactoring and adjusting so app compiles * feat: added auth user data to auth state; updated nav component to use auth state * feat: adjusted auth call; fixed user call so home page loads * moved some user logic; still having reload issues and repo view issues * feat: got app working again! cleaned out console logs * rebased and fixed most files * fix broken tests * removed unused code * fix: fix pr comments and most tests * fix: fixed final broken unit test * fix: updated test; removed unused code in user effect; new user mapping file * add todo for refactor improvements; update authUser effect to use different rxjs operation Co-authored-by: LindaT <linda@thisdot.co> * feat(solidjs) - Create navigation header (#840) * fix(angular-apollo-tailwind): append protocol if missing from user url (#637) * fix(angular-apollo-tailwind): append protocol if missing from user url Refs: #591 * test(angular-apollo-tailwind): update with testcases Closes: #591 * chore: repo card with story and test (#737) * chore: repo card with story and test * fix comments * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * chore: gist panel UI (#741) * chore: gist panel UI * fix coment * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * [solidjs-pod] : Create component for search input and filter sort buttons (#831) * in progress * in progress * in progress, paused for now * chore: search filter sort component * fixed comments on icons * [solidjs-tailwinf] Add user profile card (#830) * [SolidJS-Tailwind] Implement authentication (#734) * chore(solidjs): remove example components * feat(solidjs): add signin page * refactor(solidjs): improve auth setup * feat(solidjs): pencil in auth flow * feat(solidjs): add example github communication * [Angular - NgRx - SCSS] 440: state & service refactor (#527) * setup: get branch caught up and ready for work * feat: refactored repository service and test * feat: refactor of user service and test * feat: updated user service spec * feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls * attempt to fix issues with service updates; some refactoring and adjusting so app compiles * feat: added auth user data to auth state; updated nav component to use auth state * feat: adjusted auth call; fixed user call so home page loads * moved some user logic; still having reload issues and repo view issues * feat: got app working again! cleaned out console logs * rebased and fixed most files * fix broken tests * removed unused code * fix: fix pr comments and most tests * fix: fixed final broken unit test * fix: updated test; removed unused code in user effect; new user mapping file * add todo for refactor improvements; update authUser effect to use different rxjs operation Co-authored-by: LindaT <linda@thisdot.co> * feat(solidjs) - Create navigation header (#840) * fix(angular-apollo-tailwind): append protocol if missing from user url (#637) * fix(angular-apollo-tailwind): append protocol if missing from user url Refs: #591 * test(angular-apollo-tailwind): update with testcases Closes: #591 * chore: repo card with story and test (#737) * chore: repo card with story and test * fix comments * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * chore: gist panel UI (#741) * chore: gist panel UI * fix coment * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * chore(solidjs): remove example components * fixed comments, clean ups Co-authored-by: Linda Thompson <lindakt16@gmail.com> Co-authored-by: LindaT <linda@thisdot.co> Co-authored-by: Daian Scuarissi <scuarissid@gmail.com> Co-authored-by: Oluwakorede Cole <asincole@gmail.com> Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co> Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * chore: updated amplify.yml file (#729) * chore: updated amplify.yml file * changed pnpm to npm * chore: workflow added (#745) * chore: workflow added * CI setup fixes and testing * CI setup fixes and testing * CI setup fixes and testing * tried everything but doesn't work, i think we have to merge this * auth token added to header * ..updates * ..updates * auth token added to header * fix file issues * CI adjustments * CI adjustments Co-authored-by: Linda Thompson <lindakt16@gmail.com> Co-authored-by: LindaT <linda@thisdot.co> Co-authored-by: Daian Scuarissi <scuarissid@gmail.com> Co-authored-by: Oluwakorede Cole <asincole@gmail.com> Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> Co-authored-by: Maarten Bicknese <maarten.bicknese@thisdot.co>

* chore: get gists api * updated gists api function * [Angular - NgRx - SCSS] 440: state & service refactor (#527) * setup: get branch caught up and ready for work * feat: refactored repository service and test * feat: refactor of user service and test * feat: updated user service spec * feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls * attempt to fix issues with service updates; some refactoring and adjusting so app compiles * feat: added auth user data to auth state; updated nav component to use auth state * feat: adjusted auth call; fixed user call so home page loads * moved some user logic; still having reload issues and repo view issues * feat: got app working again! cleaned out console logs * rebased and fixed most files * fix broken tests * removed unused code * fix: fix pr comments and most tests * fix: fixed final broken unit test * fix: updated test; removed unused code in user effect; new user mapping file * add todo for refactor improvements; update authUser effect to use different rxjs operation Co-authored-by: LindaT <linda@thisdot.co> * feat(solidjs) - Create navigation header (#840) * fix(angular-apollo-tailwind): append protocol if missing from user url (#637) * fix(angular-apollo-tailwind): append protocol if missing from user url Refs: #591 * test(angular-apollo-tailwind): update with testcases Closes: #591 * chore: repo card with story and test (#737) * chore: repo card with story and test * fix comments * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * chore: gist panel UI (#741) * chore: gist panel UI * fix coment * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * [solidjs-pod] : Create component for search input and filter sort buttons (#831) * in progress * in progress * in progress, paused for now * chore: search filter sort component * fixed comments on icons * [solidjs-tailwinf] Add user profile card (#830) * [SolidJS-Tailwind] Implement authentication (#734) * chore(solidjs): remove example components * feat(solidjs): add signin page * refactor(solidjs): improve auth setup * feat(solidjs): pencil in auth flow * feat(solidjs): add example github communication * [Angular - NgRx - SCSS] 440: state & service refactor (#527) * setup: get branch caught up and ready for work * feat: refactored repository service and test * feat: refactor of user service and test * feat: updated user service spec * feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls * attempt to fix issues with service updates; some refactoring and adjusting so app compiles * feat: added auth user data to auth state; updated nav component to use auth state * feat: adjusted auth call; fixed user call so home page loads * moved some user logic; still having reload issues and repo view issues * feat: got app working again! cleaned out console logs * rebased and fixed most files * fix broken tests * removed unused code * fix: fix pr comments and most tests * fix: fixed final broken unit test * fix: updated test; removed unused code in user effect; new user mapping file * add todo for refactor improvements; update authUser effect to use different rxjs operation Co-authored-by: LindaT <linda@thisdot.co> * feat(solidjs) - Create navigation header (#840) * fix(angular-apollo-tailwind): append protocol if missing from user url (#637) * fix(angular-apollo-tailwind): append protocol if missing from user url Refs: #591 * test(angular-apollo-tailwind): update with testcases Closes: #591 * chore: repo card with story and test (#737) * chore: repo card with story and test * fix comments * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * chore: gist panel UI (#741) * chore: gist panel UI * fix coment * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * chore(solidjs): remove example components * fixed comments, clean ups Co-authored-by: Linda Thompson <lindakt16@gmail.com> Co-authored-by: LindaT <linda@thisdot.co> Co-authored-by: Daian Scuarissi <scuarissid@gmail.com> Co-authored-by: Oluwakorede Cole <asincole@gmail.com> Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co> Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * chore: updated amplify.yml file (#729) * chore: updated amplify.yml file * changed pnpm to npm * chore: workflow added (#745) * chore: workflow added * CI setup fixes and testing * CI setup fixes and testing * CI setup fixes and testing * tried everything but doesn't work, i think we have to merge this * ..updates * ..updates * ..updates * added auth token * added auth token Co-authored-by: Linda Thompson <lindakt16@gmail.com> Co-authored-by: LindaT <linda@thisdot.co> Co-authored-by: Daian Scuarissi <scuarissid@gmail.com> Co-authored-by: Oluwakorede Cole <asincole@gmail.com> Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> Co-authored-by: Maarten Bicknese <maarten.bicknese@thisdot.co>

mbicknese added 2 commits October 26, 2022 14:50

chore(solidjs): remove example components

48df70d

feat(solidjs): add signin page

d3b5f76

mbicknese added 3 commits October 27, 2022 14:01

refactor(solidjs): improve auth setup

e27eff6

feat(solidjs): pencil in auth flow

90a93c0

feat(solidjs): add example github communication

b76eda0

mbicknese commented Oct 28, 2022

View reviewed changes

mbicknese linked an issue Oct 28, 2022 that may be closed by this pull request

[solidjs-pod] 03 Create login page #693

Closed

6 tasks

hdJerry reviewed Oct 28, 2022

View reviewed changes

mbicknese marked this pull request as ready for review October 28, 2022 11:43

mbicknese requested review from hdJerry and vyktoremario October 28, 2022 11:44

mbicknese mentioned this pull request Oct 28, 2022

[solidjs-pod] tech-debt in auth flow #744

Closed

kodejuice previously requested changes Oct 28, 2022

View reviewed changes

hdJerry reviewed Oct 31, 2022

View reviewed changes

lindakatcodes and others added 7 commits November 16, 2022 20:39

feat(solidjs) - Create navigation header (#840)

59333fa

fix(angular-apollo-tailwind): append protocol if missing from user url (

eca9db2

#637) * fix(angular-apollo-tailwind): append protocol if missing from user url Refs: #591 * test(angular-apollo-tailwind): update with testcases Closes: #591

chore: repo card with story and test (#737)

cbdce29

* chore: repo card with story and test * fix comments * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>

chore: gist panel UI (#741)

1d51c86

* chore: gist panel UI * fix coment * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com>

chore(solidjs): remove example components

d4b5ea1

fixed comments, clean ups

3c0431d

hdJerry requested a review from kodejuice November 16, 2022 19:47

hdJerry added 2 commits November 16, 2022 20:53

Merge branch 'main' into solidjs/create-login-page

e0be22a

Merge branch 'main' into solidjs/create-login-page

7aa6e1c

vyktoremario previously approved these changes Nov 17, 2022

View reviewed changes

Merge branch 'main' into solidjs/create-login-page

6708f4b

hdJerry dismissed vyktoremario’s stale review via 6708f4b November 17, 2022 12:29

vyktoremario approved these changes Nov 17, 2022

View reviewed changes

hdJerry merged commit 6f21c5c into main Nov 17, 2022

hdJerry deleted the solidjs/create-login-page branch November 17, 2022 12:44

Conversation

mbicknese commented Oct 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aws-amplify-us-east-1 bot commented Oct 27, 2022

Uh oh!

aws-amplify-us-east-1 bot commented Oct 27, 2022

Uh oh!

mbicknese commented Oct 28, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mbicknese commented Oct 28, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

mbicknese commented Oct 27, 2022 •

edited

Loading