[solidjs-pod] : Create component for search input and filter sort buttons by hdJerry · Pull Request #831 · thisdot/starter.dev-github-showcases

hdJerry · 2022-11-04T17:48:15Z

Create component for search input and filter / sort buttons

Background

This is intended to be a reusable component, wrapping around a few different items that will have their functionality added in another ticket. The focus of this ticket is to create the items themselves and a wrapper around them, so the section can be used in multiple pages. This component will contain an input field for search queries, and a series of dropdown buttons for filtering and sorting.

Acceptance

component will contain the following items - for design of pieces only, do not need functionality yet
- search input with “find a repository..” placeholder
- type dropdown button (does not need to contain options yet)
- language dropdown button (does not need to contain options yet)
- sort dropdown button (does not need to contain options yet)
- divider line
- space for showing text relating to selected options
- clear filter button with x icon (does not need functionality yet)

Notes

aws-amplify-us-east-1 · 2022-11-04T17:51:38Z

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-831.dbm2zhgk5abrj.amplifyapp.com

aws-amplify-us-east-1 · 2022-11-04T17:52:36Z

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-831.d3sqkonra6x7y9.amplifyapp.com

SDaian · 2022-11-07T16:09:10Z

solidjs-tailwind/src/components/RepoFilter/RepoFilter.jsx

+            href="https://github.com/new"
+            class="flex items-center text-white gap-2 bg-green-600 rounded-md px-3 py-1.5 text-sm font-semibold"
+          >
+            <svg


hey maybe its a good idea create a file to export/import the Icons? saw too many svgs, and the files became hard to read., What do you think ?

I agree with this.

SDaian

LGTM

…tons (#831) * in progress * in progress * in progress, paused for now * chore: search filter sort component * fixed comments on icons

* in progress * chore: get all repos api * [Angular - NgRx - SCSS] 440: state & service refactor (#527) * setup: get branch caught up and ready for work * feat: refactored repository service and test * feat: refactor of user service and test * feat: updated user service spec * feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls * attempt to fix issues with service updates; some refactoring and adjusting so app compiles * feat: added auth user data to auth state; updated nav component to use auth state * feat: adjusted auth call; fixed user call so home page loads * moved some user logic; still having reload issues and repo view issues * feat: got app working again! cleaned out console logs * rebased and fixed most files * fix broken tests * removed unused code * fix: fix pr comments and most tests * fix: fixed final broken unit test * fix: updated test; removed unused code in user effect; new user mapping file * add todo for refactor improvements; update authUser effect to use different rxjs operation Co-authored-by: LindaT <linda@thisdot.co> * feat(solidjs) - Create navigation header (#840) * fix(angular-apollo-tailwind): append protocol if missing from user url (#637) * fix(angular-apollo-tailwind): append protocol if missing from user url Refs: #591 * test(angular-apollo-tailwind): update with testcases Closes: #591 * chore: repo card with story and test (#737) * chore: repo card with story and test * fix comments * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * chore: gist panel UI (#741) * chore: gist panel UI * fix coment * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * [solidjs-pod] : Create component for search input and filter sort buttons (#831) * in progress * in progress * in progress, paused for now * chore: search filter sort component * fixed comments on icons * [solidjs-tailwinf] Add user profile card (#830) * [SolidJS-Tailwind] Implement authentication (#734) * chore(solidjs): remove example components * feat(solidjs): add signin page * refactor(solidjs): improve auth setup * feat(solidjs): pencil in auth flow * feat(solidjs): add example github communication * [Angular - NgRx - SCSS] 440: state & service refactor (#527) * setup: get branch caught up and ready for work * feat: refactored repository service and test * feat: refactor of user service and test * feat: updated user service spec * feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls * attempt to fix issues with service updates; some refactoring and adjusting so app compiles * feat: added auth user data to auth state; updated nav component to use auth state * feat: adjusted auth call; fixed user call so home page loads * moved some user logic; still having reload issues and repo view issues * feat: got app working again! cleaned out console logs * rebased and fixed most files * fix broken tests * removed unused code * fix: fix pr comments and most tests * fix: fixed final broken unit test * fix: updated test; removed unused code in user effect; new user mapping file * add todo for refactor improvements; update authUser effect to use different rxjs operation Co-authored-by: LindaT <linda@thisdot.co> * feat(solidjs) - Create navigation header (#840) * fix(angular-apollo-tailwind): append protocol if missing from user url (#637) * fix(angular-apollo-tailwind): append protocol if missing from user url Refs: #591 * test(angular-apollo-tailwind): update with testcases Closes: #591 * chore: repo card with story and test (#737) * chore: repo card with story and test * fix comments * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * chore: gist panel UI (#741) * chore: gist panel UI * fix coment * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * chore(solidjs): remove example components * fixed comments, clean ups Co-authored-by: Linda Thompson <lindakt16@gmail.com> Co-authored-by: LindaT <linda@thisdot.co> Co-authored-by: Daian Scuarissi <scuarissid@gmail.com> Co-authored-by: Oluwakorede Cole <asincole@gmail.com> Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co> Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * chore: updated amplify.yml file (#729) * chore: updated amplify.yml file * changed pnpm to npm * chore: workflow added (#745) * chore: workflow added * CI setup fixes and testing * CI setup fixes and testing * CI setup fixes and testing * tried everything but doesn't work, i think we have to merge this * auth token added to header * ..updates * ..updates * auth token added to header * fix file issues * CI adjustments * CI adjustments Co-authored-by: Linda Thompson <lindakt16@gmail.com> Co-authored-by: LindaT <linda@thisdot.co> Co-authored-by: Daian Scuarissi <scuarissid@gmail.com> Co-authored-by: Oluwakorede Cole <asincole@gmail.com> Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> Co-authored-by: Maarten Bicknese <maarten.bicknese@thisdot.co>

* chore: get gists api * updated gists api function * [Angular - NgRx - SCSS] 440: state & service refactor (#527) * setup: get branch caught up and ready for work * feat: refactored repository service and test * feat: refactor of user service and test * feat: updated user service spec * feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls * attempt to fix issues with service updates; some refactoring and adjusting so app compiles * feat: added auth user data to auth state; updated nav component to use auth state * feat: adjusted auth call; fixed user call so home page loads * moved some user logic; still having reload issues and repo view issues * feat: got app working again! cleaned out console logs * rebased and fixed most files * fix broken tests * removed unused code * fix: fix pr comments and most tests * fix: fixed final broken unit test * fix: updated test; removed unused code in user effect; new user mapping file * add todo for refactor improvements; update authUser effect to use different rxjs operation Co-authored-by: LindaT <linda@thisdot.co> * feat(solidjs) - Create navigation header (#840) * fix(angular-apollo-tailwind): append protocol if missing from user url (#637) * fix(angular-apollo-tailwind): append protocol if missing from user url Refs: #591 * test(angular-apollo-tailwind): update with testcases Closes: #591 * chore: repo card with story and test (#737) * chore: repo card with story and test * fix comments * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * chore: gist panel UI (#741) * chore: gist panel UI * fix coment * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * [solidjs-pod] : Create component for search input and filter sort buttons (#831) * in progress * in progress * in progress, paused for now * chore: search filter sort component * fixed comments on icons * [solidjs-tailwinf] Add user profile card (#830) * [SolidJS-Tailwind] Implement authentication (#734) * chore(solidjs): remove example components * feat(solidjs): add signin page * refactor(solidjs): improve auth setup * feat(solidjs): pencil in auth flow * feat(solidjs): add example github communication * [Angular - NgRx - SCSS] 440: state & service refactor (#527) * setup: get branch caught up and ready for work * feat: refactored repository service and test * feat: refactor of user service and test * feat: updated user service spec * feat: created dashboard store files; updated global state files; renamed RepoState and updated all calls * attempt to fix issues with service updates; some refactoring and adjusting so app compiles * feat: added auth user data to auth state; updated nav component to use auth state * feat: adjusted auth call; fixed user call so home page loads * moved some user logic; still having reload issues and repo view issues * feat: got app working again! cleaned out console logs * rebased and fixed most files * fix broken tests * removed unused code * fix: fix pr comments and most tests * fix: fixed final broken unit test * fix: updated test; removed unused code in user effect; new user mapping file * add todo for refactor improvements; update authUser effect to use different rxjs operation Co-authored-by: LindaT <linda@thisdot.co> * feat(solidjs) - Create navigation header (#840) * fix(angular-apollo-tailwind): append protocol if missing from user url (#637) * fix(angular-apollo-tailwind): append protocol if missing from user url Refs: #591 * test(angular-apollo-tailwind): update with testcases Closes: #591 * chore: repo card with story and test (#737) * chore: repo card with story and test * fix comments * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * chore: gist panel UI (#741) * chore: gist panel UI * fix coment * fix coment Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * chore(solidjs): remove example components * fixed comments, clean ups Co-authored-by: Linda Thompson <lindakt16@gmail.com> Co-authored-by: LindaT <linda@thisdot.co> Co-authored-by: Daian Scuarissi <scuarissid@gmail.com> Co-authored-by: Oluwakorede Cole <asincole@gmail.com> Co-authored-by: Jerry Hogan <jerry.hogan@thisdot.co> Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> * chore: updated amplify.yml file (#729) * chore: updated amplify.yml file * changed pnpm to npm * chore: workflow added (#745) * chore: workflow added * CI setup fixes and testing * CI setup fixes and testing * CI setup fixes and testing * tried everything but doesn't work, i think we have to merge this * ..updates * ..updates * ..updates * added auth token * added auth token Co-authored-by: Linda Thompson <lindakt16@gmail.com> Co-authored-by: LindaT <linda@thisdot.co> Co-authored-by: Daian Scuarissi <scuarissid@gmail.com> Co-authored-by: Oluwakorede Cole <asincole@gmail.com> Co-authored-by: Victor Chukwuebuka Umeh <41862157+vyktoremario@users.noreply.github.com> Co-authored-by: Maarten Bicknese <maarten.bicknese@thisdot.co>

hdJerry added 4 commits October 28, 2022 13:00

in progress

8910df9

in progress

dcfb38c

in progress, paused for now

4946694

chore: search filter sort component

2bf1ccd

hdJerry self-assigned this Nov 4, 2022

hdJerry linked an issue Nov 4, 2022 that may be closed by this pull request

[solidjs-pod] 17 Create component for search input and filter sort buttons #687

Closed

8 tasks

SDaian reviewed Nov 7, 2022

View reviewed changes

hdJerry added 2 commits November 14, 2022 11:51

fixed comments on icons

ebbb2c1

fixed conclicts

6e9a6ff

hdJerry requested review from SDaian and vyktoremario November 14, 2022 10:55

SDaian approved these changes Nov 14, 2022

View reviewed changes

hdJerry merged commit f2dcff4 into main Nov 17, 2022

hdJerry deleted the solidjs/search-filter-sort-component branch November 17, 2022 08:53

hdJerry added a commit that referenced this pull request Nov 17, 2022

[solidjs-pod] : Create component for search input and filter sort but…

2e5bc03

…tons (#831) * in progress * in progress * in progress, paused for now * chore: search filter sort component * fixed comments on icons

hdJerry added a commit that referenced this pull request Nov 17, 2022

[solidjs-pod] : Create component for search input and filter sort but…

6ae55b0

…tons (#831) * in progress * in progress * in progress, paused for now * chore: search filter sort component * fixed comments on icons

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[solidjs-pod] : Create component for search input and filter sort buttons#831

[solidjs-pod] : Create component for search input and filter sort buttons#831
hdJerry merged 6 commits intomainfrom
solidjs/search-filter-sort-component

hdJerry commented Nov 4, 2022

Uh oh!

aws-amplify-us-east-1 bot commented Nov 4, 2022

Uh oh!

aws-amplify-us-east-1 bot commented Nov 4, 2022

Uh oh!

SDaian Nov 7, 2022

Uh oh!

vyktoremario Nov 11, 2022

Uh oh!

SDaian left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

hdJerry commented Nov 4, 2022

Create component for search input and filter / sort buttons

Background

Acceptance

Notes

Uh oh!

aws-amplify-us-east-1 bot commented Nov 4, 2022

Uh oh!

aws-amplify-us-east-1 bot commented Nov 4, 2022

Uh oh!

SDaian Nov 7, 2022

Choose a reason for hiding this comment

Uh oh!

vyktoremario Nov 11, 2022

Choose a reason for hiding this comment

Uh oh!

SDaian left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants