Ports Turnstiles from NSV13 (or beestation no clue where they came from) #12105

maxion12345 · 2021-08-22T20:30:22Z

Github documenting your Pull Request

Adds turnstiles! These are more or less one-way doors that let people with no access pass in one direction, and block them in the other! if you have access, it'll let you pass both ways. Originally used for brig doors so prisoners can grab their shit and leave without needing someone to get the door. Only added them to HoP line because prisoner lockers are bugged and they need help to leave anyways.

Wiki Documentation

Update HoP line photo

Changelog

🆑 AndrewMontagne, NSV13, Adamsong & Maxim
rscadd: Added turnstiles that allow people to pass only in one direction. If you have the set access, you can pass in both directions.
rscadd: Yogstation HoP now has turnstiles to keep the gray masses moving in one direction.
/:cl:

maxion12345 · 2021-08-22T20:30:53Z

i don't know why it has "updating wheelchair.dm" on there it doesn't even change anything that was merged already

Mqiib · 2021-08-22T20:31:11Z

we have this already, there are settings for doors that allow anyone to open them from one side.

patpol4 · 2021-08-22T20:33:33Z

yes but this only lets one person pass and only from one side

maxion12345 · 2021-08-22T21:18:52Z

we have this already, there are settings for doors that allow anyone to open them from one side.

this also looks nicer

that all being said i am not good coder so i don't know why lints is angry at me :(

maxion12345 · 2021-08-22T21:23:59Z

fixed the map test now i gotta figure out why the proc isn't doing the stuff the proc should be doing

i don't know how to do this
it works
i tested it
can i paypal the headcoders 20 bucks to ignore the tests

adamsong · 2021-08-23T03:39:21Z

/obj/machinery/turnstile/proc/CanPass is the wrong proc, you want Cross

CanPass is marked a pure, which means it should not change any state, simply return a value, https://toolz.readthedocs.io/en/latest/purity.html

adamsong · 2021-08-23T05:22:33Z

I sad Cross not CanCross

maxion12345 · 2021-08-23T05:23:21Z

I sad Cross not CanCross

you right its late

patpol4

Map is good.

Also I'm not a spriteman but if those direction arrows are visible ingame and are not just helpers then it looks ass.

maxion12345 · 2021-08-23T05:30:49Z

Map is good.

Also I'm not a spriteman but if those direction arrows are visible ingame and are not just helpers then it looks ass.

helpers

nesisknesis

If this is a port, please put a link to the original PR in the description and credit the author.

JamieD1 · 2021-08-30T11:20:55Z

Can you find some more noises which might be more suitable?

Also can you make a half tile option which is climb over able for less secure areas, I dont like the look of the fecking prison style ones.

adamsong · 2021-08-30T17:42:35Z

Make medical ones for the main medbay areas

maxion12345 · 2021-08-31T01:26:10Z

Can you find some more noises which might be more suitable?

Also can you make a half tile option which is climb over able for less secure areas, I dont like the look of the fecking prison style ones.

not sure I can, these are meant for secure areas

or when you want people moving in one direction, like the HoP line. climbing over them would kinda defeat the purpose

maxion12345 · 2021-08-31T01:40:28Z

Make medical ones for the main medbay areas

Surgery, treatment area, and the medbay exit doors are now turnstiles. This will probably be reverted though, not sure they work well in medbay

This reverts commit 8b6f6d6.

maxion12345 · 2021-08-31T01:49:50Z

git angy :(

JamieD1 · 2021-09-01T16:07:36Z

Ones like this

maxion12345 · 2021-09-02T03:27:32Z

Ones like this

aye I've got climbing half-working. if you don't have to access it'll just make you not climb it. I got work for the next few days so i'll find a workaround

maxion12345 · 2021-09-04T00:32:39Z

@JamieD1 made a turnstile thats climbable, and one that isn't

…into turnstiles

JamieD1 · 2021-09-11T12:22:25Z

@JamieD1 made a turnstile thats climbable, and one that isn't

Did you really just cut the sprite in half...?

Much dissapoint.

AnCopper · 2021-09-11T12:34:10Z

@JamieD1 made a turnstile thats climbable, and one that isn't

Did you really just cut the sprite in half...?

Much dissapoint.

Powermove tbh.

maxion12345 · 2021-09-12T18:29:47Z

@JamieD1 made a turnstile thats climbable, and one that isn't

Did you really just cut the sprite in half...?

Much dissapoint.

listen you did not want to see the codersprite that I made for it
just trust me on this, this is the better choice
we can replace it later with something not so cringe

JamieD1 · 2021-09-17T11:39:24Z

@JamieD1 made a turnstile thats climbable, and one that isn't

Did you really just cut the sprite in half...?
Much dissapoint.

listen you did not want to see the codersprite that I made for it
just trust me on this, this is the better choice
we can replace it later with something not so cringe

"fix later"
"never fix"

* Fixed comment on admins.txt mentioning character stripping that no longer occurs (#12282) * Automatic changelog generation #12282 [ci skip] * Adds council (#12283) * Automatic changelog compile [ci skip] * Duffffffffffffffffffffffels (#12289) * Automatic changelog generation #12289 [ci skip] * Ports wounds from TG (#11955) * piss * second set of files * theos feels pain and dies * code works lmao * other stuff * YES YES YES * Update zombies.dm * egg * whoops * bubblegum alt attacks won't wound * bone hurting juice hurts bones * something's fucky wucky * humans are no longer blue space babes but projectile damage is still wack * IT WORKS??????? * other stuff * turns out im big brain and already handled that should be testable live now * WHOOPS * medical pens not in stupid area * fix regen mesh icons * tool_behavior and defines plus allowing wound healing to override surgical tool no touchy bit * should help * mapping problem * fix monkies shitting out blood all the time * going to remove examine_more being stupid * this is stupid i think it works though * Empty commit, more bad code * this probably fdixes something * buckshot buffed back to where it should be * woundings * missed this one * fix gamebreaking bug * turns out damaging ANYTHING causes suit sensors to break whoops * stuff up to limb disable refactor * aid scanner can no longer kill you if you use it too much, preventing the robot uprising for another few decades * Update burn_dressing.dm * wtf * shotgun slugs have a wound bonus of -30 putting them in line with other high damage weaponry that has even less * burn debriding uses the scalpel rather than the hemostat * debriding for patch/treat no longer causes wounds * Give syndicate medical cyborg a bonesetter * like 5 more prs ported * fixes burn ointment and mesh application not having a progress bar * gamemode zombies get easydismember and easily wounded * managed to screw up self cautery this fixes it * carbons can't use check self for injuries but humans can * honey gives +2 sanitization to burns * re-add this if sensors get fixed * should fix a runtime I made on accident when trying to make examine more less jank * last 2 prs and some holdup fixes since these touched on that * set target = src so the progress par shows up i think * Update mutations.dm * fixes twohanded reuqired weapons by reverting some change I don't understand * fixes blood sprites * actually properly fixes the thing Co-authored-by: Gabriel Adamson <adamson.g@gmail.com> Co-authored-by: Jamie D <993128+JamieD1@users.noreply.github.com> * Automatic changelog generation #11955 [ci skip] * *oil rig explodes* (#12235) Co-authored-by: Idinuum <37936685+Idinuum@users.noreply.github.com> * Automatic changelog generation #12235 [ci skip] * Update ai_laws.dm (#12263) * fixes seed exports (#12274) * Automatic changelog generation #12274 [ci skip] * rarity schmarity (#12275) * Automatic changelog generation #12275 [ci skip] * removes second define (#12278) * Automatic changelog generation #12278 [ci skip] * gives nicotine free cigarettes a expanded description to make more sense (#12271) * Update cigs_lighters.dm * Update code/game/objects/items/cigs_lighters.dm Co-authored-by: Byemoh <baiomurang@gmail.com> * Update code/game/objects/items/cigs_lighters.dm Co-authored-by: Byemoh <baiomurang@gmail.com> Co-authored-by: Jamie D <993128+JamieD1@users.noreply.github.com> * Automatic changelog generation #12271 [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * adds click catcher (#12296) Co-authored-by: Idinuum <37936685+Idinuum@users.noreply.github.com> * Automatic changelog generation #12296 [ci skip] * Yeets Council * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Fixed the filling in vials (#12305) So, turns out I didn't upload the icons for the vial fillings. * Automatic changelog generation #12305 [ci skip] * Adds 2 new names to the Space Ninja naming list. (#12295) * The "La-Li-Lu-Le-Lo"! How's that possible! * i change my mind on these ones Co-authored-by: Idinuum <37936685+Idinuum@users.noreply.github.com> * Automatic changelog generation #12295 [ci skip] * PROPER UNITS (#12308) * Automatic changelog generation #12308 [ci skip] * Fixed typo in burn healing surgery (#12300) * Automatic changelog generation #12300 [ci skip] * Update revival.dm (#12309) * Automatic changelog generation #12309 [ci skip] * Automatic changelog compile [ci skip] * Update CONTRIBUTING.md (#12306) * Adds an href token to the mob spawn VV link (#12294) * Automatic changelog generation #12294 [ci skip] * Adds Wall Rechargers (#12307) * Initial * Box Changes * Automatic changelog generation #12307 [ci skip] * Update AutoChangelog-pr-12307.yml * Automatic changelog compile [ci skip] * Doing a major TEG rework because the current one is a mess that breaks thermodynamics (#11864) * tweak TEG having icon when connect to circulator with no powergrid * i redo the TEG code because it broke thermodynamics * comments * fixed typo * is this more accurate? * not it should work like normal physics does * framework is done * Update code/modules/power/generator.dm Co-authored-by: adamsong <adamsong@users.noreply.github.com> Co-authored-by: adamsong <adamsong@users.noreply.github.com> * Automatic changelog generation #11864 [ci skip] * Ports Turnstiles from NSV13 (or beestation no clue where they came from) (#12105) * Update wheelchair.dm * Update wheelchair.dm * somethuing something * forgot the dme * adds them to yogstation * fix access * attempt #1 to fix the thing * attempt 2 to fix the thing * fixing the fix so that it's fixed * Update code/game/machinery/doors/turnstile.dm * Fixes turnstiles * adds turnstiles to medbay per adam's request * Revert "adds turnstiles to medbay per adam's request" This reverts commit 8b6f6d6. * swag * adds the ministile to the game * replace hopline turnstile with the ministile * removes climbing code from non-climbing parts * removes old turnstiles from hop line again * i forget to tick the box * i tick the box again Co-authored-by: adamsong <adamsong@users.noreply.github.com> Co-authored-by: Gabriel Adamson <adamson.g@gmail.com> * Automatic changelog generation #12105 [ci skip] * Fix floodlights not turning off when out of power, and fixes sling veil not working on them (#12222) * Fix floodlights not turning off when out of power, and fixes sling veil not working on them * Update yogstation/code/modules/antagonists/shadowling/shadowling_abilities.dm * Automatic changelog generation #12222 [ci skip] * Steals tg's span macros (#12232) * Steals tg's span macros * Fix alphabet * Updated some more spans * Misses a conflict * Fix compile errors * Converts more spans * oops * Lists inside of lists.. (#12273) * Automatic changelog generation #12273 [ci skip] * Extends AI core power zones over the cameras to make repairing the cameras less janky. (#12281) * Automatic changelog generation #12281 [ci skip] * Kills off price elasticity and buffs several exports because I hate balance (#12288) * switches phazons from a bounty to an export so they can be sold more easily adds an export limit variable that limits the number of times something can be exported removes price elasticity adds a couple new exports buffs several exports because lol * silver bit and failure to compiwe * Update organs.dm * fixing merge conflicts is an art * reduce human skin 2000 > 1000 since it's easy to get * Update sheets.dm * nerfs organ prices so monkey spam can't get infinite cash Co-authored-by: Jamie D <993128+JamieD1@users.noreply.github.com> * Automatic changelog generation #12288 [ci skip] * Adds a fallback if the bar selection is null, along with plenty of admin messages (#12297) * Adds a fallback if the bar selection is null, along with plenty of admin messages * Update code/controllers/subsystem/job.dm Co-authored-by: TheGamerdk <5618080+TheGamerdk@users.noreply.github.com> * Update job.dm * Added logging to log_game * Copied the wrong string Co-authored-by: TheGamerdk <5618080+TheGamerdk@users.noreply.github.com> * Automatic changelog generation #12297 [ci skip] * Stops adding 'Random' to the list of bars, also makes the cancel button not change preference, rather than clear it (#12298) * Stops adding 'Random' to the list of bars, also makes the cancel button not change preference, rather than clear it * Makes it actually compile * Automatic changelog generation #12298 [ci skip] * adds a cap on throwspeed from monstermos to carbons so you probably won't bust your bones open nearly as often (#12302) * Automatic changelog generation #12302 [ci skip] * I did a thing (#12316) Renamed microwave ovens to bluespace microwave ovens. * Automatic changelog generation #12316 [ci skip] * [admin] Revamp auto deadmin (#12286) * Adds a minimum admin count to auto-deadmin, also adds a preference for auto-deadmin on critical roles * Disables the forced deadmin, increases the threshold * Changed config to be the minimum to auto-deadming, as its more intuitive * Remove drone from silicon auto-deadmin Co-authored-by: Jamie D <993128+JamieD1@users.noreply.github.com> * Automatic changelog generation #12286 [ci skip] * Round End Sounds start on "Rebooting in 10 Seconds now" (#12292) * Round End Sounds start on "Rebooting in 10 Seconds now" * e * JANK * e * Automatic changelog generation #12292 [ci skip] * Allow mods to soft reboot the server, also allows admins to reboot the server ignoring tickets (#12299) Co-authored-by: Jamie D <993128+JamieD1@users.noreply.github.com> * Automatic changelog generation #12299 [ci skip] * Update turdis.yml * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * Update recharger.dm * Signal-Skill-Cape update! *BzZzZT* (#12311) * Update skillcapes.dmi * Update neck.dmi * Update skillcapes.dmi * Update neck.dmi * Update neck.dmi * Update skillcapes.dmi * Automatic changelog generation #12311 [ci skip] * Sheltered nerf (#12325) With the changes to Sheltered making it able to understand Common, simply not speak it, it needs updates to its' descriptive text and it also needs a drop in quirk point value. * Automatic changelog generation #12325 [ci skip] * Replaces the freezers with blood in it with blood freezers (#12276) * Automatic changelog generation #12276 [ci skip] * Automatic changelog compile [ci skip] * Automatic changelog compile [ci skip] * should fix a minor bone fixing issue (#12351) * Automatic changelog generation #12351 [ci skip] * Revert TEG Heater because PR 11864 (#12341) * quick fix (#12348) * Automatic changelog generation #12348 [ci skip] * help it broken (#12265) * Automatic changelog generation #12265 [ci skip] * Fixes a mapping error in meta maint that I probably did on accident (#12344) * Automatic changelog generation #12344 [ci skip] * Removed a pixel (#12356) Removed a stray pixel on the vomit goose shirt * Automatic changelog generation #12356 [ci skip] * Update pandemic.dm (#12361) * Automatic changelog generation #12361 [ci skip] * Revert "Update pandemic.dm (#12361)" This reverts commit 8128dc4. Co-authored-by: adamsong <adamsong@users.noreply.github.com> Co-authored-by: Yogbot-13 <admin@yogstation.net> Co-authored-by: alexkar598 <25136265+alexkar598@users.noreply.github.com> Co-authored-by: Changelogs <action@github.com> Co-authored-by: Jamie D <993128+JamieD1@users.noreply.github.com> Co-authored-by: Theos <theubernyan@gmail.com> Co-authored-by: Gabriel Adamson <adamson.g@gmail.com> Co-authored-by: grimm-hollowknight <37936685+grimm-hollowknight@users.noreply.github.com> Co-authored-by: Idinuum <37936685+Idinuum@users.noreply.github.com> Co-authored-by: Chubbygummibear <46236974+Chubbygummibear@users.noreply.github.com> Co-authored-by: azzzertyy <42524344+azzzertyy@users.noreply.github.com> Co-authored-by: boodaliboo <40642354+boodaliboo@users.noreply.github.com> Co-authored-by: Byemoh <baiomurang@gmail.com> Co-authored-by: nmajask <nmajask@gmail.com> Co-authored-by: Mqiib <43766432+Mqiib@users.noreply.github.com> Co-authored-by: Lostlarry <51096401+Lostlarry@users.noreply.github.com> Co-authored-by: Maxim <maxion1234@gmail.com> Co-authored-by: JC Denthead <63614296+jc-denthead@users.noreply.github.com> Co-authored-by: Darthkill <33874385+Darthkill@users.noreply.github.com> Co-authored-by: KillerOrcaCora <82983051+KillerOrcaCora@users.noreply.github.com> Co-authored-by: Anvilman6 <54463777+Anvilman6@users.noreply.github.com> Co-authored-by: Aquizit <70451213+Aquizit@users.noreply.github.com> Co-authored-by: N3D6 <71906740+N3D6@users.noreply.github.com>

maxion12345 added 8 commits July 22, 2021 01:10

Update wheelchair.dm

9c7a528

Update wheelchair.dm

b2467a9

Merge branch 'yogstation13:master' into master

6371bdf

Merge branch 'yogstation13:master' into master

b88d759

somethuing something

c4b817c

forgot the dme

95de2de

adds them to yogstation

7e712ae

fix access

4279a81

maxion12345 requested review from a team as code owners August 22, 2021 20:30

Yogbot-13 added DME Edit This PR affects the yogstation.DME file Feature This adds new content to the game Mapping Will result in a change to a map. Sprites This PR has spriting changes labels Aug 22, 2021

attempt #1 to fix the thing

c208e8b

attempt 2 to fix the thing

7fcbda7

fixing the fix so that it's fixed

f567e06

patpol4 approved these changes Aug 23, 2021

View reviewed changes

patpol4 added the Map - Approved This PR's mapping side has been approved by a mapping maintainer label Aug 23, 2021

nesisknesis approved these changes Aug 23, 2021

View reviewed changes

nesisknesis reviewed Aug 25, 2021

View reviewed changes

adds turnstiles to medbay per adam's request

8b6f6d6

Revert "adds turnstiles to medbay per adam's request"

5ac856d

This reverts commit 8b6f6d6.

overlord12345 mentioned this pull request Sep 2, 2021

demons getting deleted while exiting blood pools #12224

Open

maxion12345 added 4 commits September 2, 2021 11:56

swag

303768a

Merge branch 'yogstation13:master' into turnstiles

8448cf8

adds the ministile to the game

624b025

replace hopline turnstile with the ministile

bccc93b

maxion12345 added 5 commits September 3, 2021 20:35

removes climbing code from non-climbing parts

42a1fa7

removes old turnstiles from hop line again

d053b97

i forget to tick the box

8d64768

Merge branch 'turnstiles' of https://github.com/maxion12345/Yogstation …

fa0d57f

…into turnstiles

i tick the box again

b55180e

Sniblet mentioned this pull request Sep 6, 2021

Cyborgs immune to light eaters #12256

Closed

TheBombMakerJL mentioned this pull request Sep 15, 2021

Solo Changelings can get the Absorb Another Changeling Obj #12313

Closed

JamieD1 merged commit 55c1d93 into yogstation13:master Sep 17, 2021

Yogbot-13 added a commit that referenced this pull request Sep 17, 2021

Automatic changelog generation #12105 [ci skip]

43cd0c2

maxion12345 deleted the turnstiles branch September 24, 2021 04:17

Uh oh!

Ports Turnstiles from NSV13 (or beestation no clue where they came from) #12105

Ports Turnstiles from NSV13 (or beestation no clue where they came from) #12105

Uh oh!

Conversation

maxion12345 commented Aug 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Github documenting your Pull Request

Wiki Documentation

Changelog

Uh oh!

maxion12345 commented Aug 22, 2021

Uh oh!

Mqiib commented Aug 22, 2021

Uh oh!

patpol4 commented Aug 22, 2021

Uh oh!

maxion12345 commented Aug 22, 2021

Uh oh!

maxion12345 commented Aug 22, 2021

Uh oh!

adamsong commented Aug 23, 2021

Uh oh!

adamsong commented Aug 23, 2021

Uh oh!

maxion12345 commented Aug 23, 2021

Uh oh!

patpol4 left a comment

Choose a reason for hiding this comment

Uh oh!

maxion12345 commented Aug 23, 2021

Uh oh!

nesisknesis left a comment

Choose a reason for hiding this comment

Uh oh!

JamieD1 commented Aug 30, 2021

Uh oh!

adamsong commented Aug 30, 2021

Uh oh!

maxion12345 commented Aug 31, 2021

Uh oh!

maxion12345 commented Aug 31, 2021

Uh oh!

maxion12345 commented Aug 31, 2021

Uh oh!

JamieD1 commented Sep 1, 2021

Uh oh!

maxion12345 commented Sep 2, 2021

Uh oh!

maxion12345 commented Sep 4, 2021

Uh oh!

JamieD1 commented Sep 11, 2021

Uh oh!

AnCopper commented Sep 11, 2021

Uh oh!

maxion12345 commented Sep 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JamieD1 commented Sep 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

maxion12345 commented Aug 22, 2021 •

edited

Loading

maxion12345 commented Sep 12, 2021 •

edited

Loading